Re: [PATCH 3/3] winex11: Remove unused X11DRV_GET_DRAWABLE and struct x11drv_escape_get_drawable.
On Mar 31, 2014, at 9:47 PM, Ken Thomases wrote:
dlls/winex11.drv/init.c | 8 -------- dlls/winex11.drv/x11drv.h | 9 --------- 2 files changed, 17 deletions(-)
<0003-winex11-Remove-unused-X11DRV_GET_DRAWABLE-and-struct.patch>
Was there something wrong with this? Is it anticipated that the GET_DRAWABLE escape will be needed in the future?
-Ken
Ken Thomases ken@codeweavers.com writes:
On Mar 31, 2014, at 9:47 PM, Ken Thomases wrote:
dlls/winex11.drv/init.c | 8 -------- dlls/winex11.drv/x11drv.h | 9 --------- 2 files changed, 17 deletions(-)
<0003-winex11-Remove-unused-X11DRV_GET_DRAWABLE-and-struct.patch>
Was there something wrong with this? Is it anticipated that the GET_DRAWABLE escape will be needed in the future?
Not really, but it can be useful for third party code. Why do you want to remove it?
On Apr 2, 2014, at 2:36 AM, Alexandre Julliard wrote:
Ken Thomases ken@codeweavers.com writes:
On Mar 31, 2014, at 9:47 PM, Ken Thomases wrote:
dlls/winex11.drv/init.c | 8 -------- dlls/winex11.drv/x11drv.h | 9 --------- 2 files changed, 17 deletions(-)
<0003-winex11-Remove-unused-X11DRV_GET_DRAWABLE-and-struct.patch>
Was there something wrong with this? Is it anticipated that the GET_DRAWABLE escape will be needed in the future?
Not really, but it can be useful for third party code. Why do you want to remove it?
I don't have any strong urge to remove it. I just thought it was dead code and I was cleaning up. I hadn't considered third-party code using it. Thanks for satisfying my curiosity.
-Ken
-
Alexandre Julliard -
Ken Thomases