Re: [PATCH] gdi32: Initialize system font link registry.

[Huw Davies]

On Wed, Nov 04, 2015 at 09:40:38PM +0800, Qian Hong wrote:
> +static void update_font_system_link_info(UINT current_ansi_codepage)
> - if (RegCreateKeyA(HKEY_LOCAL_MACHINE, font_link_reg_key, &hkey) == ERROR_SUCCESS)
> - {
> -
>    HKEY hsubkey;
> -
>    if (RegCreateKeyA(hkey, system_link_subkey, &hsubkey) == ERROR_SUCCESS)
> -
>    {

You could create this key in one call.

Please use the unicode registry functions for both key creation and
value setting (yes, I know there are many ansi versions already there,
but let's avoid adding more!).  You'll find the system link unicode
string already defined in 'system_link'.

Huw.

[PATCH] gdi32: Initialize system font link registry.

[Qian Hong]

Hi,

On Fri, Nov 6, 2015 at 6:28 PM, Huw Davies  wrote:
> You could create this key in one call.
>
> Please use the unicode registry functions for both key creation and
> value setting (yes, I know there are many ansi versions already there,
> but let's avoid adding more!).  You'll find the system link unicode
> string already defined in 'system_link'.

Sorry for delay, was moving during weekend. I adjust my patch
according to your suggestions, try 2 sent. Thank you for review!