edit control bug

[Felipe W Damasio]

Hi,

I'm porting a software using winelib and found a (at least I think so) 
serious bug with the edit control: When you put a lot of text in an 
edit control and then begins to backspace them, the app simply seg faults.

I'm using wine-20030115 but also tried wine-20021031, and both have 
this bug.

Both the source and the executable for test are available here:

ftp://elipse.com.br/pub/EditControl/about1-src.tar.gz

ftp://elipse.com.br/pub/EditControl/about1-exe.tar.gz

Yeah, I stole the example from Petzold's book....so please enter 
help->about to see the dialog :)

Can anyone help with this? Is this a known wine bug?

I did the usual google search but couldn't fine any reference of this.

But if is: Is somebody working on it?

Or will anyone work on this? And can I help?

Thanks for any help you can give me (please CC me).

Felipe

[Tony Lambregts]

Felipe W Damasio wrote:
> Hi,
>
> I'm porting a software using winelib and found a (at least I think 
>
> so) serious bug with the edit control: When you put a lot of text in 
> an edit control and then begins to backspace them, the app simply seg 
> faults.
> I'm using wine-20030115 but also tried wine-20021031, and both 
>
> have this bug.
> Both the source and the executable for test are available here:
>
> ftp://elipse.com.br/pub/EditControl/about1-src.tar.gz
>
> ftp://elipse.com.br/pub/EditControl/about1-exe.tar.gz
>
> Yeah, I stole the example from Petzold's book....so please enter 
>
> help->about to see the dialog :)
> Can anyone help with this? Is this a known wine bug?
>
> I did the usual google search but couldn't fine any reference of 
>
> this.
> But if is: Is somebody working on it?
>
> Or will anyone work on this? And can I help?
>
> Thanks for any help you can give me (please CC me).
>
> Felipe

Please start a bug for this in Bugzilla

http://bugs.winehq.org

It seems to me that I have seen this problem before but this is the 
first time I have seen a good test case for it.

[Felipe W Damasio]

Hi,

Tony Lambregts wrote:
> Please start a bug for this in Bugzilla
>
> http://bugs.winehq.org

Done.

It got assigned to [e-mail], though.

Is there someone who could work on this so I can assign this bug to him 
directly?

It seems a critical bug and I'm afraid that leaving assigned to a 
"generic" user (like wine-bugs) it'll get "lost" (or lose priority on 
everybody's TODO list).
> It seems to me that I have seen this problem before but this is the 
> first time I have seen a good test case for it.

So you could reproduce the bug?

Thanks,

Felipe

[Tony Lambregts]

Felipe W Damasio wrote:
> Hi,
>
> Tony Lambregts wrote:
> > Please start a bug for this in Bugzilla
> >
> > http://bugs.winehq.org
> Done.
>
> It got assigned to [e-mail], though.
>
> Is there someone who could work on this so I can assign this bug 
>
> to him directly?
> It seems a critical bug and I'm afraid that leaving assigned to a 
>
> "generic" user (like wine-bugs) it'll get "lost" (or lose priority on 
> everybody's TODO list).

Well it depends. Andriy Palamarchuk had put together of peoples 
specialties but I do not recall it ever getting a permanent home. Andriy 
are you still out there? Anyways since this is primarily a volunteer 
project and people come and go, so the list is out of date.

So the main thing is to get a good handle on the bug in the first place 
and maybe someone who has the ability can put together a patch. It could 
be me or you might fix it yourself. Simply assigning it to someone who 
may not have the time to do anything about it is not the solution.
> > It seems to me that I have seen this problem before but this is the 
> > first time I have seen a good test case for it.
> So you could reproduce the bug? 

Not personally but I have seen reports similar to this. I monitor 
bugzilla and try to keep it in shape. It's just that this seemed to be 
the best report of the problem and with source code too. Hell... you 
can't get much better than that.
> Thanks,

Your Welcome

[Sander van Leeuwen]

Felipe,

Does this patch help? (controls\edit.c)

@@ -1747,7 +1747,7 @@

alloc_size = ROUND_TO_GROW((size + 1) * sizeof(WCHAR));
    if ((es->undo_text = HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, es->undo_text, alloc_size))) {
-		es->undo_buffer_size = alloc_size/sizeof(WCHAR);
+		es->undo_buffer_size = alloc_size/sizeof(WCHAR) - 1;
    	return TRUE;
    }
    else

This fixed heap corruption here for similar actions.

Sander

On Thu, 06 Feb 2003 15:13:33 -0200, Felipe W Damasio wrote:
> Hi,
>
> I'm porting a software using winelib and found a (at least I think so) 
> serious bug with the edit control: When you put a lot of text in an 
> edit control and then begins to backspace them, the app simply seg faults.
>
> I'm using wine-20030115 but also tried wine-20021031, and both have 
> this bug.
>
> Both the source and the executable for test are available here:
>
> ftp://elipse.com.br/pub/EditControl/about1-src.tar.gz
>
> ftp://elipse.com.br/pub/EditControl/about1-exe.tar.gz
>
> Yeah, I stole the example from Petzold's book....so please enter 
> help->about to see the dialog :)
>
> Can anyone help with this? Is this a known wine bug?
>
> I did the usual google search but couldn't fine any reference of this.
>
> But if is: Is somebody working on it?
>
> Or will anyone work on this? And can I help?
>
> Thanks for any help you can give me (please CC me).
>
> Felipe

[Felipe W Damasio]

Hi,

Sander van Leeuwen wrote:
> Felipe,
>
> Does this patch help? (controls\edit.c)
>
> @@ -1747,7 +1747,7 @@
>
> alloc_size = ROUND_TO_GROW((size + 1) * sizeof(WCHAR));
>    if ((es->undo_text = HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, es->undo_text, alloc_size))) {
> -
> es->undo_buffer_size = alloc_size/sizeof(WCHAR);
> -
> es->undo_buffer_size = alloc_size/sizeof(WCHAR) - 1;
> return TRUE;
> }
> else
>
> This fixed heap corruption here for similar actions.

Yes, that fixes the problem.

Thanks!

Felipe