Re: [winedbg] Get expressions working again.

[Pouech Eric DMI AEI CAEN]

I don't think this patch should go in as it is:
- I don't think it's a good idea to have two ways to express a pointer type in the debugger (one being the standard dbghelp's SymTagPointerType, the other one the new deref count you've introduced). It would be better to add dynamic winedbg types (in the contrary to the static one's we already use dbg_itype_*), when we cannot find one in a module.
- the returned string (for internal types' name) should be HeapAllocate:d, not a static buffer
- please, use the current style for parenthesis, braces... and don't add a new one

A+
> Message du 01/03/05 18:28
> De : "Oliver Stieber" 
> A : [e-mail]
> Copie à : 
> Objet : [winedbg] Get expressions working again.
>
> Hi,
> This patch starts to get expressions working again and
> also allows derefrencing where there is no explicit
> type for that dereference. e.g.
>
> (short)0x12356 now returns the correct value instead
> of an error
>
> *((int *)0x23467) is now a valid expression.
> and 
> ***((int ***)0x23467) should also work properly.
>
> This should also fix watches with expressions but I
> haven't given it much testing.
>
> Send instant messages to your online friends http://uk.messenger.yahoo.com >
> [ winedbg_expressions_os_1.patch (18.4 Ko) ]

[winedbg] Get expressions working again.

[Oliver Stieber]

--- Pouech Eric DMI AEI CAEN 
wrote:
> I don't think this patch should go in as it is:
> - I don't think it's a good idea to have two ways to
>
> express a pointer type in the debugger (one being
> the standard dbghelp's SymTagPointerType, the other
> one the new deref count you've introduced). It would
> be better to add dynamic winedbg types (in the
> contrary to the static one's we already use
> dbg_itype_*), when we cannot find one in a module.

Ok, I don't think I'll do this I don't have time to
fix types_find_pointer and everywhere else to support
module=0 properly.
> - the returned string (for internal types' name)
>
> should be HeapAllocate:d, not a static buffer
> - please, use the current style for parenthesis,
>
> braces... and don't add a new one

Ok, I'll take a look at this, but if where shouldn't
be using two pointer types we should be using
SymGetTypeInfo in all cases?
> A+

Send instant messages to your online friends http://uk.messenger.yahoo.com