Re: [7/7] Add ID3D10Device interface and implement it's IUnknown methods

[H. Verbeet]

On 13/06/07, Kovács András  wrote:
> - TRACE("Adapter %p, Driver Type %d, Software Module handle %p, Flags %08x, SDKVersion %d, Device %p\n",
> -
>      Adapter, DriverType, Software, Flags, SDKVersion, Device);

I think the DriverType should be traces as string there (ie, using
something like the debug_d3d*() functions in dlls/wined3d/utils.c).
Also, please prefix hexadecimal numbers with 0x. d3d8 and d3d9 are
pretty bad wrt producing readable traces, but we might as well do it
right when writing a new dll.
> - FIXME("ID3D10Device interface is not binary compatible to windows yet\n");

Actually, a void * is binary compatible with IDGXIAdapter *

I suppose it's a matter of taste, but personally I think more C like
naming (ie, lower case, _ separated) for the parameter names would be
easier on the eyes :-) (and you do use those for the ID3D10DeviceImpl
functions).

Chris already mentioned the initial refcount on IRC.

[7/7] Add ID3D10Device interface and implement it's IUnknown methods

[Stefan Dösinger]

> > - FIXME("ID3D10Device interface is not binary compatible to windows
> >
> > yet\n");
>
> Actually, a void * is binary compatible with IDGXIAdapter *

But the IDirect3D10Device interface isn't yet, thats why I suggested such a 
fixme for the start.

[7/7] Add ID3D10Device interface and implement it's IUnknown methods

[H. Verbeet]

On 13/06/07, Stefan Dösinger  wrote:
> > > - FIXME("ID3D10Device interface is not binary compatible to windows
> > >
> > > yet\n");
> >
> > Actually, a void * is binary compatible with IDGXIAdapter *
>
> But the IDirect3D10Device interface isn't yet, thats why I suggested such a
> fixme for the start.

Right, nevermind :-)