Re: comdlg32: Delay setting the initial size of resizable file dialog until the CDN_INITDONE notification has been processed.

[Paul Vriens]

Rein Klazes wrote:
> With tests. Fixes bug #18516
>
> dlls/comdlg32/filedlg.c       |    6 +-
>  dlls/comdlg32/tests/filedlg.c |  126 +++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 130 insertions(+), 2 deletions(-)

Hi Rein,

This is introducing test failures on at least NT4. (Just as I was down 
to zero :( ).

Could you have a look?

comdlg32: Delay setting the initial size of resizable file dialog until the CDN_INITDONE notification has been processed.

[André Hentschel]

Paul Vriens schrieb:
> Rein Klazes wrote:
> > With tests. Fixes bug #18516
> >
> > dlls/comdlg32/filedlg.c       |    6 +-
> >  dlls/comdlg32/tests/filedlg.c |  126 
> > +++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 130 insertions(+), 2 deletions(-)
>
> Hi Rein,
>
> This is introducing test failures on at least NT4. (Just as I was down 
> to zero :( ).

On W2k, too.
This would have been the first green/yellow NT4 entry :(
duh

comdlg32: Delay setting the initial size of resizable file dialog until the CDN_INITDONE notification has been processed.

[Paul Vriens]

André Hentschel wrote:
> Paul Vriens schrieb:
> > Rein Klazes wrote:
> > > With tests. Fixes bug #18516
> > >
> > > dlls/comdlg32/filedlg.c       |    6 +-
> > >  dlls/comdlg32/tests/filedlg.c |  126 
> > > +++++++++++++++++++++++++++++++++++++++++
> > >  2 files changed, 130 insertions(+), 2 deletions(-)
> >
> > Hi Rein,
> >
> > This is introducing test failures on at least NT4. (Just as I was down 
> > to zero :( ).
>
> On W2k, too.
> This would have been the first green/yellow NT4 entry :(
> duh

Yeah, we have errors on several platforms:

http://test.winehq.org/data/tests/comdlg32:filedlg.html

MSDN tells us that OFN_ENABLESIZING is not available on Win95 and NT4, 
no guarantee that this is correct of course, but maybe a hint.

comdlg32: Delay setting the initial size of resizable file dialog until the CDN_INITDONE notification has been processed.

[Paul Vriens]

Paul Vriens wrote:
> André Hentschel wrote:
> > Paul Vriens schrieb:
> > > Rein Klazes wrote:
> > > > With tests. Fixes bug #18516
> > > >
> > > > dlls/comdlg32/filedlg.c       |    6 +-
> > > >  dlls/comdlg32/tests/filedlg.c |  126 
> > > > +++++++++++++++++++++++++++++++++++++++++
> > > >  2 files changed, 130 insertions(+), 2 deletions(-)
> > >
> > > Hi Rein,
> > >
> > > This is introducing test failures on at least NT4. (Just as I was 
> > > down to zero :( ).
> >
> > On W2k, too.
> > This would have been the first green/yellow NT4 entry :(
> > duh
>
> Yeah, we have errors on several platforms:
>
> http://test.winehq.org/data/tests/comdlg32:filedlg.html
>
> MSDN tells us that OFN_ENABLESIZING is not available on Win95 and NT4, 
> no guarantee that this is correct of course, but maybe a hint.

And I just found out that when I put my VMware to fullscreen the sizing 
errors go away on Win98 and W2K3. Is there a way to restrict the size of 
this dialog on creation?

So:

1. Some (all?) resizing stuff is not supported on Win95/NT4
2. The size of the desktop matters for the sizing results.

comdlg32: Delay setting the initial size of resizable file dialog until the CDN_INITDONE notification has been processed.

[Rein Klazes]

On Tue, 16 Jun 2009 17:49:31 +0200, you wrote:
> So:
> - Some (all?) resizing stuff is not supported on Win95/NT4

Agreed. I can reproduce and I will fix it.
> - The size of the desktop matters for the sizing results.

Indeed, I did test this on win2k, win2k3 and winXP, all tests succeeded.
Making the desktop very small makes them fail.

I will fix.

Thanks for the investigation.

Rein.