Re: [1/2] qcap: Distinguish interface and implementation pointer for VfwCapture output pin.

[Michael Stefaniuc]

On 06/29/2015 08:08 AM, Sebastian Lackner wrote:
> --- dlls/qcap/vfwcapture.c |   42
> ++++++++++++++++++++++++++---------------- 1 file changed, 26
> insertions(+), 16 deletions(-)
>
> diff --git a/dlls/qcap/vfwcapture.c b/dlls/qcap/vfwcapture.c index
> 7804a3d..31620c0 100644 --- a/dlls/qcap/vfwcapture.c +++
> b/dlls/qcap/vfwcapture.c @@ -557,7 +567,7 @@ PPB_Load(
> IPersistPropertyBag * iface, IPropertyBag *pPropBag, 
> var.__VARIANT_NAME_1.__VARIANT_NAME_2.__VARIANT_NAME_3.ulVal ); if
> (This->driver_info) { -            pin = (VfwPinImpl
> *)This->pOutputPin; +            pin =
> impl_from_IPin(This->pOutputPin);

impl_from_IFoo() is just for the interface pointer of a method.
For internal stuff the object pointer should be passed or stored instead.
For application provided interface pointers an unsafe_impl_from_IFoo()
should be used.

bye
    michael