Is it possible to add a test to show that Wine crashes?
On 8/1/2011 14:04, Vitaly Perov wrote:
Is it possible to add a test to show that Wine crashes?
You mean inside exception handler? Test that crashes comes with or after a fix that fix a crash.
On Mon, 01 Aug 2011 14:11:31 +0400, Nikolay Sivov wrote:
On 8/1/2011 14:04, Vitaly Perov wrote:
Is it possible to add a test to show that Wine crashes?
You mean inside exception handler? Test that crashes comes with or after a fix that fix a crash.
Yes, I have sent a patch that fix a crash. The status of my patch is "need tests". I want to add a test to show that Wine really crashes, and the patch really fix the crash.
On 8/1/2011 14:31, Vitaly Perov wrote:
On Mon, 01 Aug 2011 14:11:31 +0400, Nikolay Sivov wrote:
On 8/1/2011 14:04, Vitaly Perov wrote:
Is it possible to add a test to show that Wine crashes?
You mean inside exception handler? Test that crashes comes with or after a fix that fix a crash.
Yes, I have sent a patch that fix a crash. The status of my patch is "need tests". I want to add a test to show that Wine really crashes, and the patch really fix the crash.
Send fix with a test as a single path, if a change is trivial and test bot doesn't crash on new test then it's enough.
Vitaly Perov vitperov@etersoft.ru writes:
On Mon, 01 Aug 2011 14:11:31 +0400, Nikolay Sivov wrote:
On 8/1/2011 14:04, Vitaly Perov wrote:
Is it possible to add a test to show that Wine crashes?
You mean inside exception handler? Test that crashes comes with or after a fix that fix a crash.
Yes, I have sent a patch that fix a crash. The status of my patch is "need tests". I want to add a test to show that Wine really crashes, and the patch really fix the crash.
You should not be trying to write a test that proves that Wine crashes, that's not interesting. What you should do is demonstrate Windows behavior for various types of invalid input, and then make Wine conform to that.
On Mon, 01 Aug 2011 12:45:12 +0200, Alexandre Julliard wrote:
You should not be trying to write a test that proves that Wine crashes, that's not interesting. What you should do is demonstrate Windows behavior for various types of invalid input, and then make Wine conform to that.
As I understood, I should send a fix and tests (which crash without the fix) in one patch, shouldn't I? And couple of tests should cover all possible variants of invalid input.
Then, my second qustion is: I need a big-size pictures (jpg, png, gif, bmp) for my tests. I think I am unable to generate them in the test. Is it normal to add them as files?
Vitaly Perov vitperov@etersoft.ru writes:
Then, my second qustion is: I need a big-size pictures (jpg, png, gif, bmp) for my tests. I think I am unable to generate them in the test. Is it normal to add them as files?
You should generate fake files, it's not hard.
On Mon, 01 Aug 2011 14:05:29 +0200, Alexandre Julliard wrote:
Vitaly Perov vitperov@etersoft.ru writes:
Then, my second qustion is: I need a big-size pictures (jpg, png, gif, bmp) for my tests. I think I am unable to generate them in the test. Is it normal to add them as files?
You should generate fake files, it's not hard.
Ok. Thank you for your help!
-
Alexandre Julliard -
Nikolay Sivov -
Vitaly Perov