On 08.07.2016 10:20, Hans Leidekker wrote:
v2: Fix build failure.
Signed-off-by: Hans Leidekker hans@codeweavers.com
dlls/webservices/reader.c | 8 +-- dlls/webservices/tests/writer.c | 113 +++++++++++++++++++++++++++++++++ dlls/webservices/webservices_private.h | 2 + dlls/webservices/writer.c | 100 +++++++++++++++++++++++++++++ include/webservices.h | 5 ++ 5 files changed, 224 insertions(+), 4 deletions(-)
Unfortunately your patch does not work as expected here (gcc 5.3):
../../../tools/runtest -q -P wine -T ../../.. -M webservices.dll -p webservices_test.exe.so writer && touch writer.ok writer.c:358: Test failed: 1941: got 11 expected 10 writer.c:360: Test failed: 1941: got <t>:E-3</t>>000000004</t> expected <t>1E-2</t> writer.c:358: Test failed: 1941: got 12 expected 11 writer.c:360: Test failed: 1941: got <t>-:E-3</t>000000004</t> expected <t>-1E-2</t> Makefile:346: die Regel für Ziel „writer.ok“ scheiterte
If you need any details to investigate this issue please let me know.
Regards, Sebastian
On Sun, 2016-07-10 at 03:28 +0200, Sebastian Lackner wrote:
Unfortunately your patch does not work as expected here (gcc 5.3):
../../../tools/runtest -q -P wine -T ../../.. -M webservices.dll -p webservices_test.exe.so writer && touch writer.ok writer.c:358: Test failed: 1941: got 11 expected 10 writer.c:360: Test failed: 1941: got <t>:E-3</t>>000000004</t> expected <t>1E-2</t> writer.c:358: Test failed: 1941: got 12 expected 11 writer.c:360: Test failed: 1941: got <t>-:E-3</t>000000004</t> expected <t>-1E-2</t> Makefile:346: die Regel für Ziel „writer.ok“ scheiterte
If you need any details to investigate this issue please let me know.
Does this patch help? Note that it needs autoconf && autoheader.
On 10.07.2016 20:30, Hans Leidekker wrote:
On Sun, 2016-07-10 at 03:28 +0200, Sebastian Lackner wrote:
Unfortunately your patch does not work as expected here (gcc 5.3):
../../../tools/runtest -q -P wine -T ../../.. -M webservices.dll -p webservices_test.exe.so writer && touch writer.ok writer.c:358: Test failed: 1941: got 11 expected 10 writer.c:360: Test failed: 1941: got <t>:E-3</t>>000000004</t> expected <t>1E-2</t> writer.c:358: Test failed: 1941: got 12 expected 11 writer.c:360: Test failed: 1941: got <t>-:E-3</t>000000004</t> expected <t>-1E-2</t> Makefile:346: die Regel für Ziel „writer.ok“ scheiterte
If you need any details to investigate this issue please let me know.
Does this patch help? Note that it needs autoconf && autoheader.
Thanks. Yes, your proposed patch fixes the test failures.
At first powl() wasn't detected, but then I remembered that this is a well-known bug when compiling with -Werror:
conftest.c:370:6: warning: conflicting types for built-in function 'powl'
Nevertheless, this also affects some other functions, so it probably should be fixed independently (if we care about it).
Best regards, Sebastian
-
Hans Leidekker -
Sebastian Lackner