I am looking at the pages on winehq for development for wine. I am noticing that everything is talking about guidelines for making patches and submitting patches. Can I not make a pull request on my changes? I also noticed that it said that not everyone can submit patches and i inferred by the linked pages that it's to prevent legal trouble. How can I become eligible to submit changes?
Can I not make a pull request on my changes?
No.
I also noticed that it said that not everyone can submit patches and i inferred by the linked pages that it's to prevent legal trouble. How can I become eligible to submit changes?
There are certain rules to that, wiki probably has that information already. For example your patches will be rejected automatically if you had/have access to MS source code, doesn't matter if it's available for general public or not. Also you can't use implementation details information extracted using Wine's tracing. You can't disassemble native modules of course. Maybe there's more but these are the most important.
On 07/29/2014 11:31 PM, Nikolay Sivov wrote:
Can I not make a pull request on my changes?
No.
I also noticed that it said that not everyone can submit patches and i inferred by the linked pages that it's to prevent legal trouble. How can I become eligible to submit changes?
There are certain rules to that, wiki probably has that information already. For example your patches will be rejected automatically if you had/have access to MS source code, doesn't matter if it's available for general public or not. Also you can't use implementation details information extracted using Wine's tracing. You can't disassemble native modules of course. Maybe there's more but these are the most important.
I've read these rules. Is this it? I haven't had access to Microsoft source code nor do I plan to use wine's tracking or plan to disassemble anything; It's pretty much legal common sense to avoid that. So, I am pretty much eligible to submit changes?
On 07/30/2014 05:44 AM, Kyle Marek wrote:
On 07/29/2014 11:31 PM, Nikolay Sivov wrote:
Can I not make a pull request on my changes?
No.
I also noticed that it said that not everyone can submit patches and i inferred by the linked pages that it's to prevent legal trouble. How can I become eligible to submit changes?
There are certain rules to that, wiki probably has that information already. For example your patches will be rejected automatically if you had/have access to MS source code, doesn't matter if it's available for general public or not. Also you can't use implementation details information extracted using Wine's tracing. You can't disassemble native modules of course. Maybe there's more but these are the most important.
I've read these rules. Is this it? I haven't had access to Microsoft source code nor do I plan to use wine's tracking or plan to disassemble anything; It's pretty much legal common sense to avoid that. So, I am pretty much eligible to submit changes?
Then you should be fine.
bye michael
-
Kyle Marek -
Michael Stefaniuc -
Nikolay Sivov