Re: [PATCH] Version info for comctl32.dll

[Dmitry Timoshkov]

"gerard patel"  wrote:
> ChangeLog:
> - dlls/comctl32/rsrc.rc
>                  Add version info.

[...]
> LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL
> -
>
> +1 VERSIONINFO
> +FILEVERSION 4, 72, 0, 0
> +PRODUCTVERSION 4, 72, 0, 0
> +FILEFLAGSMASK VS_FFI_FILEFLAGSMASK
> +FILEOS VOS_DOS_WINDOWS16

[...]
> - VALUE "FileVersion", "0.01\000"

[...]
> - VALUE "ProductVersion", "1.00\000"

I thought that include/wine/wine_common_ver.rc will serve as the quite reasonable
defaults for all built-in Wine dlls. If not, it should be changed for ALL dlls
in ONE place.

Besides that:
1. I believe that version numbers should be equal in both numerical field and
in the string value (0.01 != 4.72 and 1.00 != 4.72).
2. There is no need for excessive \000 at the end of the string value.
3. All well behaving programs do read "VarFileInfo"/"Translation" before
retrieving other version information. LANGUAGE does nothing here.
4. Did you try to use my sample application showing version info?
5. Version resources in kernel, user, gdi for both 16 and 32-bit dlls could serve
as an example of adding version resources into built-in dlls.