On Wed, 2005-05-18 at 08:01 -0400, Dimi Paun wrote:
- struct list *cursor;
- LIST_FOR_EACH( cursor, &global_gadgets )
- LIST_FOR_EACH_ENTRY( cursor, &global_gadgets, struct gadget *,
gadget )
- {
Looking at this, why do we need cursor at all for the LIST_FOR_EACH_ENTRY? Also the type and iteration var should come first, to be simiar for loops in pretty much any language out there. I think it should just be: LIST_FOR_EACH_ENTRY( struct gadget *, gadget, &global_gadgets )
Ah, I see now the problem. We would need to end it with LIST_END instead of just doing {...}. Not such a big deal, we do the same for server requests too :)
But I can see why we would like to keep cursor. If so, it should come at the end: LIST_FOR_EACH_ENTRY(struct gadget *,gadget,&global_gadgets,cursor)