Help for my first patch

[Michael Bonfils]

Hi,

I'm using Wine with xUbuntu and you may be know, the menu and toolbar of 
xfce are  often visible. So I've looked at xfce forum and saw that wine 
doesn't inform xfce that window is fullscreen...

At http://standards.freedesktop.org/wm-spec/wm-spec-latest.html, I've 
found a _NET_WM_STATE_FULLSCREEN flag.

After digging in wine source, I've found in dlls/winex11.drv/window.c 
the function create_whole_window (I think that this function is called 
when a game want a resolution which isn't supported by X, wine used this 
function to fake fullscreen ?, correct me I'm wrong)

If in set_wm_hints, I force the window_type to _NET_WM_STATE_FULLSCREEN, 
toolbar and menu of xfce disappears. (tested with Wizardry 8)

My problem is how detect in this function that I came from 
create_whole_window and not from others functions ?

Do I have to test size of window to current resolution and use this flag ?
Or call XChangeProperty in create_whole_window ?

Thanks in advance,
Michael

[Roderick Colenbrander]

Hi,

Sorry to disappoint you but I have a feeling that this is most likely a bug in Xfce instead of Wine. Our window management code might use some legacy mechanisms here and there but it works on all window managers (except for this Xfce issue). A few years ago we had similar issues with Metacity and they fixed it in there. I think you can find info about it in the wine-devel archives.

I don't know all the tech details of winex11.drv. Likely someone more qualified like Alexandre can tell you more.

Regards,
Roderick
> Hi,
>
> I'm using Wine with xUbuntu and you may be know, the menu and toolbar of 
> xfce are  often visible. So I've looked at xfce forum and saw that wine 
> doesn't inform xfce that window is fullscreen...
>
> At http://standards.freedesktop.org/wm-spec/wm-spec-latest.html, I've 
> found a _NET_WM_STATE_FULLSCREEN flag.
>
> After digging in wine source, I've found in dlls/winex11.drv/window.c 
> the function create_whole_window (I think that this function is called 
> when a game want a resolution which isn't supported by X, wine used this 
> function to fake fullscreen ?, correct me I'm wrong)
>
> If in set_wm_hints, I force the window_type to _NET_WM_STATE_FULLSCREEN, 
> toolbar and menu of xfce disappears. (tested with Wizardry 8)
>
> My problem is how detect in this function that I came from 
> create_whole_window and not from others functions ?
>
> Do I have to test size of window to current resolution and use this flag ?
> Or call XChangeProperty in create_whole_window ?
>
> Thanks in advance,
> Michael