Re: [PATCH] hlink/tests: Repair test to work as intended

[Paul Vriens]

On 12/29/2009 12:40 AM, Andrew Eikum wrote:
> Paul Vriens 'fixed' this test to ensure that two strings are not the
> same. Instead, the test should test that two strings _are_ the same,
> but I accidentally compared the wrong strings in the original version.
>
> dlls/hlink/tests/browse_ctx.c | 19 +++++++++++--------
> 1 files changed, 11 insertions(+), 8 deletions(-)

Hi Andrew,

Sorry about that. Thanks for really fixing it this time.

[PATCH] hlink/tests: Repair test to work as intended

[Andrew Eikum]

On 12/31/2009 06:42 AM, Paul Vriens wrote:
> On 12/29/2009 12:40 AM, Andrew Eikum wrote:
> > Paul Vriens 'fixed' this test to ensure that two strings are not the
> > same. Instead, the test should test that two strings _are_ the same,
> > but I accidentally compared the wrong strings in the original version.
> >
> > dlls/hlink/tests/browse_ctx.c | 19 +++++++++++--------
> > 1 files changed, 11 insertions(+), 8 deletions(-)
>
> Hi Andrew,
>
> Sorry about that. Thanks for really fixing it this time.

Not at all, it was my fault it was broken in the first place.  I 
wouldn't have noticed if you hadn't pointed it out.

Andrew