Re: [3/8] scrrun: Add IFileSystem3 support

[Jacek Caban]

Hi Alistair,

On 03/27/12 11:41, Alistair Leslie-Hughes wrote:
> +typedef struct FileSystem
> +{
> - IFileSystem3 IFileSystem3_iface;
> - LONG ref;
>
> +} FileSystem;
> -
>
> +static inline FileSystem *impl_from_IFileSystem3( IFileSystem3 *iface )
> +{
> - return CONTAINING_RECORD(iface, FileSystem, IFileSystem3_iface);
>
> +}

Is there any reason for this to be heap-based object? It looks to me like it would better be a static object (AFAICS you don't even need FileSystem struct since you're not going to store anything in it).

Cheers,
Jacek

[3/8] scrrun: Add IFileSystem3 support

[Alistair Leslie-Hughes]

Hi Jacek,
> Is there any reason for this to be heap-based object? It looks to me like 
> it would better be a static object (AFAICS you don't even need FileSystem 
> struct since you're not going to store anything in it).

No,  Just habit to create them like this.

Best Regards
 Alistair Leslie-Hughes