In the unlikely event that we are hotplugging not from an IAsyncReader, we already have the ACM wrapper and l3codeca.acm available to do the same thing.
Signed-off-by: Zebediah Figura z.figura12@gmail.com --- dlls/winegstreamer/Makefile.in | 4 +- dlls/winegstreamer/gst_cbs.c | 24 -- dlls/winegstreamer/gst_cbs.h | 13 - dlls/winegstreamer/gst_guids.h | 1 - dlls/winegstreamer/gst_private.h | 7 - dlls/winegstreamer/gstdemux.c | 14 +- dlls/winegstreamer/gsttffilter.c | 628 ------------------------------- dlls/winegstreamer/main.c | 35 -- 8 files changed, 2 insertions(+), 724 deletions(-) delete mode 100644 dlls/winegstreamer/gsttffilter.c
diff --git a/dlls/winegstreamer/Makefile.in b/dlls/winegstreamer/Makefile.in index 08adb2b6d5d..c536f2521c0 100644 --- a/dlls/winegstreamer/Makefile.in +++ b/dlls/winegstreamer/Makefile.in @@ -10,14 +10,12 @@ C_SRCS = \ filter.c \ gst_cbs.c \ gstdemux.c \ - gsttffilter.c \ main.c \ mediatype.c \ mfplat.c \ pin.c \ qualitycontrol.c \ - seeking.c \ - transform.c + seeking.c
IDL_SRCS = mfplat.idl
diff --git a/dlls/winegstreamer/gst_cbs.c b/dlls/winegstreamer/gst_cbs.c index c8ba812c8a7..e7a4b41d55f 100644 --- a/dlls/winegstreamer/gst_cbs.c +++ b/dlls/winegstreamer/gst_cbs.c @@ -188,19 +188,6 @@ GstFlowReturn got_data_sink_wrapper(GstPad *pad, GstObject *parent, GstBuffer *b return cbdata.u.got_data_sink_data.ret; }
-GstFlowReturn got_data_wrapper(GstPad *pad, GstObject *parent, GstBuffer *buf) -{ - struct cb_data cbdata = { GOT_DATA }; - - cbdata.u.got_data_data.pad = pad; - cbdata.u.got_data_data.parent = parent; - cbdata.u.got_data_data.buf = buf; - - call_cb(&cbdata); - - return cbdata.u.got_data_data.ret; -} - void removed_decoded_pad_wrapper(GstElement *bin, GstPad *pad, gpointer user) { struct cb_data cbdata = { REMOVED_DECODED_PAD }; @@ -249,17 +236,6 @@ void release_sample_wrapper(gpointer data) call_cb(&cbdata); }
-void Gstreamer_transform_pad_added_wrapper(GstElement *filter, GstPad *pad, gpointer user) -{ - struct cb_data cbdata = { TRANSFORM_PAD_ADDED }; - - cbdata.u.transform_pad_added_data.filter = filter; - cbdata.u.transform_pad_added_data.pad = pad; - cbdata.u.transform_pad_added_data.user = user; - - call_cb(&cbdata); -} - gboolean query_sink_wrapper(GstPad *pad, GstObject *parent, GstQuery *query) { struct cb_data cbdata = { QUERY_SINK }; diff --git a/dlls/winegstreamer/gst_cbs.h b/dlls/winegstreamer/gst_cbs.h index 100a8dece44..46f8add57c4 100644 --- a/dlls/winegstreamer/gst_cbs.h +++ b/dlls/winegstreamer/gst_cbs.h @@ -39,12 +39,10 @@ enum CB_TYPE { EVENT_SRC, EVENT_SINK, GOT_DATA_SINK, - GOT_DATA, REMOVED_DECODED_PAD, AUTOPLUG_BLACKLIST, UNKNOWN_TYPE, RELEASE_SAMPLE, - TRANSFORM_PAD_ADDED, QUERY_SINK };
@@ -105,12 +103,6 @@ struct cb_data { GstBuffer *buf; GstFlowReturn ret; } got_data_sink_data; - struct got_data_data { - GstPad *pad; - GstObject *parent; - GstBuffer *buf; - GstFlowReturn ret; - } got_data_data; struct removed_decoded_pad_data { GstElement *bin; GstPad *pad; @@ -133,11 +125,6 @@ struct cb_data { struct release_sample_data { gpointer data; } release_sample_data; - struct transform_pad_added_data { - GstElement *filter; - GstPad *pad; - gpointer user; - } transform_pad_added_data; struct query_sink_data { GstPad *pad; GstObject *parent; diff --git a/dlls/winegstreamer/gst_guids.h b/dlls/winegstreamer/gst_guids.h index e50ecb48519..b5ed3139b60 100644 --- a/dlls/winegstreamer/gst_guids.h +++ b/dlls/winegstreamer/gst_guids.h @@ -19,6 +19,5 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */
-DEFINE_GUID(CLSID_Gstreamer_Mp3, 0x728dcf55, 0x128f, 0x4dd1, 0xad, 0x22, 0xbe, 0xcf, 0xa6, 0x6c, 0xe7, 0xaa); DEFINE_GUID(CLSID_Gstreamer_Splitter, 0xf9d8d64e, 0xa144, 0x47dc, 0x8e, 0xe0, 0xf5, 0x34, 0x98, 0x37, 0x2c, 0x29); DEFINE_GUID(WINESUBTYPE_Gstreamer, 0xffffffff, 0x128f, 0x4dd1, 0xad, 0x22, 0xbe, 0xcf, 0xa6, 0x6c, 0xe7, 0xaa); diff --git a/dlls/winegstreamer/gst_private.h b/dlls/winegstreamer/gst_private.h index 7108a32e401..353ff0bbd5b 100644 --- a/dlls/winegstreamer/gst_private.h +++ b/dlls/winegstreamer/gst_private.h @@ -37,20 +37,13 @@
IUnknown * CALLBACK avi_splitter_create(IUnknown *outer, HRESULT *phr) DECLSPEC_HIDDEN; IUnknown * CALLBACK mpeg_splitter_create(IUnknown *outer, HRESULT *phr) DECLSPEC_HIDDEN; -IUnknown * CALLBACK Gstreamer_Mp3_create(IUnknown *pUnkOuter, HRESULT *phr); IUnknown * CALLBACK Gstreamer_Splitter_create(IUnknown *pUnkOuter, HRESULT *phr); IUnknown * CALLBACK wave_parser_create(IUnknown *outer, HRESULT *phr) DECLSPEC_HIDDEN;
BOOL init_gstreamer(void) DECLSPEC_HIDDEN;
-GstFlowReturn got_data(GstPad *pad, GstObject *parent, GstBuffer *buf) DECLSPEC_HIDDEN; -GstFlowReturn request_buffer(GstPad *pad, guint64 ofs, guint size, GstCaps *caps, GstBuffer **buf) DECLSPEC_HIDDEN; -void Gstreamer_transform_pad_added(GstElement *filter, GstPad *pad, gpointer user) DECLSPEC_HIDDEN; - void start_dispatch_thread(void) DECLSPEC_HIDDEN;
-extern const char *media_quark_string DECLSPEC_HIDDEN; - extern HRESULT mfplat_get_class_object(REFCLSID rclsid, REFIID riid, void **obj) DECLSPEC_HIDDEN; extern HRESULT mfplat_can_unload_now(void) DECLSPEC_HIDDEN;
diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index f9eed906b6e..0b5fee30273 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -97,7 +97,7 @@ static inline struct gstdemux *impl_from_strmbase_filter(struct strmbase_filter return CONTAINING_RECORD(iface, struct gstdemux, filter); }
-const char* media_quark_string = "media-sample"; +static const char *media_quark_string = "media-sample";
static const WCHAR wcsInputPinName[] = {'i','n','p','u','t',' ','p','i','n',0}; static const IMediaSeekingVtbl GST_Seeking_Vtbl; @@ -2313,12 +2313,6 @@ void CALLBACK perform_cb(TP_CALLBACK_INSTANCE *instance, void *user) cbdata->u.got_data_sink_data.ret = got_data_sink(data->pad, data->parent, data->buf); break; } - case GOT_DATA: - { - struct got_data_data *data = &cbdata->u.got_data_data; - cbdata->u.got_data_data.ret = got_data(data->pad, data->parent, data->buf); - break; - } case REMOVED_DECODED_PAD: { struct removed_decoded_pad_data *data = &cbdata->u.removed_decoded_pad_data; @@ -2344,12 +2338,6 @@ void CALLBACK perform_cb(TP_CALLBACK_INSTANCE *instance, void *user) release_sample(data->data); break; } - case TRANSFORM_PAD_ADDED: - { - struct transform_pad_added_data *data = &cbdata->u.transform_pad_added_data; - Gstreamer_transform_pad_added(data->filter, data->pad, data->user); - break; - } case QUERY_SINK: { struct query_sink_data *data = &cbdata->u.query_sink_data; diff --git a/dlls/winegstreamer/gsttffilter.c b/dlls/winegstreamer/gsttffilter.c deleted file mode 100644 index 21feefe09d2..00000000000 --- a/dlls/winegstreamer/gsttffilter.c +++ /dev/null @@ -1,628 +0,0 @@ -/* - * GStreamer wrapper filter - * - * Copyright 2010 Maarten Lankhorst for CodeWeavers - * Copyright 2010 Aric Stewart for CodeWeavers - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA - * - */ - -#include "config.h" - -#include <gst/gst.h> -#include <gst/video/video.h> -#include <gst/audio/audio.h> - -#include "gst_private.h" -#include "gst_guids.h" -#include "gst_cbs.h" - -#include "uuids.h" -#include "mmreg.h" -#include "windef.h" -#include "winbase.h" -#include "dshow.h" -#include "strmif.h" -#include "vfwmsgs.h" -#include "dvdmedia.h" -#include "ks.h" -#include "ksmedia.h" -#include "msacm.h" - -#include <assert.h> - -#include "wine/unicode.h" -#include "wine/debug.h" - -#include "initguid.h" -DEFINE_GUID(WMMEDIASUBTYPE_MP3, 0x00000055, 0x0000, 0x0010, 0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71); - -WINE_DEFAULT_DEBUG_CHANNEL(gstreamer); - -struct typeinfo { - GstCaps *caps; - const char *type; -}; - -static gboolean match_element(GstPluginFeature *feature, gpointer gdata) -{ - struct typeinfo *data = (struct typeinfo*)gdata; - GstElementFactory *factory; - const GList *list; - - if (!GST_IS_ELEMENT_FACTORY(feature)) - return FALSE; - factory = GST_ELEMENT_FACTORY(feature); - if (!strstr(gst_element_factory_get_klass(factory), data->type)) - return FALSE; - for (list = gst_element_factory_get_static_pad_templates(factory); list; list = list->next) { - GstStaticPadTemplate *pad = (GstStaticPadTemplate*)list->data; - GstCaps *caps; - gboolean ret; - if (pad->direction != GST_PAD_SINK) - continue; - caps = gst_static_caps_get(&pad->static_caps); - ret = gst_caps_is_always_compatible(caps, data->caps); - gst_caps_unref(caps); - if (ret) - return TRUE; - } - return FALSE; -} - -static const char *Gstreamer_FindMatch(const char *strcaps) -{ - struct typeinfo data; - GList *list, *copy; - guint bestrank = 0; - GstElementFactory *bestfactory = NULL; - GstCaps *caps = gst_caps_from_string(strcaps); - - TRACE("%s\n", strcaps); - - data.caps = caps; - data.type = "Decoder"; - copy = gst_registry_feature_filter(gst_registry_get(), match_element, 0, &data); - for (list = copy; list; list = list->next) { - GstElementFactory *factory = (GstElementFactory*)list->data; - guint rank; - rank = gst_plugin_feature_get_rank(GST_PLUGIN_FEATURE(factory)); - if (rank > bestrank || !bestrank) { - bestrank = rank; - bestfactory = factory; - } - } - gst_caps_unref(caps); - g_list_free(copy); - - if (!bestfactory) { - ERR("Could not find plugin for %s\n", strcaps); - return NULL; - } - return gst_plugin_feature_get_name(GST_PLUGIN_FEATURE(bestfactory)); -} - -typedef struct GstTfImpl { - TransformFilter tf; - const char *gstreamer_name; - GstElement *filter; - GstPad *my_src, *my_sink, *their_src, *their_sink; - LONG cbBuffer; -} GstTfImpl; - -static HRESULT WINAPI Gstreamer_transform_ProcessBegin(TransformFilter *iface) -{ - GstTfImpl *This = (GstTfImpl*)iface; - int ret; - - mark_wine_thread(); - - ret = gst_element_set_state(This->filter, GST_STATE_PLAYING); - TRACE("Returned: %i\n", ret); - return S_OK; -} - -static HRESULT WINAPI Gstreamer_transform_DecideBufferSize(TransformFilter *tf, IMemAllocator *pAlloc, ALLOCATOR_PROPERTIES *ppropInputRequest) -{ - GstTfImpl *This = (GstTfImpl*)tf; - ALLOCATOR_PROPERTIES actual; - - TRACE("%p, %p, %p\n", This, pAlloc, ppropInputRequest); - - if (!ppropInputRequest->cbAlign) - ppropInputRequest->cbAlign = 1; - - ppropInputRequest->cbBuffer = This->cbBuffer; - - if (ppropInputRequest->cBuffers < 2) - ppropInputRequest->cBuffers = 2; - - return IMemAllocator_SetProperties(pAlloc, ppropInputRequest, &actual); -} - -GstFlowReturn got_data(GstPad *pad, GstObject *parent, GstBuffer *buf) -{ - GstTfImpl *This = gst_pad_get_element_private(pad); - IMediaSample *sample = (IMediaSample *) gst_mini_object_get_qdata(GST_MINI_OBJECT(buf), g_quark_from_static_string(media_quark_string)); - REFERENCE_TIME tStart, tStop; - HRESULT hr; - - TRACE("%p, %p\n", pad, buf); - - if(!sample){ - GstMapInfo info; - BYTE *ptr; - - gst_buffer_map(buf, &info, GST_MAP_READ); - - hr = BaseOutputPinImpl_GetDeliveryBuffer(&This->tf.source, &sample, NULL, NULL, 0); - if (FAILED(hr)) { - ERR("Could not get output buffer: %08x\n", hr); - return GST_FLOW_FLUSHING; - } - - IMediaSample_SetActualDataLength(sample, info.size); - - IMediaSample_GetPointer(sample, &ptr); - - memcpy(ptr, info.data, info.size); - - gst_buffer_unmap(buf, &info); - } - - if (GST_BUFFER_PTS_IS_VALID(buf) && - GST_BUFFER_DURATION_IS_VALID(buf)) { - tStart = buf->pts / 100; - tStop = tStart + buf->duration / 100; - IMediaSample_SetTime(sample, &tStart, &tStop); - } - else - IMediaSample_SetTime(sample, NULL, NULL); - if (GST_BUFFER_OFFSET_IS_VALID(buf) && - GST_BUFFER_OFFSET_END_IS_VALID(buf)) { - tStart = buf->offset / 100; - tStop = buf->offset_end / 100; - IMediaSample_SetMediaTime(sample, &tStart, &tStop); - } - else - IMediaSample_SetMediaTime(sample, NULL, NULL); - - IMediaSample_SetDiscontinuity(sample, GST_BUFFER_FLAG_IS_SET(buf, GST_BUFFER_FLAG_DISCONT)); - IMediaSample_SetPreroll(sample, GST_BUFFER_FLAG_IS_SET(buf, GST_BUFFER_FLAG_LIVE)); - IMediaSample_SetSyncPoint(sample, !GST_BUFFER_FLAG_IS_SET(buf, GST_BUFFER_FLAG_DELTA_UNIT)); - IMediaSample_SetActualDataLength(sample, gst_buffer_get_size(buf)); - - hr = IMemInputPin_Receive(This->tf.source.pMemInputPin, sample); - IMediaSample_Release(sample); - gst_buffer_unref(buf); - if (FAILED(hr)) - return GST_FLOW_FLUSHING; - return GST_FLOW_OK; -} - -static HRESULT WINAPI Gstreamer_transform_ProcessData(TransformFilter *iface, IMediaSample *sample) -{ - GstTfImpl *This = (GstTfImpl*)iface; - REFERENCE_TIME tStart, tStop; - BYTE *data; - GstBuffer *buf; - HRESULT hr; - DWORD bufsize; - int ret; - - TRACE("%p, %p\n", This, sample); - - mark_wine_thread(); - - IMediaSample_GetPointer(sample, &data); - - IMediaSample_AddRef(sample); - bufsize = IMediaSample_GetActualDataLength(sample); - buf = gst_buffer_new_wrapped_full(0, data, bufsize, 0, bufsize, sample, release_sample_wrapper); - if (!buf) { - IMediaSample_Release(sample); - return S_OK; - } - - IMediaSample_AddRef(sample); - gst_mini_object_set_qdata(GST_MINI_OBJECT(buf), g_quark_from_static_string(media_quark_string), sample, release_sample_wrapper); - - buf->duration = buf->pts = -1; - hr = IMediaSample_GetTime(sample, &tStart, &tStop); - if (SUCCEEDED(hr)) { - buf->pts = tStart * 100; - if (hr == S_OK) - buf->duration = (tStop - tStart)*100; - } - if (IMediaSample_GetMediaTime(sample, &tStart, &tStop) == S_OK) { - buf->offset = tStart * 100; - buf->offset_end = tStop * 100; - } - if (IMediaSample_IsDiscontinuity(sample) == S_OK) - GST_BUFFER_FLAG_SET(buf, GST_BUFFER_FLAG_DISCONT); - if (IMediaSample_IsPreroll(sample) == S_OK) - GST_BUFFER_FLAG_SET(buf, GST_BUFFER_FLAG_LIVE); - if (IMediaSample_IsSyncPoint(sample) != S_OK) - GST_BUFFER_FLAG_SET(buf, GST_BUFFER_FLAG_DELTA_UNIT); - ret = gst_pad_push(This->my_src, buf); - if (ret) - WARN("Sending returned: %i\n", ret); - if (ret == GST_FLOW_FLUSHING) - return VFW_E_WRONG_STATE; - return S_OK; -} - -static HRESULT WINAPI Gstreamer_transform_ProcessEnd(TransformFilter *iface) -{ - GstTfImpl *This = (GstTfImpl*)iface; - int ret; - - mark_wine_thread(); - - ret = gst_element_set_state(This->filter, GST_STATE_READY); - TRACE("Returned: %i\n", ret); - return S_OK; -} - -void Gstreamer_transform_pad_added(GstElement *filter, GstPad *pad, gpointer user) -{ - GstTfImpl *This = (GstTfImpl*)user; - int ret; - - TRACE("%p %p %p\n", This, filter, pad); - - if (!GST_PAD_IS_SRC(pad)) - return; - - ret = gst_pad_link(pad, This->my_sink); - if (ret < 0) - WARN("Failed to link with %i\n", ret); - This->their_src = pad; -} - -static HRESULT Gstreamer_transform_ConnectInput(GstTfImpl *This, const AM_MEDIA_TYPE *amt, GstCaps *capsin, GstCaps *capsout) -{ - GstIterator *it; - BOOL done = FALSE, found = FALSE; - int ret; - - TRACE("%p %p %p %p\n", This, amt, capsin, capsout); - - mark_wine_thread(); - - This->filter = gst_element_factory_make(This->gstreamer_name, NULL); - if (!This->filter) { - ERR("Could not make %s filter\n", This->gstreamer_name); - return E_FAIL; - } - This->my_src = gst_pad_new("yuvsrc", GST_PAD_SRC); - gst_pad_set_element_private (This->my_src, This); - gst_pad_set_active(This->my_src, 1); - - This->my_sink = gst_pad_new("yuvsink", GST_PAD_SINK); - gst_pad_set_chain_function(This->my_sink, got_data_wrapper); - gst_pad_set_element_private (This->my_sink, This); - gst_pad_set_active(This->my_sink, 1); - - it = gst_element_iterate_sink_pads(This->filter); - while (!done) { - GValue item = {0}; - - switch (gst_iterator_next(it, &item)) { - case GST_ITERATOR_RESYNC: - gst_iterator_resync (it); - break; - case GST_ITERATOR_OK: - This->their_sink = g_value_get_object(&item); - gst_object_ref(This->their_sink); - g_value_reset(&item); - case GST_ITERATOR_ERROR: - case GST_ITERATOR_DONE: - done = TRUE; - break; - } - } - gst_iterator_free(it); - if (!This->their_sink) { - ERR("Could not find sink on filter %s\n", This->gstreamer_name); - return E_FAIL; - } - - it = gst_element_iterate_src_pads(This->filter); - gst_iterator_resync(it); - done = FALSE; - while (!done) { - GValue item = {0}; - - switch (gst_iterator_next(it, &item)) { - case GST_ITERATOR_RESYNC: - gst_iterator_resync (it); - break; - case GST_ITERATOR_OK: - This->their_src = g_value_get_object(&item); - gst_object_ref(This->their_src); - g_value_reset(&item); - case GST_ITERATOR_ERROR: - case GST_ITERATOR_DONE: - done = TRUE; - break; - } - } - gst_iterator_free(it); - found = !!This->their_src; - if (!found) - g_signal_connect(This->filter, "pad-added", G_CALLBACK(Gstreamer_transform_pad_added_wrapper), This); - ret = gst_pad_link(This->my_src, This->their_sink); - if (ret < 0) { - WARN("Failed to link with %i\n", ret); - return E_FAIL; - } - - ret = gst_pad_set_caps(This->my_src, capsin); - if (ret < 0) { - WARN("Failed to set caps on own source with %i\n", ret); - return E_FAIL; - } - - if (found) - Gstreamer_transform_pad_added(This->filter, This->their_src, This); - - if (!gst_pad_is_linked(This->my_sink)) - return E_FAIL; - - ret = gst_pad_set_caps(This->my_sink, capsout); - if (ret < 0) { - WARN("Failed to set caps on own sink with %i\n", ret); - return E_FAIL; - } - - TRACE("Connected\n"); - return S_OK; -} - -static HRESULT WINAPI Gstreamer_transform_Cleanup(TransformFilter *tf, PIN_DIRECTION dir) -{ - GstTfImpl *This = (GstTfImpl*)tf; - - TRACE("%p 0x%x\n", This, dir); - - mark_wine_thread(); - - if (dir == PINDIR_INPUT) - { - if (This->filter) { - gst_element_set_state(This->filter, GST_STATE_NULL); - gst_object_unref(This->filter); - } - This->filter = NULL; - if (This->my_src) { - gst_pad_unlink(This->my_src, This->their_sink); - gst_object_unref(This->my_src); - gst_object_unref(This->their_sink); - } - if (This->my_sink) { - gst_pad_unlink(This->their_src, This->my_sink); - gst_object_unref(This->my_sink); - gst_object_unref(This->their_src); - } - This->my_sink = This->my_src = This->their_sink = This->their_src = NULL; - } - return S_OK; -} - -static HRESULT WINAPI Gstreamer_transform_EndOfStream(TransformFilter *iface) -{ - GstTfImpl *This = (GstTfImpl*)iface; - TRACE("%p\n", This); - mark_wine_thread(); - - gst_pad_push_event(This->my_src, gst_event_new_eos()); - return S_OK; -} - -static HRESULT WINAPI Gstreamer_transform_BeginFlush(TransformFilter *iface) -{ - GstTfImpl *This = (GstTfImpl*)iface; - TRACE("%p\n", This); - mark_wine_thread(); - - gst_pad_push_event(This->my_src, gst_event_new_flush_start()); - return S_OK; -} - -static HRESULT WINAPI Gstreamer_transform_EndFlush(TransformFilter *iface) -{ - GstTfImpl *This = (GstTfImpl*)iface; - TRACE("%p\n", This); - mark_wine_thread(); - - gst_pad_push_event(This->my_src, gst_event_new_flush_stop(TRUE)); - return S_OK; -} - -static HRESULT WINAPI Gstreamer_transform_NewSegment(TransformFilter *iface, REFERENCE_TIME tStart, REFERENCE_TIME tStop, double dRate) -{ - GstTfImpl *This = (GstTfImpl*)iface; - const GstSegment segment = { GST_SEGMENT_FLAG_NONE, 1.0, dRate, GST_FORMAT_TIME, 0, 0, 0, tStop <= tStart ? -1 : tStop * 100, 0, tStart*100, -1 }; - - TRACE("%p\n", This); - mark_wine_thread(); - - gst_pad_push_event(This->my_src, gst_event_new_segment(&segment)); - - return S_OK; -} - -static HRESULT WINAPI Gstreamer_transform_QOS(TransformFilter *iface, IBaseFilter *sender, Quality qm) -{ - GstTfImpl *This = (GstTfImpl*)iface; - REFERENCE_TIME late = qm.Late; - - TRACE("%p %p { 0x%x %u %s %s }\n", This, sender, - qm.Type, qm.Proportion, - wine_dbgstr_longlong(qm.Late), - wine_dbgstr_longlong(qm.TimeStamp)); - - mark_wine_thread(); - - if (qm.Late < 0 && -qm.Late > qm.TimeStamp) - late = -qm.TimeStamp; - gst_pad_push_event(This->my_sink, gst_event_new_qos(late <= 0 ? GST_QOS_TYPE_OVERFLOW : GST_QOS_TYPE_UNDERFLOW, 1000. / qm.Proportion, late * 100, qm.TimeStamp * 100)); - return TransformFilterImpl_Notify(iface, sender, qm); -} - -static HRESULT Gstreamer_transform_create(IUnknown *outer, const CLSID *clsid, - const char *name, const TransformFilterFuncTable *vtbl, void **obj) -{ - GstTfImpl *This; - - if (FAILED(strmbase_transform_create(sizeof(GstTfImpl), outer, clsid, vtbl, (IBaseFilter **)&This))) - return E_OUTOFMEMORY; - - This->gstreamer_name = name; - *obj = &This->tf.filter.IUnknown_inner; - - TRACE("returning %p\n", This); - - return S_OK; -} - -static HRESULT WINAPI Gstreamer_Mp3_QueryConnect(TransformFilter *iface, const AM_MEDIA_TYPE *amt) -{ - GstTfImpl *This = (GstTfImpl*)iface; - TRACE("%p %p\n", This, amt); - - if ( (!IsEqualGUID(&amt->majortype, &MEDIATYPE_Audio) && - !IsEqualGUID(&amt->majortype, &MEDIATYPE_Stream)) || - (!IsEqualGUID(&amt->subtype, &MEDIASUBTYPE_MPEG1AudioPayload) && - !IsEqualGUID(&amt->subtype, &WMMEDIASUBTYPE_MP3)) - || !IsEqualGUID(&amt->formattype, &FORMAT_WaveFormatEx)){ - return S_FALSE; - } - - return S_OK; -} - -static HRESULT mp3_decoder_connect_sink(TransformFilter *tf, const AM_MEDIA_TYPE *amt) -{ - GstTfImpl *This = (GstTfImpl*)tf; - GstCaps *capsin, *capsout; - AM_MEDIA_TYPE *outpmt = &This->tf.pmt; - WAVEFORMATEX *wfx, *wfxin; - HRESULT hr; - int layer; - - mark_wine_thread(); - - if (Gstreamer_Mp3_QueryConnect(&This->tf, amt) == S_FALSE || !amt->pbFormat) - return VFW_E_TYPE_NOT_ACCEPTED; - - wfxin = (WAVEFORMATEX*)amt->pbFormat; - switch (wfxin->wFormatTag) { - case WAVE_FORMAT_MPEGLAYER3: - layer = 3; - break; - case WAVE_FORMAT_MPEG: { - MPEG1WAVEFORMAT *mpgformat = (MPEG1WAVEFORMAT*)wfxin; - layer = mpgformat->fwHeadLayer; - break; - } - default: - FIXME("Unhandled tag %x\n", wfxin->wFormatTag); - return E_FAIL; - } - - FreeMediaType(outpmt); - CopyMediaType(outpmt, amt); - - outpmt->subtype = MEDIASUBTYPE_PCM; - outpmt->formattype = FORMAT_WaveFormatEx; - outpmt->cbFormat = sizeof(*wfx); - CoTaskMemFree(outpmt->pbFormat); - wfx = CoTaskMemAlloc(outpmt->cbFormat); - outpmt->pbFormat = (BYTE*)wfx; - wfx->wFormatTag = WAVE_FORMAT_PCM; - wfx->wBitsPerSample = 16; - wfx->nSamplesPerSec = wfxin->nSamplesPerSec; - wfx->nChannels = wfxin->nChannels; - wfx->nBlockAlign = wfx->wBitsPerSample * wfx->nChannels / 8; - wfx->cbSize = 0; - wfx->nAvgBytesPerSec = wfx->nSamplesPerSec * wfx->nBlockAlign; - - capsin = gst_caps_new_simple("audio/mpeg", - "mpegversion", G_TYPE_INT, 1, - "layer", G_TYPE_INT, layer, - "rate", G_TYPE_INT, wfx->nSamplesPerSec, - "channels", G_TYPE_INT, wfx->nChannels, - NULL); - capsout = gst_caps_new_simple("audio/x-raw", - "format", G_TYPE_STRING, "S16LE", - "rate", G_TYPE_INT, wfx->nSamplesPerSec, - "channels", G_TYPE_INT, wfx->nChannels, - NULL); - - hr = Gstreamer_transform_ConnectInput(This, amt, capsin, capsout); - gst_caps_unref(capsin); - gst_caps_unref(capsout); - - This->cbBuffer = wfx->nAvgBytesPerSec / 4; - - return hr; -} - -static const TransformFilterFuncTable Gstreamer_Mp3_vtbl = { - .pfnDecideBufferSize = Gstreamer_transform_DecideBufferSize, - .pfnStartStreaming = Gstreamer_transform_ProcessBegin, - .pfnReceive = Gstreamer_transform_ProcessData, - .pfnStopStreaming = Gstreamer_transform_ProcessEnd, - .pfnCheckInputType = Gstreamer_Mp3_QueryConnect, - .transform_connect_sink = mp3_decoder_connect_sink, - .pfnBreakConnect = Gstreamer_transform_Cleanup, - .pfnEndOfStream = Gstreamer_transform_EndOfStream, - .pfnBeginFlush = Gstreamer_transform_BeginFlush, - .pfnEndFlush = Gstreamer_transform_EndFlush, - .pfnNewSegment = Gstreamer_transform_NewSegment, - .pfnNotify = Gstreamer_transform_QOS, -}; - -IUnknown * CALLBACK Gstreamer_Mp3_create(IUnknown *punkouter, HRESULT *phr) -{ - const char *plugin; - IUnknown *obj = NULL; - - TRACE("%p %p\n", punkouter, phr); - - if (!init_gstreamer()) - { - *phr = E_FAIL; - return NULL; - } - - mark_wine_thread(); - - plugin = Gstreamer_FindMatch("audio/mpeg, mpegversion=(int) 1"); - if (!plugin) - { - *phr = E_FAIL; - return NULL; - } - - *phr = Gstreamer_transform_create(punkouter, &CLSID_Gstreamer_Mp3, plugin, &Gstreamer_Mp3_vtbl, (LPVOID*)&obj); - - TRACE("returning %p\n", obj); - - return obj; -} diff --git a/dlls/winegstreamer/main.c b/dlls/winegstreamer/main.c index 3e0ef28afb6..59c2bd974d4 100644 --- a/dlls/winegstreamer/main.c +++ b/dlls/winegstreamer/main.c @@ -38,8 +38,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(gstreamer);
static const WCHAR wGstreamer_Splitter[] = {'G','S','t','r','e','a','m','e','r',' ','s','p','l','i','t','t','e','r',' ','f','i','l','t','e','r',0}; -static const WCHAR wGstreamer_Mp3[] = -{'G','S','t','r','e','a','m','e','r',' ','M','p','3',' ','f','i','l','t','e','r',0}; static const WCHAR wave_parserW[] = {'W','a','v','e',' ','P','a','r','s','e','r',0}; static const WCHAR avi_splitterW[] = @@ -94,32 +92,6 @@ static const AMOVIESETUP_FILTER amfSplitter = amfSplitPin };
-AMOVIESETUP_PIN amfMp3Pin[] = -{ { wNull, - FALSE, FALSE, FALSE, FALSE, - &GUID_NULL, - NULL, - 1, - amfMTaudio - }, - { - wNull, - FALSE, TRUE, FALSE, FALSE, - &GUID_NULL, - NULL, - 1, - amfMTaudio - }, -}; - -AMOVIESETUP_FILTER const amfMp3 = -{ &CLSID_Gstreamer_Mp3, - wGstreamer_Mp3, - MERIT_NORMAL, - 2, - amfMp3Pin -}; - static const AMOVIESETUP_MEDIATYPE wave_parser_sink_type_data[] = { {&MEDIATYPE_Stream, &MEDIASUBTYPE_WAVE}, @@ -260,13 +232,6 @@ FactoryTemplate const g_Templates[] = { NULL, &amfSplitter, }, - { - wGstreamer_Mp3, - &CLSID_Gstreamer_Mp3, - Gstreamer_Mp3_create, - NULL, - &amfMp3, - }, { wave_parserW, &CLSID_WAVEParser,
Signed-off-by: Zebediah Figura z.figura12@gmail.com --- dlls/strmbase/transform.c | 28 ++++++---------------------- include/wine/strmbase.h | 4 ---- 2 files changed, 6 insertions(+), 26 deletions(-)
diff --git a/dlls/strmbase/transform.c b/dlls/strmbase/transform.c index 74be6b107e5..2c75156c1bf 100644 --- a/dlls/strmbase/transform.c +++ b/dlls/strmbase/transform.c @@ -38,14 +38,6 @@ static inline TransformFilter *impl_from_sink_IPin(IPin *iface)
static HRESULT sink_query_accept(struct strmbase_pin *iface, const AM_MEDIA_TYPE *pmt) { - TransformFilter *pTransform = impl_from_sink_IPin(&iface->IPin_iface); - - TRACE("%p\n", iface); - - if (pTransform->pFuncsTable->pfnCheckInputType) - return pTransform->pFuncsTable->pfnCheckInputType(pTransform, pmt); - /* Assume OK if there's no query method (the connection will fail if - needed) */ return S_OK; }
@@ -239,13 +231,9 @@ static HRESULT sink_eos(struct strmbase_sink *iface) static HRESULT sink_begin_flush(struct strmbase_sink *iface) { TransformFilter *filter = impl_from_sink_IPin(&iface->pin.IPin_iface); - HRESULT hr = S_OK; - - if (filter->pFuncsTable->pfnBeginFlush) - hr = filter->pFuncsTable->pfnBeginFlush(filter); - if (SUCCEEDED(hr) && filter->source.pin.peer) - hr = IPin_BeginFlush(filter->source.pin.peer); - return hr; + if (filter->source.pin.peer) + return IPin_BeginFlush(filter->source.pin.peer); + return S_OK; }
static HRESULT sink_end_flush(struct strmbase_sink *iface) @@ -264,13 +252,9 @@ static HRESULT sink_new_segment(struct strmbase_sink *iface, REFERENCE_TIME start, REFERENCE_TIME stop, double rate) { TransformFilter *filter = impl_from_sink_IPin(&iface->pin.IPin_iface); - HRESULT hr = S_OK; - - if (filter->pFuncsTable->pfnNewSegment) - hr = filter->pFuncsTable->pfnNewSegment(filter, start, stop, rate); - if (SUCCEEDED(hr) && filter->source.pin.peer) - hr = IPin_NewSegment(filter->source.pin.peer, start, stop, rate); - return hr; + if (filter->source.pin.peer) + return IPin_NewSegment(filter->source.pin.peer, start, stop, rate); + return S_OK; }
static const struct strmbase_sink_ops sink_ops = diff --git a/include/wine/strmbase.h b/include/wine/strmbase.h index 48d7638ae16..abb04a8384a 100644 --- a/include/wine/strmbase.h +++ b/include/wine/strmbase.h @@ -195,13 +195,9 @@ typedef struct TransformFilterFuncTable { TransformFilter_StartStreaming pfnStartStreaming; TransformFilter_Receive pfnReceive; TransformFilter_StopStreaming pfnStopStreaming; - TransformFilter_CheckInputType pfnCheckInputType; HRESULT (*transform_connect_sink)(TransformFilter *filter, const AM_MEDIA_TYPE *mt); TransformFilter_BreakConnect pfnBreakConnect; - TransformFilter_EndOfStream pfnEndOfStream; - TransformFilter_BeginFlush pfnBeginFlush; TransformFilter_EndFlush pfnEndFlush; - TransformFilter_NewSegment pfnNewSegment; TransformFilter_Notify pfnNotify; } TransformFilterFuncTable;
Signed-off-by: Zebediah Figura z.figura12@gmail.com --- dlls/qcap/Makefile.in | 1 - dlls/strmbase/Makefile.in | 1 - dlls/strmbase/enumpins.c | 212 ------------------------------- dlls/strmbase/filter.c | 176 +++++++++++++++++++++++++ dlls/strmbase/strmbase_private.h | 1 - dlls/winegstreamer/Makefile.in | 1 - dlls/wineqtdecoder/Makefile.in | 1 - 7 files changed, 176 insertions(+), 217 deletions(-) delete mode 100644 dlls/strmbase/enumpins.c
diff --git a/dlls/qcap/Makefile.in b/dlls/qcap/Makefile.in index cb33e07c8d0..d10075aea08 100644 --- a/dlls/qcap/Makefile.in +++ b/dlls/qcap/Makefile.in @@ -9,7 +9,6 @@ C_SRCS = \ avimux.c \ capturegraph.c \ dllfunc.c \ - enumpins.c \ filter.c \ mediatype.c \ pin.c \ diff --git a/dlls/strmbase/Makefile.in b/dlls/strmbase/Makefile.in index c58a3591739..8fc9e242b1c 100644 --- a/dlls/strmbase/Makefile.in +++ b/dlls/strmbase/Makefile.in @@ -3,7 +3,6 @@ MODULE = libstrmbase.a C_SRCS = \ dispatch.c \ dllfunc.c \ - enumpins.c \ filter.c \ mediatype.c \ outputqueue.c \ diff --git a/dlls/strmbase/enumpins.c b/dlls/strmbase/enumpins.c deleted file mode 100644 index 1cfea85b0c4..00000000000 --- a/dlls/strmbase/enumpins.c +++ /dev/null @@ -1,212 +0,0 @@ -/* - * Implementation of IEnumPins Interface - * - * Copyright 2003 Robert Shearman - * Copyright 2010 Aric Stewart, CodeWeavers - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA - */ - -#include "strmbase_private.h" - -WINE_DEFAULT_DEBUG_CHANNEL(strmbase); - -typedef struct IEnumPinsImpl -{ - IEnumPins IEnumPins_iface; - LONG refCount; - unsigned int uIndex, count; - struct strmbase_filter *base; - DWORD Version; -} IEnumPinsImpl; - -static inline IEnumPinsImpl *impl_from_IEnumPins(IEnumPins *iface) -{ - return CONTAINING_RECORD(iface, IEnumPinsImpl, IEnumPins_iface); -} - -static const struct IEnumPinsVtbl IEnumPinsImpl_Vtbl; - -HRESULT enum_pins_create(struct strmbase_filter *base, IEnumPins **out) -{ - IEnumPinsImpl *object; - - if (!out) - return E_POINTER; - - if (!(object = heap_alloc_zero(sizeof(*object)))) - { - *out = NULL; - return E_OUTOFMEMORY; - } - - object->IEnumPins_iface.lpVtbl = &IEnumPinsImpl_Vtbl; - object->refCount = 1; - object->base = base; - IBaseFilter_AddRef(&base->IBaseFilter_iface); - object->Version = base->pin_version; - - while (base->ops->filter_get_pin(base, object->count)) - ++object->count; - - TRACE("Created enumerator %p.\n", object); - *out = &object->IEnumPins_iface; - - return S_OK; -} - -static HRESULT WINAPI IEnumPinsImpl_QueryInterface(IEnumPins * iface, REFIID riid, LPVOID * ppv) -{ - TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), ppv); - - *ppv = NULL; - - if (IsEqualIID(riid, &IID_IUnknown)) - *ppv = iface; - else if (IsEqualIID(riid, &IID_IEnumPins)) - *ppv = iface; - - if (*ppv) - { - IUnknown_AddRef((IUnknown *)(*ppv)); - return S_OK; - } - - FIXME("No interface for %s!\n", debugstr_guid(riid)); - - return E_NOINTERFACE; -} - -static ULONG WINAPI IEnumPinsImpl_AddRef(IEnumPins * iface) -{ - IEnumPinsImpl *This = impl_from_IEnumPins(iface); - ULONG ref = InterlockedIncrement(&This->refCount); - - TRACE("(%p)->(): new ref = %u\n", iface, ref); - - return ref; -} - -static ULONG WINAPI IEnumPinsImpl_Release(IEnumPins * iface) -{ - IEnumPinsImpl *This = impl_from_IEnumPins(iface); - ULONG ref = InterlockedDecrement(&This->refCount); - - TRACE("(%p)->(): new ref = %u\n", iface, ref); - - if (!ref) - { - IBaseFilter_Release(&This->base->IBaseFilter_iface); - heap_free(This); - } - - return ref; -} - -static HRESULT WINAPI IEnumPinsImpl_Next(IEnumPins * iface, ULONG cPins, IPin ** ppPins, ULONG * pcFetched) -{ - IEnumPinsImpl *This = impl_from_IEnumPins(iface); - ULONG i; - - TRACE("(%p)->(%u, %p, %p)\n", iface, cPins, ppPins, pcFetched); - - if (!ppPins) - return E_POINTER; - - if (cPins > 1 && !pcFetched) - return E_INVALIDARG; - - if (pcFetched) - *pcFetched = 0; - - if (This->Version != This->base->pin_version) - return VFW_E_ENUM_OUT_OF_SYNC; - - for (i = 0; i < cPins; ++i) - { - struct strmbase_pin *pin = This->base->ops->filter_get_pin(This->base, This->uIndex + i); - - if (!pin) - break; - - IPin_AddRef(ppPins[i] = &pin->IPin_iface); - } - - if (pcFetched) - *pcFetched = i; - This->uIndex += i; - - if (i < cPins) - return S_FALSE; - return S_OK; -} - -static HRESULT WINAPI IEnumPinsImpl_Skip(IEnumPins *iface, ULONG count) -{ - IEnumPinsImpl *enum_pins = impl_from_IEnumPins(iface); - - TRACE("enum_pins %p, count %u.\n", enum_pins, count); - - if (enum_pins->Version != enum_pins->base->pin_version) - return VFW_E_ENUM_OUT_OF_SYNC; - - if (enum_pins->uIndex + count > enum_pins->count) - return S_FALSE; - - enum_pins->uIndex += count; - return S_OK; -} - -static HRESULT WINAPI IEnumPinsImpl_Reset(IEnumPins *iface) -{ - IEnumPinsImpl *enum_pins = impl_from_IEnumPins(iface); - - TRACE("iface %p.\n", iface); - - if (enum_pins->Version != enum_pins->base->pin_version) - { - enum_pins->count = 0; - while (enum_pins->base->ops->filter_get_pin(enum_pins->base, enum_pins->count)) - ++enum_pins->count; - } - - enum_pins->Version = enum_pins->base->pin_version; - enum_pins->uIndex = 0; - - return S_OK; -} - -static HRESULT WINAPI IEnumPinsImpl_Clone(IEnumPins *iface, IEnumPins **out) -{ - IEnumPinsImpl *enum_pins = impl_from_IEnumPins(iface); - HRESULT hr; - - TRACE("iface %p, out %p.\n", iface, out); - - if (FAILED(hr = enum_pins_create(enum_pins->base, out))) - return hr; - return IEnumPins_Skip(*out, enum_pins->uIndex); -} - -static const IEnumPinsVtbl IEnumPinsImpl_Vtbl = -{ - IEnumPinsImpl_QueryInterface, - IEnumPinsImpl_AddRef, - IEnumPinsImpl_Release, - IEnumPinsImpl_Next, - IEnumPinsImpl_Skip, - IEnumPinsImpl_Reset, - IEnumPinsImpl_Clone -}; diff --git a/dlls/strmbase/filter.c b/dlls/strmbase/filter.c index 5242efe762a..a7e5fcd3f04 100644 --- a/dlls/strmbase/filter.c +++ b/dlls/strmbase/filter.c @@ -22,6 +22,182 @@
WINE_DEFAULT_DEBUG_CHANNEL(strmbase);
+struct enum_pins +{ + IEnumPins IEnumPins_iface; + LONG refcount; + + unsigned int index, count; + int version; + struct strmbase_filter *filter; +}; + +static const IEnumPinsVtbl enum_pins_vtbl; + +static HRESULT enum_pins_create(struct strmbase_filter *filter, IEnumPins **out) +{ + struct enum_pins *object; + + if (!out) + return E_POINTER; + + if (!(object = heap_alloc_zero(sizeof(*object)))) + { + *out = NULL; + return E_OUTOFMEMORY; + } + + object->IEnumPins_iface.lpVtbl = &enum_pins_vtbl; + object->refcount = 1; + object->filter = filter; + IBaseFilter_AddRef(&filter->IBaseFilter_iface); + object->version = filter->pin_version; + + while (filter->ops->filter_get_pin(filter, object->count)) + ++object->count; + + TRACE("Created enumerator %p.\n", object); + *out = &object->IEnumPins_iface; + + return S_OK; +} + +static inline struct enum_pins *impl_from_IEnumPins(IEnumPins *iface) +{ + return CONTAINING_RECORD(iface, struct enum_pins, IEnumPins_iface); +} + +static HRESULT WINAPI enum_pins_QueryInterface(IEnumPins *iface, REFIID iid, void **out) +{ + TRACE("iface %p, iid %s, out %p.\n", iface, debugstr_guid(iid), out); + + if (IsEqualGUID(iid, &IID_IUnknown) || IsEqualGUID(iid, &IID_IEnumPins)) + { + IEnumPins_AddRef(iface); + *out = iface; + return S_OK; + } + + WARN("%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid(iid)); + *out = NULL; + return E_NOINTERFACE; +} + +static ULONG WINAPI enum_pins_AddRef(IEnumPins *iface) +{ + struct enum_pins *enum_pins = impl_from_IEnumPins(iface); + ULONG refcount = InterlockedIncrement(&enum_pins->refcount); + TRACE("%p increasing refcount to %u.\n", enum_pins, refcount); + return refcount; +} + +static ULONG WINAPI enum_pins_Release(IEnumPins *iface) +{ + struct enum_pins *enum_pins = impl_from_IEnumPins(iface); + ULONG refcount = InterlockedDecrement(&enum_pins->refcount); + + TRACE("%p decreasing refcount to %u.\n", enum_pins, refcount); + if (!refcount) + { + IBaseFilter_Release(&enum_pins->filter->IBaseFilter_iface); + heap_free(enum_pins); + } + return refcount; +} + +static HRESULT WINAPI enum_pins_Next(IEnumPins *iface, ULONG count, IPin **pins, ULONG *ret_count) +{ + struct enum_pins *enum_pins = impl_from_IEnumPins(iface); + unsigned int i; + + TRACE("iface %p, count %u, pins %p, ret_count %p.\n", iface, count, pins, ret_count); + + if (!pins) + return E_POINTER; + + if (count > 1 && !ret_count) + return E_INVALIDARG; + + if (ret_count) + *ret_count = 0; + + if (enum_pins->version != enum_pins->filter->pin_version) + return VFW_E_ENUM_OUT_OF_SYNC; + + for (i = 0; i < count; ++i) + { + struct strmbase_pin *pin = enum_pins->filter->ops->filter_get_pin(enum_pins->filter, enum_pins->index + i); + + if (!pin) + break; + + IPin_AddRef(pins[i] = &pin->IPin_iface); + } + + if (ret_count) + *ret_count = i; + enum_pins->index += i; + return i == count ? S_OK : S_FALSE; +} + +static HRESULT WINAPI enum_pins_Skip(IEnumPins *iface, ULONG count) +{ + struct enum_pins *enum_pins = impl_from_IEnumPins(iface); + + TRACE("iface %p, count %u.\n", iface, count); + + if (enum_pins->version != enum_pins->filter->pin_version) + return VFW_E_ENUM_OUT_OF_SYNC; + + if (enum_pins->index + count > enum_pins->count) + return S_FALSE; + + enum_pins->index += count; + return S_OK; +} + +static HRESULT WINAPI enum_pins_Reset(IEnumPins *iface) +{ + struct enum_pins *enum_pins = impl_from_IEnumPins(iface); + + TRACE("iface %p.\n", iface); + + if (enum_pins->version != enum_pins->filter->pin_version) + { + enum_pins->count = 0; + while (enum_pins->filter->ops->filter_get_pin(enum_pins->filter, enum_pins->count)) + ++enum_pins->count; + } + + enum_pins->version = enum_pins->filter->pin_version; + enum_pins->index = 0; + + return S_OK; +} + +static HRESULT WINAPI enum_pins_Clone(IEnumPins *iface, IEnumPins **out) +{ + struct enum_pins *enum_pins = impl_from_IEnumPins(iface); + HRESULT hr; + + TRACE("iface %p, out %p.\n", iface, out); + + if (FAILED(hr = enum_pins_create(enum_pins->filter, out))) + return hr; + return IEnumPins_Skip(*out, enum_pins->index); +} + +static const IEnumPinsVtbl enum_pins_vtbl = +{ + enum_pins_QueryInterface, + enum_pins_AddRef, + enum_pins_Release, + enum_pins_Next, + enum_pins_Skip, + enum_pins_Reset, + enum_pins_Clone, +}; + static inline struct strmbase_filter *impl_from_IUnknown(IUnknown *iface) { return CONTAINING_RECORD(iface, struct strmbase_filter, IUnknown_inner); diff --git a/dlls/strmbase/strmbase_private.h b/dlls/strmbase/strmbase_private.h index 49e624b41bc..7b471515b63 100644 --- a/dlls/strmbase/strmbase_private.h +++ b/dlls/strmbase/strmbase_private.h @@ -77,7 +77,6 @@ void QualityControlRender_DoQOS(QualityControlImpl *priv); void QualityControlRender_BeginRender(QualityControlImpl *This, REFERENCE_TIME start, REFERENCE_TIME stop); void QualityControlRender_EndRender(QualityControlImpl *This);
-HRESULT enum_pins_create(struct strmbase_filter *filter, IEnumPins **enum_pins); HRESULT enum_media_types_create(struct strmbase_pin *pin, IEnumMediaTypes **enum_media_types) DECLSPEC_HIDDEN;
HRESULT WINAPI RendererPosPassThru_RegisterMediaTime(IUnknown *iface, REFERENCE_TIME start); diff --git a/dlls/winegstreamer/Makefile.in b/dlls/winegstreamer/Makefile.in index c536f2521c0..2050a44b132 100644 --- a/dlls/winegstreamer/Makefile.in +++ b/dlls/winegstreamer/Makefile.in @@ -6,7 +6,6 @@ PARENTSRC = ../strmbase
C_SRCS = \ dllfunc.c \ - enumpins.c \ filter.c \ gst_cbs.c \ gstdemux.c \ diff --git a/dlls/wineqtdecoder/Makefile.in b/dlls/wineqtdecoder/Makefile.in index 55918169b3e..bdd387432e5 100644 --- a/dlls/wineqtdecoder/Makefile.in +++ b/dlls/wineqtdecoder/Makefile.in @@ -5,7 +5,6 @@ PARENTSRC = ../strmbase
C_SRCS = \ dllfunc.c \ - enumpins.c \ filter.c \ main.c \ mediatype.c \
Signed-off-by: Zebediah Figura z.figura12@gmail.com --- dlls/quartz/tests/avisplit.c | 1 - dlls/quartz/tests/filesource.c | 1 - dlls/quartz/tests/mpegsplit.c | 1 - dlls/quartz/tests/waveparser.c | 1 - dlls/strmbase/filter.c | 2 +- 5 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/dlls/quartz/tests/avisplit.c b/dlls/quartz/tests/avisplit.c index 31cb767b607..4af101767d6 100644 --- a/dlls/quartz/tests/avisplit.c +++ b/dlls/quartz/tests/avisplit.c @@ -353,7 +353,6 @@ static void test_enum_pins(void) graph = connect_input(filter, filename);
hr = IEnumPins_Next(enum1, 1, pins, NULL); -todo_wine ok(hr == S_FALSE, "Got hr %#x.\n", hr);
hr = IEnumPins_Reset(enum1); diff --git a/dlls/quartz/tests/filesource.c b/dlls/quartz/tests/filesource.c index 3e571fa0e33..918605da6d4 100644 --- a/dlls/quartz/tests/filesource.c +++ b/dlls/quartz/tests/filesource.c @@ -526,7 +526,6 @@ static void test_enum_pins(void) load_file(filter, filename);
hr = IEnumPins_Next(enum1, 1, pins, NULL); -todo_wine ok(hr == S_FALSE, "Got hr %#x.\n", hr);
hr = IEnumPins_Reset(enum1); diff --git a/dlls/quartz/tests/mpegsplit.c b/dlls/quartz/tests/mpegsplit.c index c45f982a027..67dd6d312dc 100644 --- a/dlls/quartz/tests/mpegsplit.c +++ b/dlls/quartz/tests/mpegsplit.c @@ -347,7 +347,6 @@ static void test_enum_pins(void) graph = connect_input(filter, filename);
hr = IEnumPins_Next(enum1, 1, pins, NULL); -todo_wine ok(hr == S_FALSE, "Got hr %#x.\n", hr);
hr = IEnumPins_Reset(enum1); diff --git a/dlls/quartz/tests/waveparser.c b/dlls/quartz/tests/waveparser.c index 61ba2018e4e..e9540bc0f55 100644 --- a/dlls/quartz/tests/waveparser.c +++ b/dlls/quartz/tests/waveparser.c @@ -351,7 +351,6 @@ static void test_enum_pins(void) graph = connect_input(filter, filename);
hr = IEnumPins_Next(enum1, 1, pins, NULL); -todo_wine ok(hr == S_FALSE, "Got hr %#x.\n", hr);
hr = IEnumPins_Reset(enum1); diff --git a/dlls/strmbase/filter.c b/dlls/strmbase/filter.c index a7e5fcd3f04..43da4b3fb90 100644 --- a/dlls/strmbase/filter.c +++ b/dlls/strmbase/filter.c @@ -122,7 +122,7 @@ static HRESULT WINAPI enum_pins_Next(IEnumPins *iface, ULONG count, IPin **pins, *ret_count = 0;
if (enum_pins->version != enum_pins->filter->pin_version) - return VFW_E_ENUM_OUT_OF_SYNC; + return S_FALSE;
for (i = 0; i < count; ++i) {
Signed-off-by: Zebediah Figura z.figura12@gmail.com --- dlls/strmbase/mediatype.c | 170 ----------------------------- dlls/strmbase/pin.c | 176 +++++++++++++++++++++++++++++++ dlls/strmbase/strmbase_private.h | 2 - 3 files changed, 176 insertions(+), 172 deletions(-)
diff --git a/dlls/strmbase/mediatype.c b/dlls/strmbase/mediatype.c index 7ab8b6e7083..64035b5e6b1 100644 --- a/dlls/strmbase/mediatype.c +++ b/dlls/strmbase/mediatype.c @@ -168,173 +168,3 @@ void WINAPI DeleteMediaType(AM_MEDIA_TYPE * pMediaType) FreeMediaType(pMediaType); CoTaskMemFree(pMediaType); } - -typedef struct IEnumMediaTypesImpl -{ - IEnumMediaTypes IEnumMediaTypes_iface; - LONG refCount; - struct strmbase_pin *basePin; - ULONG count; - ULONG uIndex; -} IEnumMediaTypesImpl; - -static inline IEnumMediaTypesImpl *impl_from_IEnumMediaTypes(IEnumMediaTypes *iface) -{ - return CONTAINING_RECORD(iface, IEnumMediaTypesImpl, IEnumMediaTypes_iface); -} - -static const struct IEnumMediaTypesVtbl IEnumMediaTypesImpl_Vtbl; - -HRESULT enum_media_types_create(struct strmbase_pin *basePin, IEnumMediaTypes **ppEnum) -{ - IEnumMediaTypesImpl * pEnumMediaTypes = CoTaskMemAlloc(sizeof(IEnumMediaTypesImpl)); - - *ppEnum = NULL; - - if (!pEnumMediaTypes) - return E_OUTOFMEMORY; - - pEnumMediaTypes->IEnumMediaTypes_iface.lpVtbl = &IEnumMediaTypesImpl_Vtbl; - pEnumMediaTypes->refCount = 1; - pEnumMediaTypes->uIndex = 0; - IPin_AddRef(&basePin->IPin_iface); - pEnumMediaTypes->basePin = basePin; - - IEnumMediaTypes_Reset(&pEnumMediaTypes->IEnumMediaTypes_iface); - - *ppEnum = &pEnumMediaTypes->IEnumMediaTypes_iface; - return S_OK; -} - -static HRESULT WINAPI IEnumMediaTypesImpl_QueryInterface(IEnumMediaTypes * iface, REFIID riid, void ** ret_iface) -{ - TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), ret_iface); - - if (IsEqualIID(riid, &IID_IUnknown) || - IsEqualIID(riid, &IID_IEnumMediaTypes)) - { - IEnumMediaTypes_AddRef(iface); - *ret_iface = iface; - return S_OK; - } - - *ret_iface = NULL; - - WARN("No interface for %s\n", debugstr_guid(riid)); - - return E_NOINTERFACE; -} - -static ULONG WINAPI IEnumMediaTypesImpl_AddRef(IEnumMediaTypes * iface) -{ - IEnumMediaTypesImpl *This = impl_from_IEnumMediaTypes(iface); - ULONG ref = InterlockedIncrement(&This->refCount); - - TRACE("(%p)->(): new ref = %u\n", iface, ref); - - return ref; -} - -static ULONG WINAPI IEnumMediaTypesImpl_Release(IEnumMediaTypes * iface) -{ - IEnumMediaTypesImpl *This = impl_from_IEnumMediaTypes(iface); - ULONG ref = InterlockedDecrement(&This->refCount); - - TRACE("(%p)->(): new ref = %u\n", iface, ref); - - if (!ref) - { - IPin_Release(&This->basePin->IPin_iface); - CoTaskMemFree(This); - } - return ref; -} - -static HRESULT WINAPI IEnumMediaTypesImpl_Next(IEnumMediaTypes *iface, - ULONG count, AM_MEDIA_TYPE **mts, ULONG *ret_count) -{ - IEnumMediaTypesImpl *enummt = impl_from_IEnumMediaTypes(iface); - ULONG i; - - TRACE("iface %p, count %u, mts %p, ret_count %p.\n", iface, count, mts, ret_count); - - for (i = 0; i < count && enummt->uIndex + i < enummt->count; i++) - { - if (!(mts[i] = CoTaskMemAlloc(sizeof(AM_MEDIA_TYPE))) - || FAILED(enummt->basePin->pFuncsTable->pin_get_media_type(enummt->basePin, enummt->uIndex + i, mts[i]))) - { - while (i--) - DeleteMediaType(mts[i]); - *ret_count = 0; - return E_OUTOFMEMORY; - } - - if (TRACE_ON(strmbase)) - { - TRACE("Returning media type %u:\n", enummt->uIndex + i); - strmbase_dump_media_type(mts[i]); - } - } - - if ((count != 1) || ret_count) - *ret_count = i; - - enummt->uIndex += i; - - return i == count ? S_OK : S_FALSE; -} - -static HRESULT WINAPI IEnumMediaTypesImpl_Skip(IEnumMediaTypes *iface, ULONG count) -{ - IEnumMediaTypesImpl *enummt = impl_from_IEnumMediaTypes(iface); - - TRACE("iface %p, count %u.\n", iface, count); - - enummt->uIndex += count; - - return enummt->uIndex > enummt->count ? S_FALSE : S_OK; -} - -static HRESULT WINAPI IEnumMediaTypesImpl_Reset(IEnumMediaTypes * iface) -{ - ULONG i; - AM_MEDIA_TYPE amt; - IEnumMediaTypesImpl *This = impl_from_IEnumMediaTypes(iface); - - TRACE("(%p)->()\n", iface); - - i = 0; - while (This->basePin->pFuncsTable->pin_get_media_type(This->basePin, i, &amt) == S_OK) - { - FreeMediaType(&amt); - i++; - } - This->count = i; - This->uIndex = 0; - - return S_OK; -} - -static HRESULT WINAPI IEnumMediaTypesImpl_Clone(IEnumMediaTypes * iface, IEnumMediaTypes ** ppEnum) -{ - HRESULT hr; - IEnumMediaTypesImpl *This = impl_from_IEnumMediaTypes(iface); - - TRACE("(%p)->(%p)\n", iface, ppEnum); - - hr = enum_media_types_create(This->basePin, ppEnum); - if (FAILED(hr)) - return hr; - return IEnumMediaTypes_Skip(*ppEnum, This->uIndex); -} - -static const IEnumMediaTypesVtbl IEnumMediaTypesImpl_Vtbl = -{ - IEnumMediaTypesImpl_QueryInterface, - IEnumMediaTypesImpl_AddRef, - IEnumMediaTypesImpl_Release, - IEnumMediaTypesImpl_Next, - IEnumMediaTypesImpl_Skip, - IEnumMediaTypesImpl_Reset, - IEnumMediaTypesImpl_Clone -}; diff --git a/dlls/strmbase/pin.c b/dlls/strmbase/pin.c index 6f22f249766..fd74a409556 100644 --- a/dlls/strmbase/pin.c +++ b/dlls/strmbase/pin.c @@ -27,6 +27,182 @@ static const IMemInputPinVtbl MemInputPin_Vtbl;
typedef HRESULT (*SendPinFunc)( IPin *to, LPVOID arg );
+struct enum_media_types +{ + IEnumMediaTypes IEnumMediaTypes_iface; + LONG refcount; + + unsigned int index, count; + struct strmbase_pin *pin; +}; + +static const IEnumMediaTypesVtbl enum_media_types_vtbl; + +static HRESULT enum_media_types_create(struct strmbase_pin *pin, IEnumMediaTypes **out) +{ + struct enum_media_types *object; + AM_MEDIA_TYPE mt; + + if (!out) + return E_POINTER; + + if (!(object = heap_alloc_zero(sizeof(*object)))) + { + *out = NULL; + return E_OUTOFMEMORY; + } + + object->IEnumMediaTypes_iface.lpVtbl = &enum_media_types_vtbl; + object->refcount = 1; + object->pin = pin; + IPin_AddRef(&pin->IPin_iface); + + while (pin->pFuncsTable->pin_get_media_type(pin, object->count, &mt) == S_OK) + { + FreeMediaType(&mt); + ++object->count; + } + + TRACE("Created enumerator %p.\n", object); + *out = &object->IEnumMediaTypes_iface; + + return S_OK; +} + +static struct enum_media_types *impl_from_IEnumMediaTypes(IEnumMediaTypes *iface) +{ + return CONTAINING_RECORD(iface, struct enum_media_types, IEnumMediaTypes_iface); +} + +static HRESULT WINAPI enum_media_types_QueryInterface(IEnumMediaTypes *iface, REFIID iid, void **out) +{ + TRACE("iface %p, iid %s, out %p.\n", iface, debugstr_guid(iid), out); + + if (IsEqualGUID(iid, &IID_IUnknown) || IsEqualGUID(iid, &IID_IEnumMediaTypes)) + { + IEnumMediaTypes_AddRef(iface); + *out = iface; + return S_OK; + } + + WARN("%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid(iid)); + *out = NULL; + return E_NOINTERFACE; +} + +static ULONG WINAPI enum_media_types_AddRef(IEnumMediaTypes *iface) +{ + struct enum_media_types *enummt = impl_from_IEnumMediaTypes(iface); + ULONG refcount = InterlockedIncrement(&enummt->refcount); + TRACE("%p increasing refcount to %u.\n", enummt, refcount); + return refcount; +} + +static ULONG WINAPI enum_media_types_Release(IEnumMediaTypes *iface) +{ + struct enum_media_types *enummt = impl_from_IEnumMediaTypes(iface); + ULONG refcount = InterlockedDecrement(&enummt->refcount); + + TRACE("%p decreasing refcount to %u.\n", enummt, refcount); + if (!refcount) + { + IPin_Release(&enummt->pin->IPin_iface); + heap_free(enummt); + } + return refcount; +} + +static HRESULT WINAPI enum_media_types_Next(IEnumMediaTypes *iface, ULONG count, + AM_MEDIA_TYPE **mts, ULONG *ret_count) +{ + struct enum_media_types *enummt = impl_from_IEnumMediaTypes(iface); + unsigned int i; + HRESULT hr; + + TRACE("enummt %p, count %u, mts %p, ret_count %p.\n", enummt, count, mts, ret_count); + + for (i = 0; i < count; ++i) + { + if ((mts[i] = CoTaskMemAlloc(sizeof(AM_MEDIA_TYPE)))) + hr = enummt->pin->pFuncsTable->pin_get_media_type(enummt->pin, enummt->index + i, mts[i]); + else + hr = E_OUTOFMEMORY; + if (FAILED(hr)) + { + while (i--) + DeleteMediaType(mts[i]); + *ret_count = 0; + return E_OUTOFMEMORY; + } + else if (hr != S_OK) + break; + + if (TRACE_ON(strmbase)) + { + TRACE("Returning media type %u:\n", enummt->index + i); + strmbase_dump_media_type(mts[i]); + } + } + + if (count != 1 || ret_count) + *ret_count = i; + enummt->index += i; + return i == count ? S_OK : S_FALSE; +} + +static HRESULT WINAPI enum_media_types_Skip(IEnumMediaTypes *iface, ULONG count) +{ + struct enum_media_types *enummt = impl_from_IEnumMediaTypes(iface); + + TRACE("enummt %p, count %u.\n", enummt, count); + + enummt->index += count; + + return enummt->index > enummt->count ? S_FALSE : S_OK; +} + +static HRESULT WINAPI enum_media_types_Reset(IEnumMediaTypes *iface) +{ + struct enum_media_types *enummt = impl_from_IEnumMediaTypes(iface); + AM_MEDIA_TYPE mt; + + TRACE("enummt %p.\n", enummt); + + enummt->count = 0; + while (enummt->pin->pFuncsTable->pin_get_media_type(enummt->pin, enummt->count, &mt) == S_OK) + { + FreeMediaType(&mt); + ++enummt->count; + } + + enummt->index = 0; + + return S_OK; +} + +static HRESULT WINAPI enum_media_types_Clone(IEnumMediaTypes *iface, IEnumMediaTypes **out) +{ + struct enum_media_types *enummt = impl_from_IEnumMediaTypes(iface); + HRESULT hr; + + TRACE("enummt %p, out %p.\n", enummt, out); + + if (FAILED(hr = enum_media_types_create(enummt->pin, out))) + return hr; + return IEnumMediaTypes_Skip(*out, enummt->index); +} + +static const IEnumMediaTypesVtbl enum_media_types_vtbl = +{ + enum_media_types_QueryInterface, + enum_media_types_AddRef, + enum_media_types_Release, + enum_media_types_Next, + enum_media_types_Skip, + enum_media_types_Reset, + enum_media_types_Clone, +}; + static inline struct strmbase_pin *impl_from_IPin(IPin *iface) { return CONTAINING_RECORD(iface, struct strmbase_pin, IPin_iface); diff --git a/dlls/strmbase/strmbase_private.h b/dlls/strmbase/strmbase_private.h index 7b471515b63..b03258bc416 100644 --- a/dlls/strmbase/strmbase_private.h +++ b/dlls/strmbase/strmbase_private.h @@ -77,8 +77,6 @@ void QualityControlRender_DoQOS(QualityControlImpl *priv); void QualityControlRender_BeginRender(QualityControlImpl *This, REFERENCE_TIME start, REFERENCE_TIME stop); void QualityControlRender_EndRender(QualityControlImpl *This);
-HRESULT enum_media_types_create(struct strmbase_pin *pin, IEnumMediaTypes **enum_media_types) DECLSPEC_HIDDEN; - HRESULT WINAPI RendererPosPassThru_RegisterMediaTime(IUnknown *iface, REFERENCE_TIME start); HRESULT WINAPI RendererPosPassThru_ResetMediaTime(IUnknown *iface); HRESULT WINAPI RendererPosPassThru_EOS(IUnknown *iface);
-
Zebediah Figura