Re: [PATCH] fusion: use correct size for ZeroMemory (GCC7)

[Dmitry Timoshkov]

Marcus Meissner  wrote:
> diff --git a/dlls/fusion/tests/asmname.c b/dlls/fusion/tests/asmname.c
> index 5fb14a4829..21cd4874ed 100644
> --- a/dlls/fusion/tests/asmname.c
> +++ b/dlls/fusion/tests/asmname.c
> @@ -358,7 +358,7 @@ static void test_assembly_name_props_line(IAssemblyName *name,
>          to_widechar(expect, vals[i].val);
>      size = MAX_PATH;
> -
>    ZeroMemory(str, MAX_PATH);
> -
>    ZeroMemory(str, sizeof(str));
>    hr = IAssemblyName_GetProperty(name, i, str, &size);
>    to_multibyte(val, str);

Same problem with IAssemblyName_GetProperty() and 'size' argumenet as
for the previous patch.

[PATCH] fusion: use correct size for ZeroMemory (GCC7)

[Marcus Meissner]

On Fri, Jun 02, 2017 at 04:58:50PM +0800, Dmitry Timoshkov wrote:
> Marcus Meissner  wrote:
> > diff --git a/dlls/fusion/tests/asmname.c b/dlls/fusion/tests/asmname.c
> > index 5fb14a4829..21cd4874ed 100644
> > --- a/dlls/fusion/tests/asmname.c
> > +++ b/dlls/fusion/tests/asmname.c
> > @@ -358,7 +358,7 @@ static void test_assembly_name_props_line(IAssemblyName *name,
> >          to_widechar(expect, vals[i].val);
> >      size = MAX_PATH;
> > -
> >    ZeroMemory(str, MAX_PATH);
> > -
> >    ZeroMemory(str, sizeof(str));
> >    hr = IAssemblyName_GetProperty(name, i, str, &size);
> >    to_multibyte(val, str);
>
> Same problem with IAssemblyName_GetProperty() and 'size' argumenet as
> for the previous patch.

I am not sure documentation and reality agree on this.

If I pass in size in bytes and then later on change it back to character count
the testsuite starts to fail with 2* factors.

Our implementation and upstream(?) seems to return character count on some of those
properties.

Ciao, Marcus