Re: [PATCH] setkey breaks FreeBSD

[Mike Hearn]

Anish Mistry wrote:
> The attached patch fixes a CVS build problem with confilicting setkey in the 
> stdlib.h header.  It's changed to WINE_setkey.  I've gone ahead and changed 
> getkey to match.

Aesthetics wise, I'd rather it was renamed to eg setcfgkey or something 
- there are no WINE_ prefixes in winecfg and none are needed, I'd rather 
keep it that way.

thanks -mike

[PATCH] setkey breaks FreeBSD

[Mike McCormack]

Mike Hearn wrote:
> Aesthetics wise, I'd rather it was renamed to eg setcfgkey or something
> - there are no WINE_ prefixes in winecfg and none are needed, I'd rather
>
> keep it that way.

I think the name I suggested was WINECFG_setkey.  In anycase the point 
of having prefixes is to make the functions easy to find, and to prevent 
clashes with libc or other library functions.

Mike

[PATCH] setkey breaks FreeBSD

[Mike Hearn]

Mike McCormack wrote:
> I think the name I suggested was WINECFG_setkey.  In anycase the point 
> of having prefixes is to make the functions easy to find, and to prevent 
> clashes with libc or other library functions.

Yeah, it's not a bad name. I'd rather it be in lower case though, eg 
wine_setkey or whatever, IMHO that's more pleasing to the eye. Yes I 
really am that shallow :)

Yay for non-namespaced APIs <sigh>

[PATCH] setkey breaks FreeBSD

[Robert Shearman]

Mike McCormack wrote:
> Mike Hearn wrote:
> > Aesthetics wise, I'd rather it was renamed to eg setcfgkey or 
> > something - there are no WINE_ prefixes in winecfg and none are 
> > needed, I'd rather keep it that way.
>
> I think the name I suggested was WINECFG_setkey.  In anycase the point 
> of having prefixes is to make the functions easy to find, and to 
> prevent clashes with libc or other library functions.

But all-caps is ugly. I'd prefer Mike Hearn's suggestion.

Rob