Re: [v3 signed 4/6] wined3d: introduce a new wined3d_rendertarget_view_create_from_sub_resource function

[Henri Verbeet]

On 22 October 2015 at 12:01, Riccardo Bortolato  wrote:
> +HRESULT __cdecl wined3d_rendertarget_view_create_from_sub_resource(struct wined3d_texture *texture,

Just use CDECL here. include/wine/wined3d.h should actually use CDECL
as well, but currently uses __cdecl for historic reasons.
> - sub_resource = wined3d_texture_get_sub_resource(texture, sub_resource_idx);
> - surface = surface_from_resource(sub_resource);

You can't assume the sub-resource is a surface here.

[v3 signed 4/6] wined3d: introduce a new wined3d_rendertarget_view_create_from_sub_resource function

[Riccardo Bortolato]

OK, I'll fix this

Ciao,
Riccardo

2015-10-27 15:40 GMT+01:00 Henri Verbeet :
> On 22 October 2015 at 12:01, Riccardo Bortolato  wrote:
> > +HRESULT __cdecl wined3d_rendertarget_view_create_from_sub_resource(struct wined3d_texture *texture,
>
> Just use CDECL here. include/wine/wined3d.h should actually use CDECL
> as well, but currently uses __cdecl for historic reasons.
> > - sub_resource = wined3d_texture_get_sub_resource(texture, sub_resource_idx);
> > - surface = surface_from_resource(sub_resource);
>
> You can't assume the sub-resource is a surface here.