[winetest] Use of HeapAlloc and friends

[Paul Vriens]

Hi,

Is there any particular reason we don't use HeapAlloc/HeapReAlloc in winetest? 
The rest of our programs do, but winetest uses malloc and realloc.

Cheers,

Paul.

[Ferenc Wagner]

Paul Vriens  writes:
> Is there any particular reason we don't use HeapAlloc/HeapReAlloc in
> winetest? The rest of our programs do, but winetest uses malloc and
> realloc.

I can't recall any.  I'm more comfortable with the latter, since
winetest is the only Win32 application I've ever written.

[Paul Vriens]

Ferenc Wagner wrote:
> Paul Vriens  writes:
> > Is there any particular reason we don't use HeapAlloc/HeapReAlloc in
> > winetest? The rest of our programs do, but winetest uses malloc and
> > realloc.
>
> I can't recall any.  I'm more comfortable with the latter, since
> winetest is the only Win32 application I've ever written.

So when I add functionality should I use malloc or can we use a mix? Should 
winetest be changed to use HeapAlloc?

[Ferenc Wagner]

Paul Vriens  writes:
> Ferenc Wagner wrote:
> > Paul Vriens  writes:
> > > Is there any particular reason we don't use HeapAlloc/HeapReAlloc in
> > > winetest? The rest of our programs do, but winetest uses malloc and
> > > realloc.
> >
> > I can't recall any.  I'm more comfortable with the latter, since
> > winetest is the only Win32 application I've ever written.
>
> So when I add functionality should I use malloc or can we use a mix?
> Should winetest be changed to use HeapAlloc?

That I can't tell.  At least I haven't heard a single objection
against my style in this respect.  Mixing the two doesn't sound like a
particularly compelling idea for me.

[Dmitry Timoshkov]

"Paul Vriens"  wrote:
> Is there any particular reason we don't use HeapAlloc/HeapReAlloc in winetest? 
> The rest of our programs do, but winetest uses malloc and realloc.

I recall that replacing malloc/realloc by HeapAlloc/HeapReAlloc has fixed
user32/tests/msg.c failures under Win95 (that were caused by buggy msvcrt
implementations), so if are still aming to run the tests on that platform
we should get rid of malloc/realloc.