Re: [2/3] Use quotes around service names in net program.

[Nikolay Sivov]

On 13.09.2015 18:51, [e-mail] wrote:

Please update resource file only, the rest will be regenerated with 
appropriate fuzziness (e.g. Russian strings are done wrong, regarding 
quotation marks).

[2/3] Use quotes around service names in net program.

[Florian Pelz]

On 09/13/2015 06:30 PM, Nikolay Sivov wrote:
> On 13.09.2015 18:51, [e-mail] wrote:
>
> Please update resource file only, the rest will be regenerated with
> appropriate fuzziness (e.g. Russian strings are done wrong, regarding
> quotation marks).

Hmm… I've tried to be careful and keep it consistent with the rest of
the translation. I have not just done a search and replace, e.g.
Norwegian and Danish have proper quotes and Chinese has none. Clearly
I've failed to do so for the Russian, Czech, French and Lithuanian
locales. This should not have happened.

I fail to see why changing everything in the same patch is wrong here
because
- no knowledge of each individual language is required and
- not patching them means some languages will take forever to update.

I'll look carefully at everything in patch 2 and 3 again and resend
*with* fixed translations. Of course, I could discard my fixes or put
them in separate patches but I don't see why.

Best regards,
Florian

[2/3] Use quotes around service names in net program.

[Florian Pelz]

On 09/13/2015 07:53 PM, Florian Pelz wrote:
> Hmm… I've tried to be careful and keep it consistent with the rest of
> the translation. I have not just done a search and replace, e.g.
> Norwegian and Danish have proper quotes and Chinese has none.

Actually no, I was not careful with the quotes there. Norwegian and
Danish already had those quotes. Sorry.

[2/3] Use quotes around service names in net program.

[Florian Pelz]

I resent the two patches with quotes fixed and no changes to the Arabic
translation's punctuation because it is inconsistent. (Sadly the patch
did not get through yesterday and now I sent it multiple times… Sorry
again.) Thank you for the review.

If you still think that I should not be fixing quotes/punctuation in the
translations or that I should do so in separate patches, I will comply.
However, this would break the translations until someone fixes them
(which would take a while for the unmaintained translations).

Best Regards,
Florian