Re: add version info to the reg

[Vincent Béron]

Le jeu 10/03/2005 à 17:50, Ivan Leo Puoti a écrit :
> lamest patch I've ever sent, but it wasn't my idea.
>
> ChangeLog:
> Add hardcoded version info to the registry.
> Ivan.
> --- wine/tools/wine.inf	2005-01-08 09:32:29.000000000 +0100
> +++ new/tools/wine.inf	2005-03-10 23:19:01.589998042 +0100
> @@ -108,6 +108,8 @@
>  HKLM,%CurrentVersion%,"ProgramFilesDir",,"%16422%"
>  HKLM,%CurrentVersion%,"RegisteredOrganization",,"Change preferred organization in ~/.wine/system.reg"
>  HKLM,%CurrentVersion%,"RegisteredOwner",,"Change preferred owner in ~/.wine/system.reg"
> +HKLM,%CurrentVersion%,"CSDVersion",,"Service Pack 4"
> +HKLM,%CurrentVersion%,"CurrentVersion",,"5.0"
>  HKLM,%CurrentVersion%\Setup,"BootDir",,"%30%"
>  HKLM,%CurrentVersion%\Setup,"SharedDir",,"%25%"
>  HKLM,Software\Microsoft\Windows NT\CurrentVersion\Fonts,,,""

This doesn't look like the right place to put it, especially since Wine
can be set to something else than Win2k.

That doesn't mean I know where to put it...

Vincent

add version info to the reg

[Andreas Mohr]

Hi,

On Thu, Mar 10, 2005 at 09:26:12PM -0500, Vincent Béron wrote:
> Le jeu 10/03/2005 à 17:50, Ivan Leo Puoti a écrit :
> > lamest patch I've ever sent, but it wasn't my idea.
> >
> > ChangeLog:
> > Add hardcoded version info to the registry.

[...]
> This doesn't look like the right place to put it, especially since Wine
> can be set to something else than Win2k.

I'm also getting headaches if someone's talking about hardcoding it...
> That doesn't mean I know where to put it...

IMHO this should definitely be done somewhere in the Windows version code,
i.e. dlls/ntdll/version.c
Once that code initially has figured out which Windows version it's going
to announce in the future, it should set these registry keys to a proper value.

Or, if the registry has a mechanism for "temporary" keys, set the key
on a dynamic (per-access?) basis in order to handle dynamic version detection
properly. But I'm quite sure this isn't possible.

Another issue is when to set these registry keys. We most likely don't want
them to be available after the first GetVersion() call only, so we might need
to do that on Wine startup.
(or maybe this validates the current patch, since that would make sure we do
have initial version registry, which could then be further adapted by the
version detection mechanism)

Andreas Mohr

add version info to the reg

[Ivan Leo Puoti]

Vincent Béron wrote:
> This doesn't look like the right place to put it, especially since Wine
> can be set to something else than Win2k.

I know, I asked AJ on IRC if I could do it dynamically based on winver, but he insisted it should
be hardcoded. You're welcome to try and convince him this should be done based on winver.

Ivan.