Re: [PATCH 4/8] riched20: Implement ITextRange::GetDuplicate. (try 2)

[Huw Davies]

On Fri, Sep 12, 2014 at 08:33:42PM +0800, Jactry Zeng wrote:
> diff --git a/dlls/riched20/richole.c b/dlls/riched20/richole.c
> index a88aff2..b85ffda 100644
> --- a/dlls/riched20/richole.c
> +++ b/dlls/riched20/richole.c
> - hres = CreateITextRange(This->reOle, This->start, This->end, ppRange);
> - if(hres)
> -
>  return E_FAIL;

This isn't the way to test for failure.  Use the FAILED() macro.

Huw.

[PATCH 4/8] riched20: Implement ITextRange::GetDuplicate. (try 2)

[Jactry Zeng]

Hi Huw,
2014-09-12 21:09 GMT+08:00 Huw Davies :
> This isn't the way to test for failure.  Use the FAILED() macro.

A newer version was sent.
Thanks for your review!