On Tuesday 17 June 2003 03:42 am, Gerald Pfeifer wrote:
This patch removes an unused variable introduced by the recent changes to this file and thus avoids the following warning:
- cab_UBYTE buf[64], buf2[256] /* for modification [snip]
- cab_UBYTE buf[64] /* for modification by call back fn */ ;
Was going to use that as the user-modifiable buffer for the cabinet name in the "Next Cabinet" notification callback, which I never implemented, as it's part of the split cabinets puzzle. I promise this warning will go away with my next patch.
Sorry about that, I've been known to give others an earful for leaving warnings lying around, so I will not complain if the patch is applied, although this would create a trivial merge situation for me, as the variable will probably have to be revived again in my next patch. Also, the patch is incorrect, buf2 only, not buf, is for modification by the callback, so if we kill the variable, we should also kill the comment.
My apologies for the superfluous warning!
On Tue, 17 Jun 2003, Gregory M. Turner wrote:
This patch removes an unused variable introduced by the recent changes to this file and thus avoids the following warning:
Was going to use that as the user-modifiable buffer for the cabinet name in the "Next Cabinet" notification callback, which I never implemented, as it's part of the split cabinets puzzle. I promise this warning will go away with my next patch.
Thanks, I suppose that's sufficient. ;-)
Sorry about that, I've been known to give others an earful for leaving warnings lying around, so I will not complain if the patch is applied, although this would create a trivial merge situation for me [...] My apologies for the superfluous warning!
No drama. I just experienced, over the past few years, that many warnings indicate real portability problems (mostly to FreeBSD which I'm using) and in some cases fixing warnings also increased functionality or fixed real bugs, so whenever I have time, I trie to squeeze some warnings away.
(Of course, this certainly was not a critical one, but if there are too many of these, it's harder to find the real ones.)
Gerald
-
Gerald Pfeifer -
Gregory M. Turner