Anything wrong with this patch? (Resent version)
James Liggett
On Tue, 2005-10-11 at 17:07 -0700, James Liggett wrote:
Hi, This patch implements XEmbed system tray support for recent non-KDE desktops. This is a modified version of a patch originally submitted by Rob Shearman, rob@codeweavers.com which was based on work originally done by Mike Hearn mh@codeweavers.com
Changelog: Support XEmbed system tray protocol for tray icons
James Liggett
On 10/18/05, James Liggett jrliggett@cox.net wrote:
Anything wrong with this patch? (Resent version)
We're in a feature freeze right now till 0.9 is released. I would try submitting again after that point.
-- James Hawkins
On Tue, 2005-10-18 at 15:05 -0500, James Hawkins wrote:
On 10/18/05, James Liggett jrliggett@cox.net wrote:
Anything wrong with this patch? (Resent version)
We're in a feature freeze right now till 0.9 is released. I would try submitting again after that point.
Ok, thanks. I wasn't sure that this would be affected by the freeze, since this functionality is on the task list for 0.9. I thought I would try to get it in since it's a major usability problem for anyone who uses anything other than KDE. When will the freeze end?
Thanks, James
-- James Hawkins
On 10/18/05, James Liggett jrliggett@cox.net wrote:
Ok, thanks. I wasn't sure that this would be affected by the freeze, since this functionality is on the task list for 0.9. I thought I would try to get it in since it's a major usability problem for anyone who uses anything other than KDE. When will the freeze end?
No problem. It's always possible that Alexandre might allow it, but you'd have to ask him specifically whether it is acceptable at this point. The freeze will end when Alexandre releases 0.9, which I think will be relatively soon (probably less than a month), but again you'd have to ask him when that will be.
-- James Hawkins
Le mardi 18 octobre 2005 à 15:16 -0500, James Hawkins a écrit :
On 10/18/05, James Liggett jrliggett@cox.net wrote:
No problem. It's always possible that Alexandre might allow it, but you'd have to ask him specifically whether it is acceptable at this point. The freeze will end when Alexandre releases 0.9, which I think will be relatively soon (probably less than a month), but again you'd have to ask him when that will be.
http://bugs.winehq.org/show_bug.cgi?id=1301 is in Wine 0.9 blocker list. I guess this patch should go in before Wine 0.9 is released. (same goes for finalizing the docs); isn't it ?
On 10/18/05, Jonathan Ernst Jonathan@ernstfamily.ch wrote:
http://bugs.winehq.org/show_bug.cgi?id=1301 is in Wine 0.9 blocker list. I guess this patch should go in before Wine 0.9 is released. (same goes for finalizing the docs); isn't it ?
If you look at this as a bug, then it's possible Alexandre will accept it, but it's still up to Alexandre. I would ask him about it or see if it gets accepted in the meantime.
-- James Hawkins
Jonathan Ernst Jonathan@ErnstFamily.ch writes:
http://bugs.winehq.org/show_bug.cgi?id=1301 is in Wine 0.9 blocker list. I guess this patch should go in before Wine 0.9 is released. (same goes for finalizing the docs); isn't it ?
I'm afraid it's too big a change to get in at this point. Besides, there are still problems with that patch.
Hi,
On Wed, Oct 19, 2005 at 02:33:02PM +0200, Alexandre Julliard wrote:
Jonathan Ernst Jonathan@ErnstFamily.ch writes:
http://bugs.winehq.org/show_bug.cgi?id=1301 is in Wine 0.9 blocker list. I guess this patch should go in before Wine 0.9 is released. (same goes for finalizing the docs); isn't it ?
I'm afraid it's too big a change to get in at this point. Besides, there are still problems with that patch.
I guess I have to disagree here. Proper systray support is a VERY user-visible element, as such Wine should do everything humanly possible to try to get it included in a pretty well-working way before 0.9 ships.
But then I don't know what's involved here in getting this patch done in a good way, I'm just stating that I think that it's really important. (this stuff has been missing for far too long anyway - and I've been unsuccessfully submitting some systray patches some time ago, too)
Some people would also say that it'd be a *really* lame 0.9 release if Wine wasn't even able to properly dock a tiny icon within pre-existing and properly working desktop mechanisms...
Andreas Mohr
On Wed, 2005-10-19 at 15:51 +0200, Andreas Mohr wrote:
Hi,
On Wed, Oct 19, 2005 at 02:33:02PM +0200, Alexandre Julliard wrote:
Jonathan Ernst Jonathan@ErnstFamily.ch writes:
http://bugs.winehq.org/show_bug.cgi?id=1301 is in Wine 0.9 blocker list. I guess this patch should go in before Wine 0.9 is released. (same goes for finalizing the docs); isn't it ?
I'm afraid it's too big a change to get in at this point. Besides, there are still problems with that patch.
I guess I have to disagree here. Proper systray support is a VERY user-visible element, as such Wine should do everything humanly possible to try to get it included in a pretty well-working way before 0.9 ships.
I agree with you here. This fix is a must for anyone who uses systray-enabled apps. I personally use such programs daily, and I think the lack of this support is a *big* problem.
But then I don't know what's involved here in getting this patch done in a good way, I'm just stating that I think that it's really important. (this stuff has been missing for far too long anyway - and I've been unsuccessfully submitting some systray patches some time ago, too)
Well, its not exactly a picnic ;-) The original patch had some stack problems, which I believe I've fixed. Also, each desktop implements this standard differently, so a lot of weird disparities can occur. It works with some odd quirks in GNOME (sometimes icons won't dock, other times the Wine-Systray window shows up for no reason at all) I'm not sure why this is, but it has been suggested that this is a bug in their notification area applet, and I have to agree. The patch works great, as I've said previously, in XFce and IceWM.
Some people would also say that it'd be a *really* lame 0.9 release if Wine wasn't even able to properly dock a tiny icon within pre-existing and properly working desktop mechanisms...
Yeah, I'm one of them... I always thought that was lame. :)
James
I'm afraid it's too big a change to get in at this point. Besides,
there are still problems with that patch.
Which problems are you referring to? It's true that there are some issues with it, but those (at least in my testing anyway) are limited to Gnome. With other desktops, such as XFce and IceWM, the patch works perfectly. As such, I think this shows some sort of bug in Gnome that can't really be fixed with Wine. There were also some problems caused by stack corruption in the original patch, but I've fixed those in this patch.
James
On Wed, 2005-10-19 at 14:33 +0200, Alexandre Julliard wrote:
I'm afraid it's too big a change to get in at this point. Besides, there are still problems with that patch.
Now that 0.9 is released and the freeze is over, can you please tell me what the problems are so I can fix them?
Thanks, James
could you please send a new patch as per latest cvs or 0.9 I would like to test this patch. with 0.9 its not applying properly Thanks, Vijay
On 10/27/05, James Liggett jrliggett@cox.net wrote:
On Wed, 2005-10-19 at 14:33 +0200, Alexandre Julliard wrote:
I'm afraid it's too big a change to get in at this point. Besides, there are still problems with that patch.
Now that 0.9 is released and the freeze is over, can you please tell me what the problems are so I can fix them?
Thanks, James
Ok I created some new patches. (I decided to break it up this time. They can be applied in any order) Thanks for helping test this! :) If you have any feedback, please let me know...If they work out OK I will post them to wine-patches again.
James
On Wed, 2005-11-09 at 11:07 +0530, Vijay Kiran Kamuju wrote:
could you please send a new patch as per latest cvs or 0.9 I would like to test this patch. with 0.9 its not applying properly Thanks, Vijay
On 10/27/05, James Liggett jrliggett@cox.net wrote:
On Wed, 2005-10-19 at 14:33 +0200, Alexandre Julliard wrote:
I'm afraid it's too big a change to get in at this point. Besides, there are still problems with that patch.
Now that 0.9 is released and the freeze is over, can you please tell me what the problems are so I can fix them?
Thanks, James
-
Alexandre Julliard -
Andreas Mohr -
James Hawkins -
James Liggett -
Jonathan Ernst -
Vijay Kiran Kamuju