re: dnsapi: Use internal name_skip function

[Dan Kegel]

Hi André,
your patch failed to build on an ubuntu 10.04 system here:

ccache gcc -c -I. -I. -I../../../include -I../../../include
-DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION  -D_REENTRANT
-fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement
-Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings
-Wpointer-arith -Wlogical-op  -g -O0 -Werror  -o name.o name.c
In file included from ns_parse.c:39:
../../include/winbase.h:1583: error: expected declaration specifiers
or ‘...’ before ‘va_list’
../../include/winbase.h:1584: error: expected declaration specifiers
or ‘...’ before ‘va_list’
make[1]: *** [ns_parse.o] Error 1

Inserting
#include <stdarg.h>
before including winbase.h makes the compiler happy.
- Dan

---------- Forwarded message ----------
From:  
Date: Tue, Sep 6, 2011 at 3:41 PM
Subject: Re: 78446: Subject: dnsapi: Use internal name_skip function
To: [e-mail], [e-mail]

This is an experimental automated build and test service.
Please feel free to ignore this email while we work the kinks out.

The Buildbot has detected a failed build on builder runtests-heaptest
while building Wine.
Full details are available at:
http://buildbot.kegel.com/builders/runtests-heaptest/builds/13 (though
maybe not for long, as I'm still reinstalling the buildbot
periodically while experimenting)
BUILD FAILED: failed shell_2

For more info about this message, see http://wiki.winehq.org/BuildBot

dnsapi: Use internal name_skip function

[Austin English]

2011/9/6 Dan Kegel :
> Hi André,
> your patch failed to build on an ubuntu 10.04 system here:
>
> ccache gcc -c -I. -I. -I../../../include -I../../../include
> -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION  -D_REENTRANT
> -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement
> -Wempty-body -Wstrict-prototypes -Wtype-limits -Wwrite-strings
> -Wpointer-arith -Wlogical-op  -g -O0 -Werror  -o name.o name.c
> In file included from ns_parse.c:39:
> ../../include/winbase.h:1583: error: expected declaration specifiers
> or ‘...’ before ‘va_list’
> ../../include/winbase.h:1584: error: expected declaration specifiers
> or ‘...’ before ‘va_list’
> make[1]: *** [ns_parse.o] Error 1
>
> Inserting
> #include <stdarg.h>
> before including winbase.h makes the compiler happy.
> - Dan

The same on Alpine Linux (where the patch was meant to help).

After including stdarg.h, the original failure goes away.