Re: [v2 1/3] ntdll: Define more file information classes.

[Sebastian Lackner]

On 26.01.2017 12:09, Jonathan Doron wrote:
> Signed-off-by: Jonathan Doron
>
> dlls/ntdll/file.c  | 7 +++++++
>  include/winternl.h | 7 +++++++
>  2 files changed, 14 insertions(+)
>
> diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c
> index e1583da..6eddd19 100644
> --- a/dlls/ntdll/file.c
> +++ b/dlls/ntdll/file.c
> @@ -2376,7 +2376,14 @@ NTSTATUS WINAPI NtQueryInformationFile( HANDLE hFile, PIO_STATUS_BLOCK io,
>          0,                                             /* FileNumaNodeInformation */
>          0,                                             /* FileStandardLinkInformation */
>          0,                                             /* FileRemoteProtocolInformation */
> -
>    0,                                             /* FileRenameInformationBypassAccessCheck */
> -
>    0,                                             /* FileLinkInformationBypassAccessCheck */
> -
>    0,                                             /* FileVolumeNameInformation */
> -
>    0,                                             /* FileIdInformation */
> -
>    0,                                             /* FileIdExtdDirectoryInformation */
>    0,                                             /* FileReplaceCompletionInformation */
> -
>    0,                                             /* FileHardLinkFullIdInformation */
> -
>    0,                                             /* FileIdExtdBothDirectoryInformation */
>
> };
>
> struct stat st;
>
> diff --git a/include/winternl.h b/include/winternl.h
> index f35091c..891b6a7 100644
> --- a/include/winternl.h
> +++ b/include/winternl.h
> @@ -441,7 +441,14 @@ typedef enum _FILE_INFORMATION_CLASS {
>      FileNumaNodeInformation,
>      FileStandardLinkInformation,
>      FileRemoteProtocolInformation,
> - FileRenameInformationBypassAccessCheck,
> - FileLinkInformationBypassAccessCheck,
> - FileVolumeNameInformation,
> - FileIdInformation,
> - FileIdExtdDirectoryInformation,
> FileReplaceCompletionInformation,
> - FileHardLinkFullIdInformation,
> - FileIdExtdBothDirectoryInformation,
> FileMaximumInformation

It looks like the FileMaximumInformation constant is also used in the ntdll/directory tests.
Unfortunately, your patch introduces new test failures (not catched automatically because
include file changes do not trigger test runs): https://newtestbot.winehq.org/JobDetails.pl?Key=28259.
You will have to update those files in the same patch to ensure all tests still pass.

Best regards,
Sebastian
> } FILE_INFORMATION_CLASS, *PFILE_INFORMATION_CLASS;