-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2014-02-11 12:14, schrieb Martin Storsjo:
I420 is similar to YV12, but the chroma planes are swapped.
Do you have an application that uses this? Just making sure we're not adding dead code here.
Otherwise this looks good, but patch 3 needs fixes.
On Wed, 12 Feb 2014, Stefan Dösinger wrote:
Am 2014-02-11 12:14, schrieb Martin Storsjo:
I420 is similar to YV12, but the chroma planes are swapped.
Do you have an application that uses this? Just making sure we're not adding dead code here.
Actually I don't. I first ran into this area with the OpenH264 test decoding application, which currently uses NV12 textures. Once I started adding support for that to wine, I also tested what other common YUV pixel formats actual hardware supports (I tested on a friend's physical windows machine), which wine doesn't, and found that the real windows machine also supported I420 but not e.g. NV21, in addition to YV12, UYVY and YUY2 which already were supported.
I can easily change the above mentioned test app to use I420, which works both on the physical windows machine and in wine with this patch, but I can't name any other app off-hand which would use this format. So if you prefer to hold off adding support for this format until there's a concrete need, I can drop this one.
// Martin
On 12 February 2014 16:50, Martin Storsjö martin@martin.st wrote:
I can easily change the above mentioned test app to use I420, which works both on the physical windows machine and in wine with this patch, but I can't name any other app off-hand which would use this format. So if you prefer to hold off adding support for this format until there's a concrete need, I can drop this one.
Just for what it's worth, I420 appears to be unsupported on my Win 7 test machine with AMD GPU.
On Wed, 12 Feb 2014, Henri Verbeet wrote:
On 12 February 2014 16:50, Martin Storsjö martin@martin.st wrote:
I can easily change the above mentioned test app to use I420, which works both on the physical windows machine and in wine with this patch, but I can't name any other app off-hand which would use this format. So if you prefer to hold off adding support for this format until there's a concrete need, I can drop this one.
Just for what it's worth, I420 appears to be unsupported on my Win 7 test machine with AMD GPU.
Right - FWIW the machine where it was supported was a Samsung Np940x3g-k03se with Windows 8.1.
Anyway, I guess that's another reason to drop this patch for now until there's some actual need for it.
// Martin
-
Henri Verbeet -
Martin Storsjö -
Stefan Dösinger