Re: PATCH: include mess up

[Francois Gouget]

On Tue, 10 Jul 2001, Marcus Meissner wrote:
> Hi,
>
> There is some bad recursion when including objbase.h in non-WINE programs.
> This fixes that problem, by using winbase.h instead of windows.h.

Yes but rpc.h is supposed to include 'windows.h', not 'winbase.h'.
The correct fix must be elsewhere.
   What is the recursion that happens and which include statement (in
your application) triggers it?

--
Francois Gouget         [e-mail]        http://fgouget.free.fr/
                     Linux: the choice of a GNU generation

PATCH: include mess up

[Marcus Meissner]

On Tue, Jul 10, 2001 at 04:01:55PM -0700, Francois Gouget wrote:
> On Tue, 10 Jul 2001, Marcus Meissner wrote:
> > Hi,
> >
> > There is some bad recursion when including objbase.h in non-WINE programs.
> > This fixes that problem, by using winbase.h instead of windows.h.
>
> Yes but rpc.h is supposed to include 'windows.h', not 'winbase.h'.
> The correct fix must be elsewhere.
>    What is the recursion that happens and which include statement (in
> your application) triggers it?

I am just trying to compile shdocvw out of the tree and get following
error. (You should basically be able to reproduce it by compiling shdocvw
with out __WINE__ defined.)

/bin/sh ../../../libtool --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -I/opt/kde2/include -I/usr/lib/qt2/include -I/usr/X11R6/include  -I/usr/X11R6/include/X11/mesa -I./../tools -I/home/marcus/wine/include     -c persist.c
gcc -DHAVE_CONFIG_H -I. -I. -I../../.. -I/opt/kde2/include -I/usr/lib/qt2/include -I/usr/X11R6/include -I/usr/X11R6/include/X11/mesa -I./../tools -I/home/marcus/wine/include -Wp,-MD,.deps/persist.pp -c persist.c  -fPIC -DPIC -o .libs/persist.o
In file included from /home/marcus/wine/include/objidl.h:10,
                 from /home/marcus/wine/include/oaidl.h:5,
                 from /home/marcus/wine/include/oleauto.h:10,
                 from /home/marcus/wine/include/ole2.h:22,
                 from /home/marcus/wine/include/windows.h:51,
                 from /home/marcus/wine/include/rpc.h:9,
                 from /home/marcus/wine/include/unknwn.h:4,
                 from /home/marcus/wine/include/objbase.h:7,
                 from shdocvw.h:16,
                 from persist.c:8:
/home/marcus/wine/include/wine/obj_clientserver.h:198: parse error before `RPC_AUTH_IDENTITY_HANDLE'
/home/marcus/wine/include/wine/obj_clientserver.h:201: parse error before `RPC_AUTH_IDENTITY_HANDLE'
/home/marcus/wine/include/wine/obj_clientserver.h:215: parse error before `RPC_AUTHZ_HANDLE'
persist.c:10: warning: parameter names (without types) in function declaration
persist.c:10: warning: data definition has no type or storage class
make: *** [persist.lo] Error 1

RPC_AUTH_IDENTITY_HANDLE is getting defined in the includes later, but gets
used due to the windows.h include including lots of other stuff.

Ciao, Marcus