Re: New Spanish translations [1/4]: dlls/hhctrl.ocx

[Paul Vriens]

On 02/11/2010 02:36 PM, José Manuel Ferrer Ortiz wrote:
> As requested, I'll resend these patches, splitting them one message per
> module. This way it looks a lot more professional :D
>
> I've also fixed a few things that were wrong or could be better:
> - Switched to UTF-8 encoding, and added the required 'pragma'.
> - Changed language to SUBLANG_NEUTRAL.
>
> Thank you, Nikolay, for making me aware of these mistakes.
>
> Regards,
> José Manuel

Hi José,

Your patches don't apply. See:

http://source.winehq.org/patches/

I've spotted two issues:

1. Patches should be generated from the top-level.
2. As these are new files you also need changes to the corresponding 
Makefile.in file.

New Spanish translations [1/4]: dlls/hhctrl.ocx

[Paul Vriens]

On 02/12/2010 04:41 PM, Paul Vriens wrote:
> On 02/11/2010 02:36 PM, José Manuel Ferrer Ortiz wrote:
> > As requested, I'll resend these patches, splitting them one message per
> > module. This way it looks a lot more professional :D
> >
> > I've also fixed a few things that were wrong or could be better:
> > - Switched to UTF-8 encoding, and added the required 'pragma'.
> > - Changed language to SUBLANG_NEUTRAL.
> >
> > Thank you, Nikolay, for making me aware of these mistakes.
> >
> > Regards,
> > José Manuel
>
> Hi José,
>
> Your patches don't apply. See:
>
> http://source.winehq.org/patches/
>
> I've spotted two issues:
> - Patches should be generated from the top-level.
> - As these are new files you also need changes to the corresponding
>
> Makefile.in file.

Just saw that your original patches where created from the top-level. I 
guess it's due to the patchwatcher site disliking non Git patches?

New Spanish translations [1/4]: dlls/hhctrl.ocx

[Alexandre Julliard]

Paul Vriens  writes:
> Just saw that your original patches where created from the
> top-level. I guess it's due to the patchwatcher site disliking non Git
> patches?

Yes, the filtering script has some issues with non-git patches that only
create new files. I put in some fixes, but using git patches when adding
files is strongly recommended.