Re: comctl32: correct handling of toolbar separators' size

[Rob Shearman]

2009/3/17 Igor Tarasov :
> Currently, wine uses iBitmap property for determining toolbar
> separators width all the time, stating it's an undocumented feature.
> This is not correct.
>
> According to MSDN, iBitmap is used only on inserting separator (since
> there is no cx field in TBBUTTON structure).
> http://msdn.microsoft.com/en-us/library/bb760476(VS.85).aspx
>
> In other cases, cx property that can be updated via get/set buttoninfo
> is used, as tests show. Also, tests show that this property differs
> from zero only if application specifically sets. Setting it to 0 makes
> separator display in default width. All this is implemented in this
> patch. More tests results in bugtracker (link below).

Please ensure that there are no regressions in the display of IE6's
toolbars after this patch. This is the main user of undocumented
toolbar features.
> @@ -4428,7 +4431,7 @@ TOOLBAR_SetButtonInfoA (HWND hwnd, WPARAM wParam, LPARAM lParam)
>      if (lptbbi->dwMask & TBIF_LPARAM)
>         btnPtr->dwData = lptbbi->lParam;
>      if (lptbbi->dwMask & TBIF_SIZE)
> -
>   btnPtr->cx = lptbbi->cx;
> -
>    btnPtr->cx = lptbbi->cx;
> if (lptbbi->dwMask & TBIF_STATE)
>       btnPtr->fsState = lptbbi->fsState;
>    if (lptbbi->dwMask & TBIF_STYLE)

Whitespace only changes shouldn't be included in patches with other changes.

comctl32: correct handling of toolbar separators' size

[Igor Tarasov]

> Please ensure that there are no regressions in the display of IE6's
> toolbars after this patch. This is the main user of undocumented
> toolbar features.

How can I do that?
> > - btnPtr->cx = lptbbi->cx;
> > - btnPtr->cx = lptbbi->cx;
>
> Whitespace only changes shouldn't be included in patches with other changes.

Oups, my mistake. ;)

--
Igor

comctl32: correct handling of toolbar separators' size

[Rob Shearman]

2009/3/18 Igor Tarasov :
> > Please ensure that there are no regressions in the display of IE6's
> > toolbars after this patch. This is the main user of undocumented
> > toolbar features.
>
> How can I do that?

Follow the how-to here:
http://appdb.winehq.org/objectManager.php?sClass=version&iId=469

However, I don't know if IE6 currently installs or works in Wine.

comctl32: correct handling of toolbar separators' size

[Igor Tarasov]

2009/3/18 Rob Shearman :
> 2009/3/18 Igor Tarasov :
> > > Please ensure that there are no regressions in the display of IE6's
> > > toolbars after this patch. This is the main user of undocumented
> > > toolbar features.

Installed IE6, tested both version (with my patch and without it).
Image is pixel-perfect, no bugs or glitches (though separators here
are 6 px only, which differs from wine's default 8). Is that enough
for regression testing?

P.S: I was testing it with both my patches applied.

--
Igor

comctl32: correct handling of toolbar separators' size

[Rob Shearman]

2009/3/18 Igor Tarasov :
> 2009/3/18 Rob Shearman :
> > 2009/3/18 Igor Tarasov :
> > > > Please ensure that there are no regressions in the display of IE6's
> > > > toolbars after this patch. This is the main user of undocumented
> > > > toolbar features.
>
> Installed IE6, tested both version (with my patch and without it).
> Image is pixel-perfect, no bugs or glitches (though separators here
> are 6 px only, which differs from wine's default 8). Is that enough
> for regression testing?
>
> P.S: I was testing it with both my patches applied.

Sounds good. Thanks for testing.