Re: COMCTL32: Fix InitCommonControlsEx prototype

[Mike McCormack]

Thomas Weidenmueller wrote:
> BOOL WINAPI
> -InitCommonControlsEx (LPINITCOMMONCONTROLSEX lpInitCtrls)
> +InitCommonControlsEx (const INITCOMMONCONTROLSEX *picce)

The version of the Windows Platform SDK that I'm looking at agrees with 
Wine.

There is also no reason to make a pointless change to the name of the 
argument, so this patch looks pointless and wrong to me.

Mike

COMCTL32: Fix InitCommonControlsEx prototype

[Thomas Weidenmueller]

Mike McCormack wrote:
> The version of the Windows Platform SDK that I'm looking at agrees
> with Wine.

This is how it is defined in the latest public platform SDK (Windows SDK
v6.0).
> There is also no reason to make a pointless change to the name of the
> argument, so this patch looks pointless and wrong to me.

While the name of the parameter is irrelevant, I picked the one used in
the PSDK definition to make the implementation more readable when using
the latest PSDK documentation.

- Thomas

COMCTL32: Fix InitCommonControlsEx prototype

[Thomas Weidenmueller]

Mike McCormack wrote:
> The version of the Windows Platform SDK that I'm looking at agrees
> with Wine.

This is how it is defined in the latest public platform SDK (Windows SDK
v6.0).
> There is also no reason to make a pointless change to the name of the
> argument, so this patch looks pointless and wrong to me.

While the name of the parameter is irrelevant, I picked the one used in
the PSDK definition to make the implementation more readable when using
the latest PSDK documentation.

- Thomas

COMCTL32: Fix InitCommonControlsEx prototype

[Evil Jay]

MSDN agrees with the specification that the data should be constant: 
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pla...

Mike McCormack wrote:
> Thomas Weidenmueller wrote:
> > BOOL WINAPI
> > -InitCommonControlsEx (LPINITCOMMONCONTROLSEX lpInitCtrls)
> > +InitCommonControlsEx (const INITCOMMONCONTROLSEX *picce)
>
> The version of the Windows Platform SDK that I'm looking at agrees
> with Wine.
>
> There is also no reason to make a pointless change to the name of the
> argument, so this patch looks pointless and wrong to me.
>
> Mike

COMCTL32: Fix InitCommonControlsEx prototype

[Francois Gouget]

On Fri, 19 Jan 2007, Mike McCormack wrote:
> Thomas Weidenmueller wrote:
> > BOOL WINAPI
> > -InitCommonControlsEx (LPINITCOMMONCONTROLSEX lpInitCtrls)
> > +InitCommonControlsEx (const INITCOMMONCONTROLSEX *picce)
>
> The version of the Windows Platform SDK that I'm looking at agrees with Wine.

Microsoft has done a lot of work to make their headers more 
const-correct in the latest SDK (which I will identify as 
VistaSDK-6.0.6000.0.0-20061107 just to add to the naming confusion).

There's quite a lot of work to update the Wine headers to match. I also 
wonder on the impact it may have on the past and current 'cast qual 
fixes' work...