Since fc14753dc0188a52a05243d5d82c4062b93daaff the wine virtual desktop window doesn't have a title anymore. This commit fixes this.
This is needed because DesktopWndProc ignores the WM_SETTEXT message. Alternative would be handling WM_SETTEXT in DesktopWndProc.
Signed-off-by: Fabian Maurer dark.shadow4@web.de --- programs/explorer/desktop.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/programs/explorer/desktop.c b/programs/explorer/desktop.c index 4f47ad0d36b..97bc9e40a6b 100644 --- a/programs/explorer/desktop.c +++ b/programs/explorer/desktop.c @@ -662,6 +662,9 @@ static LRESULT WINAPI desktop_wnd_proc( HWND hwnd, UINT message, WPARAM wp, LPAR EndPaint( hwnd, &ps ); } return 0; + + case WM_SETTEXT: + return DefWindowProcW( hwnd, message, wp, lp ); }
return desktop_orig_wndproc( hwnd, message, wp, lp );
On 07/12/2018 10:53 PM, Fabian Maurer wrote:
Since fc14753dc0188a52a05243d5d82c4062b93daaff the wine virtual desktop window doesn't have a title anymore. This commit fixes this.
This is needed because DesktopWndProc ignores the WM_SETTEXT message. Alternative would be handling WM_SETTEXT in DesktopWndProc.
Signed-off-by: Fabian Maurer dark.shadow4@web.de
programs/explorer/desktop.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/programs/explorer/desktop.c b/programs/explorer/desktop.c index 4f47ad0d36b..97bc9e40a6b 100644 --- a/programs/explorer/desktop.c +++ b/programs/explorer/desktop.c @@ -662,6 +662,9 @@ static LRESULT WINAPI desktop_wnd_proc( HWND hwnd, UINT message, WPARAM wp, LPAR EndPaint( hwnd, &ps ); } return 0;
case WM_SETTEXT:
return DefWindowProcW( hwnd, message, wp, lp ); } return desktop_orig_wndproc( hwnd, message, wp, lp );
It depends on how it works. Is it possible to set/get text using GetDesktopWindow()?
It depends on how it works. Is it possible to set/get text using GetDesktopWindow()?
That's how it's used to work, yes, and with my patch that's still possible. We used to pass the message to DefWindowProc, and with that patch we do it again.
Regards, Fabian Maurer
Fabian Maurer dark.shadow4@web.de writes:
It depends on how it works. Is it possible to set/get text using
GetDesktopWindow()?
That's how it's used to work, yes, and with my patch that's still possible.
We used to pass the message to DefWindowProc, and with that patch we do it again.
Actually we should be passing all messages to DefWindowProc.
We used to pass the message to DefWindowProc, and with that patch
we do it
again.
Actually we should be passing all messages to DefWindowProc.
This would mean reverting fc14753dc0188a52a05243d5d82c4062b93daaff, what makes me wonder why it was added in the first place.
Zebediah Figura, what did that commit fix?
Regards, Fabian Maurer
Any update on this? Right know I have conflicting information, and I'm not sure on how to proceed.
Fabian Maurer
-
Alexandre Julliard -
Fabian Maurer -
Nikolay Sivov