On 3 February 2011 01:00, Tobias Jakobi liquid.acid@gmx.net wrote:
*bumping*
This patch never went into master, although it's _very_ important. Wine users see a lot of D3D problems (mostly missing textures) since mesa drivers don't support s3tc "out-of-the-box" (libtxc_dxtn needs to be available). This leads to a lot of 'false' bug reports, which are in fact driver issues.
Requesting to finally push this to master.
I'm not entirely sure on how to do this properly. Making it an ERR would be too loud for applications that never use s3tc textures, as a WARN it's never going to be seen unless you look at the debug channel. Printing a message in wined3d in CreateSurface() would probably work, but the resulting check would end up being pretty ugly because we'd have to check 5 different formats. You can't do much more than a WARN for a generic check either, because some formats may be legitimately missing / unimplemented. Note that the situation with floating point formats isn't much better.
I'm not entirely sure on how to do this properly. Making it an ERR would be too loud for applications that never use s3tc textures, as a WARN it's never going to be seen unless you look at the debug channel. Printing a message in wined3d in CreateSurface() would probably work, but the resulting check would end up being pretty ugly because we'd have to check 5 different formats. You can't do much more than a WARN for a generic check either, because some formats may be legitimately missing / unimplemented. Note that the situation with floating point formats isn't much better.
I'd say go with a WARN then. At least we've something then. The current situation is just not acceptable, since a lot of games ship precompressed textures in DDS format and just expect them to work. If this works for native D3D impl then it should work here too. Or at least we should warn the user that something might go wrong.
Maybe we should also add some entry to the wiki ('Setting up open-source drivers for wine') and mention the current issues (s3tc support in general, complete lack of s3tc support in r600g, etc.)
Greets, Tobias
-
Henri Verbeet -
Tobias Jakobi