[PATCH v3 1/4] winmm/tests: Expect TIME_BYTES format for TIME_MS request. - wine-devel - winehq.org

List overview All Threads

[PATCH v3 1/4] winmm/tests: Expect TIME_BYTES format for TIME_MS request.

[PATCH v3 2/4] winmm: Get rid of...

[PATCH] msxml3: Implement mxwriter...

Akihiro Sagawa

20 Jan 2021 20 Jan '21

1:23 p.m.

In v3, - keep existing tests. - don't touch time_to_bytes() since it's also used in capture.c.

Signed-off-by: Akihiro Sagawa sagawa.aki@gmail.com --- dlls/winmm/tests/wave.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)

Attachments:

v3-0001-winmm-tests-Expect-TIME_BYTES-format-for-TIME_MS-.patch (text/x-patch — 1.2 KB)

Show replies by date

Marvin

20 Jan 20 Jan

1:51 p.m.

Hi,

While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?

Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=84280

Your paranoid android.

=== w1064v1809 (32 bit report) ===

winmm: wave.c:525: Test failed: waveOutGetPosition(WAVE_MAPPER): TIME_MS test failed

=== w1064 (32 bit report) ===

winmm: wave.c:525: Test failed: waveOutGetPosition(WAVE_MAPPER): TIME_MS test failed

=== w10pro64 (32 bit report) ===

winmm: wave.c:525: Test failed: waveOutGetPosition(WAVE_MAPPER): TIME_MS test failed wave.c:800: Test failed: missing WOM_DONE notification wave.c:525: Test failed: waveOutGetPosition(WAVE_MAPPER): TIME_MS test failed

=== w1064v1809 (64 bit report) ===

winmm: wave.c:525: Test failed: waveOutGetPosition(WAVE_MAPPER): TIME_MS test failed wave.c:800: Test failed: missing WOM_DONE notification wave.c:800: Test failed: missing WOM_DONE notification wave.c:800: Test failed: missing WOM_DONE notification wave.c:800: Test failed: missing WOM_DONE notification wave.c:800: Test failed: missing WOM_DONE notification wave.c:800: Test failed: missing WOM_DONE notification wave.c:800: Test failed: missing WOM_DONE notification wave.c:800: Test failed: missing WOM_DONE notification wave.c:800: Test failed: missing WOM_DONE notification wave.c:800: Test failed: missing WOM_DONE notification wave.c:805: Test failed: (00) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (01) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (02) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (03) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (04) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (05) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (06) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (07) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (08) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (09) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:502: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 bytes, should be 17640 wave.c:513: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1377 samples (1377 bytes), should be 17640 (17640 bytes) wave.c:525: Test failed: waveOutGetPosition(WAVE_MAPPER): TIME_MS test failed wave.c:536: Test failed: waveOutGetPosition(WAVE_MAPPER): SMPTE test failed wave.c:547: Test failed: waveOutGetPosition(WAVE_MAPPER): MIDI test failed wave.c:558: Test failed: waveOutGetPosition(WAVE_MAPPER): TICKS test failed wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:821: Test failed: dwFlags(-1)=12 wave.c:825: Test failed: waveOutUnprepareHeader(-1): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:826: Test failed: dwFlags(-1)=13 wave.c:831: Test failed: dwFlags(-1)=13 wave.c:836: Test failed: dwFlags(-1)=13 wave.c:844: Test failed: waveOutClose(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave: Timeout

=== w1064_2qxl (64 bit report) ===

winmm: wave.c:805: Test failed: (00) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:502: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 2238 bytes, should be 13230 wave.c:513: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 2238 samples (2238 bytes), should be 13230 (13230 bytes) wave.c:525: Test failed: waveOutGetPosition(WAVE_MAPPER): TIME_MS test failed wave.c:536: Test failed: waveOutGetPosition(WAVE_MAPPER): SMPTE test failed wave.c:547: Test failed: waveOutGetPosition(WAVE_MAPPER): MIDI test failed wave.c:558: Test failed: waveOutGetPosition(WAVE_MAPPER): TICKS test failed wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:821: Test failed: dwFlags(-1)=12 wave.c:825: Test failed: waveOutUnprepareHeader(-1): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:826: Test failed: dwFlags(-1)=13 wave.c:831: Test failed: dwFlags(-1)=13 wave.c:836: Test failed: dwFlags(-1)=13 wave.c:844: Test failed: waveOutClose(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:805: Test failed: (00) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:502: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 13230 wave.c:513: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 samples (1356 bytes), should be 13230 (13230 bytes) wave.c:525: Test failed: waveOutGetPosition(WAVE_MAPPER): TIME_MS test failed wave.c:536: Test failed: waveOutGetPosition(WAVE_MAPPER): SMPTE test failed wave.c:547: Test failed: waveOutGetPosition(WAVE_MAPPER): MIDI test failed wave.c:558: Test failed: waveOutGetPosition(WAVE_MAPPER): TICKS test failed wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:821: Test failed: dwFlags(-1)=12 wave.c:825: Test failed: waveOutUnprepareHeader(-1): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:826: Test failed: dwFlags(-1)=13 wave.c:831: Test failed: dwFlags(-1)=13 wave.c:836: Test failed: dwFlags(-1)=13 wave.c:844: Test failed: waveOutClose(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:796: Test failed: waveOutWrite(WAVE_MAPPER, header[0]): rc=WAVERR_STILLPLAYING(Cannot perform this operation while media data is still playing. Reset the device, or wait until the data is finished playing.) wave.c:800: Test failed: missing WOM_DONE notification wave.c:800: Test failed: missing WOM_DONE notification wave.c:502: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 22050 wave.c:513: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 samples (1356 bytes), should be 22050 (22050 bytes) wave.c:525: Test failed: waveOutGetPosition(WAVE_MAPPER): TIME_MS test failed

=== w10pro64 (64 bit report) ===

winmm: wave.c:525: Test failed: waveOutGetPosition(WAVE_MAPPER): TIME_MS test failed

=== w10pro64_zh_CN (64 bit report) ===

winmm: wave.c:805: Test failed: (05) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (06) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (07) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (08) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:805: Test failed: (09) WHDR_DONE WHDR_PREPARED expected, got WHDR_INQUEUE WHDR_PREPARED wave.c:502: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 bytes, should be 17640 wave.c:513: Test failed: waveOutGetPosition(WAVE_MAPPER): returned 1356 samples (1356 bytes), should be 17640 (17640 bytes) wave.c:525: Test failed: waveOutGetPosition(WAVE_MAPPER): TIME_MS test failed wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(²¥·ÅÃœÌåÊýŸÝÊ±£¬ÎÞ·šÖŽÐÐÕâÏî²Ù×÷¡£ÇëÖØÖÃžÃÉè±ž£¬»òµÈµœÊýŸÝ²¥·ÅÍê±ÏÔÙÖŽÐÐ¡£) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(²¥·ÅÃœÌåÊýŸÝÊ±£¬ÎÞ·šÖŽÐÐÕâÏî²Ù×÷¡£ÇëÖØÖÃžÃÉè±ž£¬»òµÈµœÊýŸÝ²¥·ÅÍê±ÏÔÙÖŽÐÐ¡£) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(²¥·ÅÃœÌåÊýŸÝÊ±£¬ÎÞ·šÖŽÐÐÕâÏî²Ù×÷¡£ÇëÖØÖÃžÃÉè±ž£¬»òµÈµœÊýŸÝ²¥·ÅÍê±ÏÔÙÖŽÐÐ¡£) wave.c:816: Test failed: waveOutUnprepareHeader(WAVE_MAPPER): rc=WAVERR_STILLPLAYING(²¥·ÅÃœÌåÊýŸÝÊ±£¬ÎÞ·šÖŽÐÐÕâÏî²Ù×÷¡£ÇëÖØÖÃžÃÉè±ž£¬»òµÈµœÊýŸÝ²¥·ÅÍê±ÏÔÙÖŽÐÐ¡£)

Andrew Eikum

21 Jan 21 Jan

8:41 p.m.

Signed-off-by: Andrew Eikum aeikum@codeweavers.com

On Wed, Jan 20, 2021 at 10:23:40PM +0900, Akihiro Sagawa wrote:

In v3,

keep existing tests.

don't touch time_to_bytes() since it's also used in capture.c.

Signed-off-by: Akihiro Sagawa sagawa.aki@gmail.com

dlls/winmm/tests/wave.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/dlls/winmm/tests/wave.c b/dlls/winmm/tests/wave.c index 819489e5566..079a497dd0b 100644 --- a/dlls/winmm/tests/wave.c +++ b/dlls/winmm/tests/wave.c @@ -519,14 +519,11 @@ static void check_position(int device, HWAVEOUT wout, DWORD bytes, rc=waveOutGetPosition(wout, &mmtime, sizeof(mmtime)); ok(rc==MMSYSERR_NOERROR, "waveOutGetPosition(%s): rc=%s\n",dev_name(device),wave_out_error(rc));
if (mmtime.wType != TIME_MS && winetest_debug > 1)
   trace("waveOutGetPosition(%s): TIME_MS not supported, returned %s\n",
         dev_name(device), wave_time_format(mmtime.wType));
todo_wine ok(mmtime.wType == TIME_BYTES, "(waveOutGetPosition(%s): returned %s\n",
  dev_name(device), wave_time_format(mmtime.wType));
returned = time_to_bytes(&mmtime, pwfx);
ok(returned == bytes, "waveOutGetPosition(%s): returned %d ms, "
  "(%d bytes), should be %d (%d bytes)\n", dev_name(device),
  bytes_to_ms(returned, pwfx), returned,
  bytes_to_ms(bytes, pwfx), bytes);
ok(returned == bytes, "waveOutGetPosition(%s): TIME_MS test failed\n",
  dev_name(device));
mmtime.wType = TIME_SMPTE; rc=waveOutGetPosition(wout, &mmtime, sizeof(mmtime));

1614

Age (days ago)

1615

Last active (days ago)

wine-devel@winehq.org

2 comments

3 participants

tags (0)

participants (3)

Akihiro Sagawa
Andrew Eikum
Marvin