Re: [PATCH 1/2] comctl32/tests: Test expanding of a invisible sub tree.

[Florian Köberle]

Nikolay Sivov wrote:
> Florian Köberle wrote:
> > dlls/comctl32/tests/treeview.c |   80
> > ++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 80 insertions(+), 0 deletions(-)
> >
> > diff --git a/dlls/comctl32/tests/treeview.c
> > b/dlls/comctl32/tests/treeview.c
> > index 5f310b5..7d9fcfa 100644
> > --- a/dlls/comctl32/tests/treeview.c
> > +++ b/dlls/comctl32/tests/treeview.c
> > @@ -748,6 +748,84 @@ static LRESULT CALLBACK MyWndProc(HWND hWnd,
> > UINT msg, WPARAM wParam, LPARAM lPa
> >      return 0L;
> >  }
> >
> > +static void TestExpandInvisible(void)
> > +{
> > - static CHAR nodeRText[]  = "R",
> > -
> >            nodeIText[]  = "I",
> > -
> >            nodeIIText[] = "II",
> > -
> >            node1Text[]  = "1",
> > -
> >            node2Text[]  = "2";
>
> Why not using array here?

The code builds up a tree like this:

R
 |- I
 |  |- 1
 |  |-  2
 |- II

So the different types of enumeration are used to give a hint of the
level of the node.
If I use arrays the tree would look like this:
0
 |- 1
 |  |- 2
 |  |- 3
 |- 4

If this version of the tree is really wanted I can change it of course
to use arrays.

Do you still prefer arrays after reading my explanation?