Re: winealsa.drv: Use debugstr_guid() to trace a guid.

[Andrew Eikum]

On Fri, Aug 05, 2016 at 03:55:55PM +0200, Michael Stefaniuc wrote:
> Signed-off-by: Michael Stefaniuc
>
> dlls/winealsa.drv/mmdevdrv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c
> index 14eac39..8577e75 100644
> --- a/dlls/winealsa.drv/mmdevdrv.c
> +++ b/dlls/winealsa.drv/mmdevdrv.c
> @@ -3390,7 +3390,7 @@ static HRESULT WINAPI SimpleAudioVolume_SetMute(ISimpleAudioVolume *iface,
>      AudioSessionWrapper *This = impl_from_ISimpleAudioVolume(iface);
>      AudioSession *session = This->session;
> - TRACE("(%p)->(%u, %p)\n", session, mute, context);
> - TRACE("(%p)->(%u, %p)\n", session, mute, debugstr_guid(context));

The format on these should be changed to %s, right?

Andrew

winealsa.drv: Use debugstr_guid() to trace a guid.

[Michael Stefaniuc]

On 08/05/2016 04:06 PM, Andrew Eikum wrote:
> On Fri, Aug 05, 2016 at 03:55:55PM +0200, Michael Stefaniuc wrote:
> > Signed-off-by: Michael Stefaniuc
> >
> > dlls/winealsa.drv/mmdevdrv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c
> > index 14eac39..8577e75 100644
> > --- a/dlls/winealsa.drv/mmdevdrv.c
> > +++ b/dlls/winealsa.drv/mmdevdrv.c
> > @@ -3390,7 +3390,7 @@ static HRESULT WINAPI SimpleAudioVolume_SetMute(ISimpleAudioVolume *iface,
> >      AudioSessionWrapper *This = impl_from_ISimpleAudioVolume(iface);
> >      AudioSession *session = This->session;
> > - TRACE("(%p)->(%u, %p)\n", session, mute, context);
> > - TRACE("(%p)->(%u, %p)\n", session, mute, debugstr_guid(context));
>
> The format on these should be changed to %s, right?

Duh... yeah. That part is manual and not generated, so I forgot in the
heat of the battle. I should switch to generate that too...

bye
    michael