Uwe Bonnes wrote:
Changelog tools/runtest Allow the use of native dlls and debugmessages (Includes " Allow native dlls in runtest")
do we really need this in the scripts ? couldn't we just use the WINEOPTIONS from the command line ? WINEOPTIONS="-debugmsg +foo" runtest instead of what you propose runtest -d "-debugmsg +foo"
just my 2 cents A+
"Eric" == Eric Pouech eric.pouech@wanadoo.fr writes:
Eric> Uwe Bonnes wrote: >> Changelog tools/runtest Allow the use of native dlls and >> debugmessages (Includes " Allow native dlls in runtest") Eric> do we really need this in the scripts ? couldn't we just use the Eric> WINEOPTIONS from the command line ? WINEOPTIONS="-debugmsg +foo" Eric> runtest instead of what you propose runtest -d "-debugmsg +foo"
Perhaps not, if advice to the user how to do that task is clearly given.
But then you have to set and unset WINEOPTIONS quite frequently.
Bye
On Sun, 16 Feb 2003, Uwe Bonnes wrote: [...]
But then you have to set and unset WINEOPTIONS quite frequently.
Not if you type:
WINEOPTIONS="-debugmsg +foo" runtest
When you do that WINEOPTIONS is set for that command only. The only drawback is 'WINEOPTIONS' is longer to type than '-d', but with command recall who cares.
"Francois" == Francois Gouget fgouget@free.fr writes:
Francois> On Sun, 16 Feb 2003, Uwe Bonnes wrote: [...] >> But then you have to set and unset WINEOPTIONS quite frequently.
Francois> Not if you type:
Francois> WINEOPTIONS="-debugmsg +foo" runtest
Francois> When you do that WINEOPTIONS is set for that command only. The Francois> only drawback is 'WINEOPTIONS' is longer to type than '-d', Francois> but with command recall who cares.
But you need to remember WINEOPTION, how to use and what options are available and the shell syntax. The few lines added to runtest by my test relief the user of that task but also leave you the posibility to still use WINEOPTIONS.
Bye
Uwe Bonnes wrote:
"Francois" == Francois Gouget fgouget@free.fr writes:
Francois> On Sun, 16 Feb 2003, Uwe Bonnes wrote: [...] >> But then you have to set and unset WINEOPTIONS quite frequently. Francois> Not if you type: Francois> WINEOPTIONS="-debugmsg +foo" runtest Francois> When you do that WINEOPTIONS is set for that command only. The Francois> only drawback is 'WINEOPTIONS' is longer to type than '-d', Francois> but with command recall who cares.
But you need to remember WINEOPTION, how to use and what options are available and the shell syntax. The few lines added to runtest by my test relief the user of that task but also leave you the posibility to still use WINEOPTIONS.
the bad side of the patch is that the user has to know the command line option of runtest... moreover, runtest should be used in most of the cases without options it's only developpers would may do some fiddling with options at some point in time, I wouldn't be surprised either if wine drops its command line option in favor of another mechanism so I'd favor not adding too many options to runtest A+