Your patch ends in an empty sig, i.e. two dashes, which makes patch complain "patch ends in middle of a line" after finishing.
I tried your patch to see if it fixed a similar problem in Ability Office (see http://ability.com/v4/download.php ) but sadly that still fails with
fixme:urlmon:URLDownloadToCacheFileW ((nil) L"http://www.abilitydownload.com/download4/ability4_15/Ability.MSI" 0x7fd49f40 520 0 0x7fb9fae8)
On 6/28/06, Dan Kegel dank@kegel.com wrote:
Your patch ends in an empty sig, i.e. two dashes, which makes patch complain "patch ends in middle of a line" after finishing.
Hmm what version of patch are you using? All my patches have that at the end (git puts it in).
I tried your patch to see if it fixed a similar problem in Ability Office (see http://ability.com/v4/download.php ) but sadly that still fails with
fixme:urlmon:URLDownloadToCacheFileW ((nil) L"http://www.abilitydownload.com/download4/ability4_15/Ability.MSI" 0x7fd49f40 520 0 0x7fb9fae8)
I'll check it out, but I don't think that's related to my patch. This patch implements fetching remote packages that are given to MsiInstallProduct. This looks like the ability office setup is calling URLDownloadToCacheFileW itself to get the msi package before installing.
On 6/28/06, James Hawkins truiken@gmail.com wrote:
I'll check it out, but I don't think that's related to my patch. This patch implements fetching remote packages that are given to MsiInstallProduct. This looks like the ability office setup is calling URLDownloadToCacheFileW itself to get the msi package before installing.
Right, it's only related in that it's downloading a .msi, and you're downloading a .msi. The code paths are different, but if we're going to fix installers that download .msi, may as well fix this one too sometime. - Dan
-
Dan Kegel -
James Hawkins