On 20 June 2013 12:17, Stefan Dösinger stefan@codeweavers.com wrote:
/* Light state */ DWORD material;
- DWORD dummy_rs_lighting;
Considering the render state doesn't exist in early ddraw versions, do we really care that its value is preserved? It seems unlikely that anything except our tests would depend on it.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2013-06-20 13:02, schrieb Henri Verbeet:
On 20 June 2013 12:17, Stefan Dösinger stefan@codeweavers.com wrote:
/* Light state */ DWORD material; + DWORD dummy_rs_lighting;
Considering the render state doesn't exist in early ddraw versions, do we really care that its value is preserved? It seems unlikely that anything except our tests would depend on it.
I don't know any application that depends on this. It just seemed like an interesting thing to test to see how far the interaction between the different APIs goes.
Just to make sure I understand you correctly: You're saying that the test should still call SetRenderState(LIGHTING), check the initial value, and GetRenderState(LIGHTING) should return a hardcoded 0xffffffff?
On 20 June 2013 13:18, Stefan Dösinger stefandoesinger@gmail.com wrote:
I don't know any application that depends on this. It just seemed like an interesting thing to test to see how far the interaction between the different APIs goes.
Just to make sure I understand you correctly: You're saying that the test should still call SetRenderState(LIGHTING), check the initial value, and GetRenderState(LIGHTING) should return a hardcoded 0xffffffff?
I think it may be enough to only ever set it and test that it doesn't affect rendering.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2013-06-20 13:23, schrieb Henri Verbeet:
Just to make sure I understand you correctly: You're saying that the test should still call SetRenderState(LIGHTING), check the initial value, and GetRenderState(LIGHTING) should return a hardcoded 0xffffffff?
I think it may be enough to only ever set it and test that it doesn't affect rendering.
Ok
-
Henri Verbeet -
Stefan Dösinger