the "hack" in only valid in a Win31/Win9x atchitecture; it works well will win98 winhlp32, but will likely fail for any NT implementation
so, we cannot have at the same time: 1/ a unique message passing feature for all emulated windows version 2/ the ability to run all the native winhlp32 executables
it means that we should either: 1/ emulate in a different manner the message passing ability of a given version (win16, win9x use a 16 bit global handle ; it seems NT uses a shared page) 2/ implement our own winhlp32 executable (with the support of various help formats) in which case we could choose our unique message passing implementation
for seek of completness, I'd choose 1/ for seek of code clarity/maintainability, 2/
A+
"Alexandre" == Alexandre Julliard julliard@winehq.com writes:
Alexandre> Eric Pouech <eric.pouech@wanadoo.fr> writes: >> Alexandre, will you accept a patch of this kind (it still can be >> enhanced, like storing the message id) ? Alexandre> Only if there is evidence that Windows does it this way.
I tried to follow native NT user32.dll in the winhelp() call and I ended in that magic 0x7ffeXXXX page, which seems to be shared data.
Do we have any plans for that page? NT File "explorer.exe" also crashes accessing that page.
I plea for encluding some WinHelp Hack. Users expect Winhelp to work. Eric's hack doesn't change wine fundamentals, is only changes one case.
Bye
Uwe Bonnes bon@elektron.ikp.physik.tu-darmstadt.de
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
--------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) The future will be better tomorrow, Vice President Dan Quayle
____________________________________________________________ Faites un voeu et puis Voila ! www.voila.fr Avec Voila Mail, consultez vos e-mails sur votre mobile Wap.
"Eric Pouech" eric.pouech@voila.fr writes:
it means that we should either: 1/ emulate in a different manner the message passing ability of a given version (win16, win9x use a 16 bit global handle ; it seems NT uses a shared page) 2/ implement our own winhlp32 executable (with the support of various help formats) in which case we could choose our unique message passing implementation
for seek of completness, I'd choose 1/ for seek of code clarity/maintainability, 2/
Clearly we will need to do 2/ anyway for people who don't have a copy of Windows around. At some point it may be a good idea to support the NT winhlp32 too; I don't think we should try to support Win98 type message passing.
On Wednesday 22 May 2002 21:30, Alexandre Julliard wrote:
Clearly we will need to do 2/ anyway for people who don't have a copy of Windows around. At some point it may be a good idea to support the NT winhlp32 too; I don't think we should try to support Win98 type message passing.
I had read much about that some win98 type features would not be supported only the NT types, and I'm wondering, why is then still the --winver win95 option is the default. I would think that then the --winver nt40 should be the default option, and if somebody needs, then he should explicitly say that he wants win95.
But at least it would be nice if we could configure the winver from the ~/.wine/config file.
Is there any reason not to do it?
Zsolt Rizsanyi
Rizsanyi Zsolt rizsanyi@neobee.net writes:
I had read much about that some win98 type features would not be supported only the NT types, and I'm wondering, why is then still the --winver win95 option is the default.
Actually the default is win31... But the correct value should be autodetected most of the time so it shouldn't matter much.
But at least it would be nice if we could configure the winver from the ~/.wine/config file.
Is there any reason not to do it?
No, it's done now <g>
On Thu, May 23, 2002 at 12:39:31PM -0700, Alexandre Julliard wrote:
Rizsanyi Zsolt rizsanyi@neobee.net writes:
I had read much about that some win98 type features would not be supported only the NT types, and I'm wondering, why is then still the --winver win95 option is the default.
Actually the default is win31... But the correct value should be autodetected most of the time so it shouldn't matter much.
Actually it's not ;-)
The default value is win95 (which is being returned by several subfunctions at the "default" code path) The preinitialized WIN31 value never gets used, as versionForced gets only set in case the user specified a different --winver value...
Believe me: I'd have changed this a loong time ago if this mechanism hadn't been the case... (WIN31 *is* outdated, there's no denial)
BTW, I've got some version.c update waiting, going to submit it soon.