Jon Griffiths jon_p_griffiths@yahoo.com writes:
Any problems with this one?
You said yourself that the some of the tests are currently failing; I cannot commit tests that fail, that would make the regression test suite useless.
"Alexandre" == Alexandre Julliard julliard@winehq.org writes:
Alexandre> Jon Griffiths jon_p_griffiths@yahoo.com writes: >> Any problems with this one?
Alexandre> You said yourself that the some of the tests are currently Alexandre> failing; I cannot commit tests that fail, that would make the Alexandre> regression test suite useless.
But we have a keyword for tests that we expect to fail. So changing the expected result to failing should make the patch appyable.
Bye