Re: wldap32/tests: Skip tests if ldap_init failed

[Hans Leidekker]

On Tue, 2011-08-09 at 19:17 +0200, André Hentschel wrote:
> diff --git a/dlls/wldap32/tests/parse.c b/dlls/wldap32/tests/parse.c
> index 4cf8564..faad474 100644
> --- a/dlls/wldap32/tests/parse.c
> +++ b/dlls/wldap32/tests/parse.c
> @@ -128,7 +128,11 @@ START_TEST (parse)
>      LDAP *ld;
>  ld = ldap_initA((char *)"ldap.itd.umich.edu", 389 );
> - ok( ld != NULL, "ldap_init failed\n" );
> -
>
> if (!ld)
> -
>
> {
> -
>    win_skip("ldap_init failed, skipping tests\n");
> -
>    return;
> -
>
> }
>
> test_ldap_parse_sort_control( ld );
> test_ldap_search_extW( ld );

Do you see it fail on Windows?

wldap32/tests: Skip tests if ldap_init failed

[André Hentschel]

Am 09.08.2011 19:26, schrieb Hans Leidekker:
> On Tue, 2011-08-09 at 19:17 +0200, André Hentschel wrote:
> > diff --git a/dlls/wldap32/tests/parse.c b/dlls/wldap32/tests/parse.c
> > index 4cf8564..faad474 100644
> > --- a/dlls/wldap32/tests/parse.c
> > +++ b/dlls/wldap32/tests/parse.c
> > @@ -128,7 +128,11 @@ START_TEST (parse)
> >      LDAP *ld;
> >  ld = ldap_initA((char *)"ldap.itd.umich.edu", 389 );
> > - ok( ld != NULL, "ldap_init failed\n" );
> > -
> >
> > if (!ld)
> > -
> >
> > {
> > -
> >    win_skip("ldap_init failed, skipping tests\n");
> > -
> >    return;
> > -
> >
> > }
> >
> > test_ldap_parse_sort_control( ld );
> > test_ldap_search_extW( ld );
>
> Do you see it fail on Windows?

oops