dxcore.dll or dxgi?

[James McDonnell]

Hi-d ho winerinos,

I have made some changes to add a dxcore.dll on a personal branch. I 
want to upstream the changes, however I'm unsure of whether I should 
create a new dll or just append it to dxgi.

Dxcore overlaps with dxgi, but presumably has separate functionality as 
well.

Thoughts?

Here is my branch if anyone wanted to review the commits.

https://gitlab.winehq.org/ElementalWarrior/wine/-/commits/affinity-photo2

Cheers,

James

[Stefan Dösinger]

Am Donnerstag, 16. März 2023, 09:23:58 EAT schrieb James McDonnell:
> Hi-d ho winerinos,
>
> I have made some changes to add a dxcore.dll on a personal branch. I
> want to upstream the changes, however I'm unsure of whether I should
> create a new dll or just append it to dxgi.
>
> Dxcore overlaps with dxgi, but presumably has separate functionality as
> well.
>
> Thoughts?

This is admittedly the first time I hear about dxcore. From a quick reading, 
my question is if dxcore is a strict subset of dxgi, and can thus be 
implemented on top of dxgi.

It is also possible to build them from the same codebase, e.g. how we handle 
different versions of msvcrt and d3dx*_*.dll. I suspect this is the more 
likely way this is implemented on Windows - apparently dxcore is also 
available as a Linux library to talk to d3d12 through the WSL2 virtual 
machine. Pulling in full dxgi is not an option here, but sharing code and 
#ifdef'ing half of it away is.

[Fabian Maurer]

Hello James,

you mean whether the function "DXCoreCreateAdapterFactory" should be put into
dxgi.dll or dxcore.dll?

Did you test where it is on windows using GetProcAddress?
I would assume it's in dxcore.

Regards,
Fabian Maurer