cups support apparently broken

[Michael Cardenas]

Hello all.

Apparently wine's cups support is broken.

With our old version of wine, wine would correctly detect the current cups 
printer, but it couldn't actually print to it. So, you would see the print 
dialog, but when you hit the print button nothing happened.

Now, I have cups installed and a build of yesterday's cvs and when I try to 
print wine tells me that there are no printers installed and I should "point 
to settings on the windows start menu, click printers" and add a printer.

Anyone have any ideas on how this broke?

thank you
michael

[Michael Cardenas]

Is there a better place to send this type of thing so that it will get some 
kind of attention? Is everybody regularly checking bugzilla, for example?

On Wednesday 24 April 2002 04:42 pm, Michael Cardenas wrote:
> Hello all.
>
> Apparently wine's cups support is broken.
>
> With our old version of wine, wine would correctly detect the current cups
> printer, but it couldn't actually print to it. So, you would see the print
> dialog, but when you hit the print button nothing happened.
>
> Now, I have cups installed and a build of yesterday's cvs and when I try to
> print wine tells me that there are no printers installed and I should
> "point to settings on the windows start menu, click printers" and add a
> printer.
>
> Anyone have any ideas on how this broke?
>
> thank you
> michael

[Marcus Meissner]

On Wed, Apr 24, 2002 at 04:42:37PM -0400, Michael Cardenas wrote:
> Hello all.
>
> Apparently wine's cups support is broken.
>
> With our old version of wine, wine would correctly detect the current cups 
> printer, but it couldn't actually print to it. So, you would see the print 
> dialog, but when you hit the print button nothing happened.
>
> Now, I have cups installed and a build of yesterday's cvs and when I try to 
> print wine tells me that there are no printers installed and I should "point 
> to settings on the windows start menu, click printers" and add a printer.

Actually I just did a full recompile and I am still able to print.
(Tested using standard 32bit notepad.exe.)

What changed in the last time is that I have implemented PageSetupDlgW and
PrintDlgW, but these were just additions.

Are you still using the same test application? Did you compile in CUPS support?
(ldd winspooldrv.so shoud show libcups.so referenced).

Ciao, Marcus

[Michael Cardenas]

On Sat, Apr 27, 2002 at 10:53:20PM +0200, Marcus Meissner wrote:
> Actually I just did a full recompile and I am still able to print.
> (Tested using standard 32bit notepad.exe.)

I apologize for the erroneous bug report. I didn't have libcupsys2-dev
on my machine. Now that I have that and I did a full recompile, I can
get a print dialog from word with the correct printer description, but
when I click the print button, it doesn't print.

Printing from notepad doesn't work either, it seems to do something, and
gives me an hourglass that goes away once you move the mouse. I've
attached the output of +psdrv to this email.
> Are you still using the same test application? Did you compile in CUPS support?
> (ldd winspooldrv.so shoud show libcups.so referenced).

I usually use word as my test application.

Crossover office can actually print from word, excel, outlook and ie,
but not notepad.

thanks
     michael

[Huw D M Davies]

On Mon, Apr 29, 2002 at 09:51:00AM -0400, Michael Cardenas wrote:
> On Sat, Apr 27, 2002 at 10:53:20PM +0200, Marcus Meissner wrote:
> > Actually I just did a full recompile and I am still able to print.
> > (Tested using standard 32bit notepad.exe.)
>
> I apologize for the erroneous bug report. I didn't have libcupsys2-dev
> on my machine. Now that I have that and I did a full recompile, I can
> get a print dialog from word with the correct printer description, but
> when I click the print button, it doesn't print.
>
> Printing from notepad doesn't work either, it seems to do something, and
> gives me an hourglass that goes away once you move the mouse. I've
> attached the output of +psdrv to this email.
> > Are you still using the same test application? Did you compile in CUPS support?
> > (ldd winspooldrv.so shoud show libcups.so referenced).
>
> I usually use word as my test application.
>
> Crossover office can actually print from word, excel, outlook and ie,
> but not notepad.

You might want to run with +print,+winspool to check that the job is
being piped to the right command.

Huw.

[Michael Cardenas]

Hmmm...

thanks huw! apparently, wine is getting the wrong print command.

Printing from kwrite, I see this on the console:

cmd1 = /bin/apsprint -P'eng' --format=application/postscript
--attrmultiple-document-handling=separate-documents-uncollated-copies

whereas using +print in wine I get this message:

trace:print:OpenJob16 'LPR:eng' 'Untitled - Notepad' 0b50
trace:print:CreateSpoolFile Got printerSpoolCommand '|lpr -Peng' for
output device 'LPR:eng'

trying to do an

echo "print" | lpr -Peng

doesn't create any output from the printer.

On Mon, Apr 29, 2002 at 09:26:42PM +0100, Huw D M Davies wrote:
> On Mon, Apr 29, 2002 at 09:51:00AM -0400, Michael Cardenas wrote:
> > On Sat, Apr 27, 2002 at 10:53:20PM +0200, Marcus Meissner wrote:
> > > Actually I just did a full recompile and I am still able to print.
> > > (Tested using standard 32bit notepad.exe.)
> >
> > I apologize for the erroneous bug report. I didn't have libcupsys2-dev
> > on my machine. Now that I have that and I did a full recompile, I can
> > get a print dialog from word with the correct printer description, but
> > when I click the print button, it doesn't print.
> >
> > Printing from notepad doesn't work either, it seems to do something, and
> > gives me an hourglass that goes away once you move the mouse. I've
> > attached the output of +psdrv to this email.
> > > Are you still using the same test application? Did you compile in CUPS support?
> > > (ldd winspooldrv.so shoud show libcups.so referenced).
> >
> > I usually use word as my test application.
> >
> > Crossover office can actually print from word, excel, outlook and ie,
> > but not notepad.
>
> You might want to run with +print,+winspool to check that the job is
> being piped to the right command.
>
> Huw.

[Marcus Meissner]

On Mon, Apr 29, 2002 at 01:56:51PM -0400, Michael Cardenas wrote:
> Hmmm...
>
> thanks huw! apparently, wine is getting the wrong print command.
>
> Printing from kwrite, I see this on the console:
>
> cmd1 = /bin/apsprint -P'eng' --format=application/postscript
> --attrmultiple-document-handling=separate-documents-uncollated-copies
>
> whereas using +print in wine I get this message:
>
> trace:print:OpenJob16 'LPR:eng' 'Untitled - Notepad' 0b50
> trace:print:CreateSpoolFile Got printerSpoolCommand '|lpr -Peng' for
> output device 'LPR:eng'
>
> trying to do an
>
> echo "print" | lpr -Peng
>
> doesn't create any output from the printer.

Actually WINE assumes that a CUPS printer can be sent jobs using
lpr -P<printername> on stdin.

If this is not the case, you will have to change dlls/gdi/printdrv.c 
and dlls/winspool/info.c.

Ciao, Marcus

[Michael Cardenas]

On Mon, Apr 29, 2002 at 10:09:19PM +0200, Marcus Meissner wrote:
> > trying to do an
> >
> > echo "print" | lpr -Peng
>
> Actually WINE assumes that a CUPS printer can be sent jobs using
> lpr -P<printername> on stdin.
>
> If this is not the case, you will have to change dlls/gdi/printdrv.c 
> and dlls/winspool/info.c.

Apparently, the correct command for cups is lp and -P needs to be
replaced with -d

so by changing

if (!strncmp("LPR:",pszOutput,4))
          sprintf(psCmd,"|lpr -P%s",pszOutput+4);

to

if (!strncmp("LPR:",pszOutput,4))
          sprintf(psCmd,"|lp -d%s",pszOutput+4);

in

wine/dlls/gdi/printdrv.c

it now works, but only for CUPS printers.

I'll send a patch that checks the registry for a description with CUPS
in it and uses lp -d if appropriate.

thanks for the help.

[Michael Stefaniuc]

On Mon, Apr 29, 2002 at 02:53:32PM -0400, Michael Cardenas wrote:
> On Mon, Apr 29, 2002 at 10:09:19PM +0200, Marcus Meissner wrote:
> > > trying to do an
> > >
> > > echo "print" | lpr -Peng
> >
> > Actually WINE assumes that a CUPS printer can be sent jobs using
> > lpr -P<printername> on stdin.
> >
> > If this is not the case, you will have to change dlls/gdi/printdrv.c 
> > and dlls/winspool/info.c.
>
> Apparently, the correct command for cups is lp and -P needs to be
> replaced with -d

I don't know how the cups package is build on debian, but cups provides both
commands lpr and lp. And both commands work.

bye
    michael
> so by changing
> if (!strncmp("LPR:",pszOutput,4))
>       sprintf(psCmd,"|lpr -P%s",pszOutput+4);
>
> to
> if (!strncmp("LPR:",pszOutput,4))
>       sprintf(psCmd,"|lp -d%s",pszOutput+4);
>
> in
>
> wine/dlls/gdi/printdrv.c
>
> it now works, but only for CUPS printers.
>
> I'll send a patch that checks the registry for a description with CUPS
> in it and uses lp -d if appropriate.
>
> thanks for the help.