On Friday 14 November 2008 19:13:32 Juan Lang wrote:
I find that a bit alarming. I'm sure he's working very hard, and doing good stuff, but I don't think Wine should be redrawing anything. Not when we have Tango around - it's designed to try create some consistency through standardisation. IMO standards are really good! - we use them if we possibly can.
The trouble is that the Tango icon set doesn't cover all the icons Wine needs. There's no Tango icon for regedit, for instance.
IIRC there's Tango icon sets for specific applications. If we're doing our own icons anyway, we could try to keep them coherent with the rest of the Tango look and get the icons upstream to Tango.
This seems like the most reasonable approach. Of course the only things I usually paint are walls so I'd have no idea how easy it is to match the Tango specs when designing icons.
Cheers, Kai
First of all, sorry to not have answered before and for my poor English, but I was quite busy these past months and I didn't see all these messages since today. I realize that the two patch I sent an hour ago are not the best answer to all these issues (I think these two newer icons look nicer in the open dialog boxes anyway) and that all theses points have to be discussed.
When remaking icons, I tried to add a bit of consistency while improving a bit the icons. Obviously, I missed something. Reading all theses remarks, I agree that a better way to handle these icons are to use the Tango ones when they are available. As it was stated, including them is not straightforward and I haven't the skill to work on including these libraries into the wine tree. I hope somebody will work on these issues. In the meanwhile, maybe I'll try to improve the others shell32 icons as the bin or the computer which I found awful in this size but I don't know if it's a good idea.
Cheers, Hervé
On Wed, 2008-12-10 at 20:43 +0000, Hervÿffffe9 Chanal wrote:
On Friday 14 November 2008 19:13:32 Juan Lang wrote:
I find that a bit alarming. I'm sure he's working very hard, and doing good stuff, but I don't think Wine should be redrawing anything. Not when we have Tango around - it's designed to try create some consistency through standardisation. IMO standards are really good! - we use them if we possibly can.
The trouble is that the Tango icon set doesn't cover all the icons Wine needs. There's no Tango icon for regedit, for instance.
IIRC there's Tango icon sets for specific applications. If we're doing our own icons anyway, we could try to keep them coherent with the rest of the Tango look and get the icons upstream to Tango.
This seems like the most reasonable approach. Of course the only things I usually paint are walls so I'd have no idea how easy it is to match the Tango specs when designing icons.
Cheers, Kai
First of all, sorry to not have answered before and for my poor English, but I was quite busy these past months and I didn't see all these messages since today. I realize that the two patch I sent an hour ago are not the best answer to all these issues (I think these two newer icons look nicer in the open dialog boxes anyway) and that all theses points have to be discussed.
When remaking icons, I tried to add a bit of consistency while improving a bit the icons. Obviously, I missed something. Reading all theses remarks, I agree that a better way to handle these icons are to use the Tango ones when they are available. As it was stated, including them is not straightforward and I haven't the skill to work on including these libraries into the wine tree. I hope somebody will work on these issues. In the meanwhile, maybe I'll try to improve the others shell32 icons as the bin or the computer which I found awful in this size but I don't know if it's a good idea.
Cheers, Hervé
Hi Herve,
Yes I agree it would be good for the icons to get some improvement. Some of the ones there currently are pretty poor. We really need to try and get as much consistency as we can. I really would encourage you to go for tango if you can. It's served ReactOS well. It might even be possible for me to help with making custom Tango icons.
Here on the Lumiera project we've adopted a method for making icons called the one canvas work flow, which was inspired by these videos: http://blip.tv/file/1075329 and http://blip.tv/file/1077148
This allows you to use a single SVG canvas with icon drawings specialised for different sizes. A script is then executed as part of the build process to render the individual sizes into their appropriate PNGs.
The Tango library is large, so there are many icons available already. You might find this helpful in seeing what's already there: http://people.freedesktop.org/~jimmac/icons/#tit
Let me know if I can help at all.
God bless Joel
Joel Holdsworth joel@airwebreathe.org.uk writes:
Yes I agree it would be good for the icons to get some improvement. Some of the ones there currently are pretty poor. We really need to try and get as much consistency as we can. I really would encourage you to go for tango if you can. It's served ReactOS well. It might even be possible for me to help with making custom Tango icons.
Last I checked the Tango icons are under a Creative Commons license that is not compatible with the LGPL, so I'm afraid it's not an option.
Joel Holdsworth joel@airwebreathe.org.uk writes:
Yes I agree it would be good for the icons to get some improvement. Some of the ones there currently are pretty poor. We really need to try and get as much consistency as we can. I really would encourage you to go for tango if you can. It's served ReactOS well. It might even be possible for me to help with making custom Tango icons.
Last I checked the Tango icons are under a Creative Commons license that is not compatible with the LGPL, so I'm afraid it's not an option.
-- Alexandre Julliard julliard@winehq.org
At this point Tango is Creative Commons but according to a post on their mailing list they are planning to move to public domain. (http://lists.freedesktop.org/archives/tango-artists/2008-September/001890.ht...) Further there are some more licensing discussions. I doubt their intension is to not allow open source projects not to use their icons. We could ask them to relicense them.
Roderick
Joel Holdsworth joel@airwebreathe.org.uk writes:
Yes I agree it would be good for the icons to get some improvement.
Some
of the ones there currently are pretty poor. We really need to try and get as much consistency as we can. I really would encourage you to go for tango if you can. It's served ReactOS well. It might even be possible for me to help with making custom Tango icons.
Last I checked the Tango icons are under a Creative Commons license that is not compatible with the LGPL, so I'm afraid it's not an option.
-- Alexandre Julliard julliard@winehq.org
At this point Tango is Creative Commons but according to a post on their mailing list they are planning to move to public domain. (http://lists.freedesktop.org/archives/tango-artists/2008-September/001890.ht...) Further there are some more licensing discussions. I doubt their intension is to not allow open source projects not to use their icons. We could ask them to relicense them.
Roderick
After thinking a bit more about it I think we can use the Tango icons in their current form. To me it sounds like the main issue is that we need to merge the icons into our own dlls. Windows XP style themes allow you to replace icons. If we would improve our theming code, so that we can use icons from theme files then we would be able to use the tango icons.
Roderick
Joel Holdsworth joel@airwebreathe.org.uk writes:
Yes I agree it would be good for the icons to get some improvement.
Some
of the ones there currently are pretty poor. We really need to try and get as much consistency as we can. I really would encourage you to go for tango if you can. It's served ReactOS well. It might even be possible for me to help with making custom Tango icons.
Last I checked the Tango icons are under a Creative Commons license that is not compatible with the LGPL, so I'm afraid it's not an option.
-- Alexandre Julliard julliard@winehq.org
At this point Tango is Creative Commons but according to a post on their mailing list they are planning to move to public domain. (http://lists.freedesktop.org/archives/tango-artists/2008-September/001890.ht...) Further there are some more licensing discussions. I doubt their intension is to not allow open source projects not to use their icons. We could ask them to relicense them.
Roderick
Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger
I talked to the tango guys on irc (#tango on freenode) and they are willing to relicense fonts if we know which ones we want. We need to email the tango list for that. At some point in the future a lot of tango fonts will become public domain and another part (the gnome theme set) will be licensed under the LGPL.
So with a small amount of effort we should be able to use tango in Wine :)
Roderick
-
Alexandre Julliard -
Hervÿffffe9 Chanal -
Joel Holdsworth -
Roderick Colenbrander