Re: oleaut32: Fix failing VarMod tests in WinXP, fix VarMod(VT_DECIMAL) in Wine

[Robert Shearman]

[e-mail] wrote:
> In a preparation for a possible implementation of IDispatch
> tests in oleaut32, I decided to clean up the failing tests in
> Windows XP:

Great, thanks for fixing this.

I was about to do this myself. It's about time we get the number of 
failing tests on XP as close to zero as possible.

oleaut32: Fix failing VarMod tests in WinXP, fix VarMod(VT_DECIMAL) in Wine

[Alex Villací­s Lasso]

Robert Shearman escribió:
> [e-mail] wrote:
> > In a preparation for a possible implementation of IDispatch
> > tests in oleaut32, I decided to clean up the failing tests in
> > Windows XP:
>
> Great, thanks for fixing this.
>
> I was about to do this myself. It's about time we get the number of 
> failing tests on XP as close to zero as possible.

BTW, in case nobody knows, the BOOL->BSTR conversion is localized in 
WinXP (so that in Spanish locales, conversion to strings gives 
"Verdadero", not "True" as tested). Apparently it is *not* localized in 
Win98SE. I don't have any other Windows versions available, but this 
means at least two test failures on non-English versions of WinXP. Does 
this mean that a comparison to a specific string is pointless and should 
be removed?

oleaut32: Fix failing VarMod tests in WinXP, fix VarMod(VT_DECIMAL) in Wine

[Alexandre Julliard]

Alex Villací­s Lasso  writes:
> BTW, in case nobody knows, the BOOL->BSTR conversion is localized in
> WinXP (so that in Spanish locales, conversion to strings gives
> "Verdadero", not "True" as tested). Apparently it is *not* localized
> in Win98SE. I don't have any other Windows versions available, but
> this means at least two test failures on non-English versions of
> WinXP. Does this mean that a comparison to a specific string is
> pointless and should be removed?

It should not be removed, but it can be disabled when the current
locale is not English.