Re: [PATCH 1/2] d3dx10: Add D3D10CreateEffectPoolFromMemory stub

[Józef Kucia]

On Tue, Mar 29, 2016 at 9:07 AM, Alistair Leslie-Hughes
 wrote:
> dlls/d3d10/d3d10.spec     | 2 +-
>  dlls/d3d10/d3d10_main.c   | 9 +++++++++
>  dlls/d3d10_1/d3d10_1.spec | 2 +-
>  include/d3d10effect.h     | 2 ++

The subject prefix should be "d3d10:".
> +HRESULT WINAPI D3D10CreateEffectPoolFromMemory(void *data, SIZE_T data_size, UINT fx_flags,
> -
>    ID3D10Device *device, ID3D10EffectPool **effectpool)
>
> +{

Please use "effect_pool" instead of "effectpool", mainly for
consistency (snake_case).
> - FIXME("data %p, data_size %lu, fx_flags %#x, device %p, effectpool %p.\n",
> -
>        data, data_size, fx_flags, device, effectpool);

The FIXME() message should end with "stub!" or "stub.".
> - return E_NOTIMPL;
>
> +}
> -

I think you can remove this additional empty line.
> diff --git a/include/d3d10effect.h b/include/d3d10effect.h
> index 1494894..5dafdae 100644
> --- a/include/d3d10effect.h
> +++ b/include/d3d10effect.h
> @@ -832,6 +832,8 @@ HRESULT WINAPI D3D10CompileEffectFromMemory(void *data, SIZE_T data_size, const
>          ID3D10Blob **effect, ID3D10Blob **errors);
>  HRESULT WINAPI D3D10CreateEffectFromMemory(void *data, SIZE_T data_size, UINT flags,
>          ID3D10Device *device, ID3D10EffectPool *effect_pool, ID3D10Effect **effect);
> +HRESULT WINAPI D3D10CreateEffectPoolFromMemory(void *data, SIZE_T data_size, UINT fx_flags,
> -
>    ID3D10Device *device, ID3D10EffectPool **effectpool);

It should be "effect_pool" instead of "effectpool".