Hi James,
This monthcal test fails on my win2k box (w2k-sp4-fr) before and after your patch. I did search other similar failure where WM_QUERYNEWPALETTE comes right after the WM_CREATE message but can't find one. So I assume your patch was to fix the failure on my box. But in my case the WM_QUERYNEWPALETTE comes between the two WM_WINDOWPOSCHANGING message.
I was just about to send a patch to fix this just moving your new line a little bit down in the sequence but I prefer to be sure. If there is platforms where WM_QUERYNEWPALETTE comes just after the WM_CREATE message I can leave it here and add a new optional one between the two WM_WINDOWPOSCHANGING messages, it won't hurt.
regards, Nicolas
On Sun, Sep 14, 2008 at 7:25 PM, Nicolas Le Cam niko.lecam@gmail.com wrote:
Hi James,
This monthcal test fails on my win2k box (w2k-sp4-fr) before and after your patch. I did search other similar failure where WM_QUERYNEWPALETTE comes right after the WM_CREATE message but can't find one. So I assume your patch was to fix the failure on my box. But in my case the WM_QUERYNEWPALETTE comes between the two WM_WINDOWPOSCHANGING message.
I was just about to send a patch to fix this just moving your new line a little bit down in the sequence but I prefer to be sure. If there is platforms where WM_QUERYNEWPALETTE comes just after the WM_CREATE message I can leave it here and add a new optional one between the two WM_WINDOWPOSCHANGING messages, it won't hurt.
I don't know, that was way too many robot patches ago to remember.
Ok I will add a new line without removing yours as it definitely won't hurt.
Nicolas Le Cam
2008/9/15 James Hawkins jhawkins@codeweavers.com:
I don't know, that was way too many robot patches ago to remember.
-- James Hawkins
On Sun, Sep 14, 2008 at 7:42 PM, Nicolas Le Cam niko.lecam@gmail.com wrote:
Ok I will add a new line without removing yours as it definitely won't hurt.
No, you should probably just move it...if we then see another failing result, we can add it back. I probably just put it in the wrong place.
OK will do that, thanks.
2008/9/15 James Hawkins jhawkins@codeweavers.com:
On Sun, Sep 14, 2008 at 7:42 PM, Nicolas Le Cam niko.lecam@gmail.com wrote:
Ok I will add a new line without removing yours as it definitely won't hurt.
No, you should probably just move it...if we then see another failing result, we can add it back. I probably just put it in the wrong place.
-- James Hawkins
-
James Hawkins -
Nicolas Le Cam