[PATCH 1/2] xaudio2: Add TRACE functions to CreateAudioReverb/CreateAudioVolumeMeter

From: Ethan Lee

Signed-off-by: Ethan Lee 
---
 dlls/xaudio2_7/xaudio_dll.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/dlls/xaudio2_7/xaudio_dll.c b/dlls/xaudio2_7/xaudio_dll.c
index da0b0aa606..a87e0124d3 100644
--- a/dlls/xaudio2_7/xaudio_dll.c
+++ b/dlls/xaudio2_7/xaudio_dll.c
@@ -2075,6 +2075,8 @@ HRESULT WINAPI CreateAudioVolumeMeter(IUnknown **out)
     IClassFactory *cf;
     HRESULT hr;

+    TRACE("%p\n", out);
+
     hr = make_xapo_factory(&CLSID_AudioVolumeMeter27, &IID_IClassFactory, (void**)&cf);
     if(FAILED(hr))
         return hr;
@@ -2091,6 +2093,8 @@ HRESULT WINAPI CreateAudioReverb(IUnknown **out)
     IClassFactory *cf;
     HRESULT hr;

+    TRACE("%p\n", out);
+
     hr = make_xapo_factory(&CLSID_AudioReverb27, &IID_IClassFactory, (void**)&cf);
     if(FAILED(hr))
         return hr;

[PATCH 2/2] xaudio2: Fix the export order for CreateAudioReverb/CreateAudioVolumeMeter

From: Ethan Lee

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47437
Signed-off-by: Ethan Lee 
---
 dlls/xaudio2_8/xaudio2_8.spec | 2 +-
 dlls/xaudio2_9/xaudio2_9.spec | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/xaudio2_8/xaudio2_8.spec b/dlls/xaudio2_8/xaudio2_8.spec
index 0b9f23866b..50a2090f44 100644
--- a/dlls/xaudio2_8/xaudio2_8.spec
+++ b/dlls/xaudio2_8/xaudio2_8.spec
@@ -1,6 +1,6 @@
 @ stdcall XAudio2Create(ptr long long)
-@ stdcall CreateAudioVolumeMeter(ptr)
 @ stdcall CreateAudioReverb(ptr)
+@ stdcall CreateAudioVolumeMeter(ptr)
 @ cdecl CreateFX(ptr ptr ptr long)
 @ cdecl X3DAudioCalculate(ptr ptr ptr long ptr)
 @ cdecl X3DAudioInitialize(long float ptr)
diff --git a/dlls/xaudio2_9/xaudio2_9.spec b/dlls/xaudio2_9/xaudio2_9.spec
index 0b9f23866b..50a2090f44 100644
--- a/dlls/xaudio2_9/xaudio2_9.spec
+++ b/dlls/xaudio2_9/xaudio2_9.spec
@@ -1,6 +1,6 @@
 @ stdcall XAudio2Create(ptr long long)
-@ stdcall CreateAudioVolumeMeter(ptr)
 @ stdcall CreateAudioReverb(ptr)
+@ stdcall CreateAudioVolumeMeter(ptr)
 @ cdecl CreateFX(ptr ptr ptr long)
 @ cdecl X3DAudioCalculate(ptr ptr ptr long ptr)
 @ cdecl X3DAudioInitialize(long float ptr)

[PATCH 2/2] xaudio2: Fix the export order for CreateAudioReverb/CreateAudioVolumeMeter

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=54301

Your paranoid android.

=== debian9 (32 bit report) ===

Report errors:
The report seems to have been truncated

=== debian9 (32 bit WoW report) ===

Report errors:
The report seems to have been truncated

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=54300

Your paranoid android.

=== debian9 (32 bit report) ===

Report errors:
The report seems to have been truncated

=== debian9 (32 bit WoW report) ===

Report errors:
The report seems to have been truncated

[Andrew Eikum]

Signed-off-by: Andrew Eikum

On Mon, Jul 01, 2019 at 01:53:54PM -0400, [e-mail] wrote:
> From: Ethan Lee
> Signed-off-by: Ethan Lee
>
> dlls/xaudio2_7/xaudio_dll.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/dlls/xaudio2_7/xaudio_dll.c b/dlls/xaudio2_7/xaudio_dll.c
> index da0b0aa606..a87e0124d3 100644
> --- a/dlls/xaudio2_7/xaudio_dll.c
> +++ b/dlls/xaudio2_7/xaudio_dll.c
> @@ -2075,6 +2075,8 @@ HRESULT WINAPI CreateAudioVolumeMeter(IUnknown **out)
>      IClassFactory *cf;
>      HRESULT hr;
> - TRACE("%p\n", out);
> - hr = make_xapo_factory(&CLSID_AudioVolumeMeter27, &IID_IClassFactory, (void**)&cf);
>    if(FAILED(hr))
>        return hr;
>
> @@ -2091,6 +2093,8 @@ HRESULT WINAPI CreateAudioReverb(IUnknown **out)
>      IClassFactory *cf;
>      HRESULT hr;
> - TRACE("%p\n", out);
> - hr = make_xapo_factory(&CLSID_AudioReverb27, &IID_IClassFactory, (void**)&cf);
>    if(FAILED(hr))
>        return hr;
>
> -- 
> 2.21.0